You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by "Paul Ramirez (Created) (JIRA)" <ji...@apache.org> on 2012/02/27 05:07:55 UTC
[jira] [Created] (OODT-389) Implement Lucene catalog initialization
at Workflow Manager startup
Implement Lucene catalog initialization at Workflow Manager startup
-------------------------------------------------------------------
Key: OODT-389
URL: https://issues.apache.org/jira/browse/OODT-389
Project: OODT
Issue Type: Bug
Components: workflow manager
Affects Versions: 0.3
Reporter: Paul Ramirez
Assignee: Paul Ramirez
Fix For: 0.4
When using the lucene instance repository it is not initialized on startup. This will be resolved in a similar manner to OODT-380.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-389) Implement Lucene catalog
initialization at Workflow Manager startup
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217065#comment-13217065 ]
jiraposter@reviews.apache.org commented on OODT-389:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4049/#review5349
-----------------------------------------------------------
http://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/instrepo/LuceneWorkflowInstanceRepositoryFactory.java
<https://reviews.apache.org/r/4049/#comment11653>
writer.close() should be in a finally{} block
http://svn.apache.org/repos/asf/oodt/trunk/workflow/src/test/org/apache/oodt/cas/workflow/instrepo/TestLuceneWorkflowInstanceRepository.java
<https://reviews.apache.org/r/4049/#comment11654>
Apache FileUtils.forceDelete(File dir) I believe will do the same thing
- brian
On 2012-02-27 05:03:29, Paul Ramirez wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4049/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-27 05:03:29)
bq.
bq.
bq. Review request for Chris Mattmann and brian Foster.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This initializes the instance repo within the factory. In addition, some minor refactoring of the unit tests to have a setup and teardown function to support creating of the instance repo from the factory.
bq.
bq. In addition, the unit test now reads in the workflow.properties and overwrites some of them.
bq.
bq.
bq. This addresses bug OODT-389.
bq. https://issues.apache.org/jira/browse/OODT-389
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/instrepo/LuceneWorkflowInstanceRepositoryFactory.java 1294024
bq. http://svn.apache.org/repos/asf/oodt/trunk/workflow/src/test/org/apache/oodt/cas/workflow/instrepo/TestLuceneWorkflowInstanceRepository.java 1294024
bq.
bq. Diff: https://reviews.apache.org/r/4049/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Paul
bq.
bq.
> Implement Lucene catalog initialization at Workflow Manager startup
> -------------------------------------------------------------------
>
> Key: OODT-389
> URL: https://issues.apache.org/jira/browse/OODT-389
> Project: OODT
> Issue Type: Bug
> Components: workflow manager
> Affects Versions: 0.3
> Reporter: Paul Ramirez
> Assignee: Paul Ramirez
> Fix For: 0.4
>
> Attachments: oodt-389-patch.txt
>
>
> When using the lucene instance repository it is not initialized on startup. This will be resolved in a similar manner to OODT-380.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-389) Implement Lucene catalog
initialization at Workflow Manager startup
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217040#comment-13217040 ]
jiraposter@reviews.apache.org commented on OODT-389:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4049/
-----------------------------------------------------------
(Updated 2012-02-27 05:03:29.675042)
Review request for Chris Mattmann and brian Foster.
Changes
-------
Attached issue number
Summary
-------
This initializes the instance repo within the factory. In addition, some minor refactoring of the unit tests to have a setup and teardown function to support creating of the instance repo from the factory.
In addition, the unit test now reads in the workflow.properties and overwrites some of them.
This addresses bug OODT-389.
https://issues.apache.org/jira/browse/OODT-389
Diffs
-----
http://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/instrepo/LuceneWorkflowInstanceRepositoryFactory.java 1294024
http://svn.apache.org/repos/asf/oodt/trunk/workflow/src/test/org/apache/oodt/cas/workflow/instrepo/TestLuceneWorkflowInstanceRepository.java 1294024
Diff: https://reviews.apache.org/r/4049/diff
Testing
-------
Thanks,
Paul
> Implement Lucene catalog initialization at Workflow Manager startup
> -------------------------------------------------------------------
>
> Key: OODT-389
> URL: https://issues.apache.org/jira/browse/OODT-389
> Project: OODT
> Issue Type: Bug
> Components: workflow manager
> Affects Versions: 0.3
> Reporter: Paul Ramirez
> Assignee: Paul Ramirez
> Fix For: 0.4
>
> Attachments: oodt-389-patch.txt
>
>
> When using the lucene instance repository it is not initialized on startup. This will be resolved in a similar manner to OODT-380.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-389) Implement Lucene catalog initialization
at Workflow Manager startup
Posted by "Paul Ramirez (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Ramirez updated OODT-389:
------------------------------
Attachment: oodt-389-patch.txt
Initialization of lucene instance repo within factory and setup and tear down within unit tests.
> Implement Lucene catalog initialization at Workflow Manager startup
> -------------------------------------------------------------------
>
> Key: OODT-389
> URL: https://issues.apache.org/jira/browse/OODT-389
> Project: OODT
> Issue Type: Bug
> Components: workflow manager
> Affects Versions: 0.3
> Reporter: Paul Ramirez
> Assignee: Paul Ramirez
> Fix For: 0.4
>
> Attachments: oodt-389-patch.txt
>
>
> When using the lucene instance repository it is not initialized on startup. This will be resolved in a similar manner to OODT-380.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-389) Implement Lucene catalog
initialization at Workflow Manager startup
Posted by "Paul Ramirez (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217039#comment-13217039 ]
Paul Ramirez commented on OODT-389:
-----------------------------------
Patch under review at https://reviews.apache.org/r/4049/
> Implement Lucene catalog initialization at Workflow Manager startup
> -------------------------------------------------------------------
>
> Key: OODT-389
> URL: https://issues.apache.org/jira/browse/OODT-389
> Project: OODT
> Issue Type: Bug
> Components: workflow manager
> Affects Versions: 0.3
> Reporter: Paul Ramirez
> Assignee: Paul Ramirez
> Fix For: 0.4
>
> Attachments: oodt-389-patch.txt
>
>
> When using the lucene instance repository it is not initialized on startup. This will be resolved in a similar manner to OODT-380.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OODT-389) Implement Lucene catalog
initialization at Workflow Manager startup
Posted by "Paul Ramirez (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Ramirez resolved OODT-389.
-------------------------------
Resolution: Fixed
Committed revision 1294245
> Implement Lucene catalog initialization at Workflow Manager startup
> -------------------------------------------------------------------
>
> Key: OODT-389
> URL: https://issues.apache.org/jira/browse/OODT-389
> Project: OODT
> Issue Type: Bug
> Components: workflow manager
> Affects Versions: 0.3
> Reporter: Paul Ramirez
> Assignee: Paul Ramirez
> Fix For: 0.4
>
> Attachments: oodt-389-patch.txt
>
>
> When using the lucene instance repository it is not initialized on startup. This will be resolved in a similar manner to OODT-380.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-389) Implement Lucene catalog
initialization at Workflow Manager startup
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217084#comment-13217084 ]
jiraposter@reviews.apache.org commented on OODT-389:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4049/#review5352
-----------------------------------------------------------
Ship it!
Looks good to me!
- Chris
On 2012-02-27 05:03:29, Paul Ramirez wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4049/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-27 05:03:29)
bq.
bq.
bq. Review request for Chris Mattmann and brian Foster.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This initializes the instance repo within the factory. In addition, some minor refactoring of the unit tests to have a setup and teardown function to support creating of the instance repo from the factory.
bq.
bq. In addition, the unit test now reads in the workflow.properties and overwrites some of them.
bq.
bq.
bq. This addresses bug OODT-389.
bq. https://issues.apache.org/jira/browse/OODT-389
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/instrepo/LuceneWorkflowInstanceRepositoryFactory.java 1294024
bq. http://svn.apache.org/repos/asf/oodt/trunk/workflow/src/test/org/apache/oodt/cas/workflow/instrepo/TestLuceneWorkflowInstanceRepository.java 1294024
bq.
bq. Diff: https://reviews.apache.org/r/4049/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Paul
bq.
bq.
> Implement Lucene catalog initialization at Workflow Manager startup
> -------------------------------------------------------------------
>
> Key: OODT-389
> URL: https://issues.apache.org/jira/browse/OODT-389
> Project: OODT
> Issue Type: Bug
> Components: workflow manager
> Affects Versions: 0.3
> Reporter: Paul Ramirez
> Assignee: Paul Ramirez
> Fix For: 0.4
>
> Attachments: oodt-389-patch.txt
>
>
> When using the lucene instance repository it is not initialized on startup. This will be resolved in a similar manner to OODT-380.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira