You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/12/18 19:30:09 UTC
[kudu-CR] KUDU-1097: try adding a new replica when majority is on-line
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8863
Change subject: KUDU-1097: try adding a new replica when majority is on-line
......................................................................
KUDU-1097: try adding a new replica when majority is on-line
With this patch, the consensus::ShouldAddReplica() utility function
checks whether a majority of voter replicas is on-line before attempting
to add a new non-voter replica into the tablet Raft configuration. This
makes it more consistent with the behavior of the 'symmetric'
consensus::ShouldEvictReplica() function.
Change-Id: Ida198b96e76102f82d0b32116c45e41d26d15314
---
M src/kudu/consensus/quorum_util-test.cc
M src/kudu/consensus/quorum_util.cc
2 files changed, 67 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/8863/1
--
To view, visit http://gerrit.cloudera.org:8080/8863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida198b96e76102f82d0b32116c45e41d26d15314
Gerrit-Change-Number: 8863
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] KUDU-1097: try adding a new replica when majority is on-line
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8863
to look at the new patch set (#3).
Change subject: KUDU-1097: try adding a new replica when majority is on-line
......................................................................
KUDU-1097: try adding a new replica when majority is on-line
With this patch, the consensus::ShouldAddReplica() utility function
checks whether a majority of voter replicas is on-line before attempting
to add a new non-voter replica into the tablet Raft configuration. This
makes it more consistent with the behavior of the 'symmetric'
consensus::ShouldEvictReplica() function.
Change-Id: Ida198b96e76102f82d0b32116c45e41d26d15314
---
M src/kudu/consensus/quorum_util-test.cc
M src/kudu/consensus/quorum_util.cc
2 files changed, 67 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/8863/3
--
To view, visit http://gerrit.cloudera.org:8080/8863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida198b96e76102f82d0b32116c45e41d26d15314
Gerrit-Change-Number: 8863
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-1097: try adding a new replica when majority is on-line
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8863 )
Change subject: KUDU-1097: try adding a new replica when majority is on-line
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida198b96e76102f82d0b32116c45e41d26d15314
Gerrit-Change-Number: 8863
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 23 Dec 2017 18:30:18 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1097: try adding a new replica when majority is on-line
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8863 )
Change subject: KUDU-1097: try adding a new replica when majority is on-line
......................................................................
Patch Set 2: Code-Review+1
(4 comments)
looks good, I just have nit feedback
http://gerrit.cloudera.org:8080/#/c/8863/2/src/kudu/consensus/quorum_util-test.cc
File src/kudu/consensus/quorum_util-test.cc:
http://gerrit.cloudera.org:8080/#/c/8863/2/src/kudu/consensus/quorum_util-test.cc@286
PS2, Line 286: is not
nit: are not (here and below)
http://gerrit.cloudera.org:8080/#/c/8863/2/src/kudu/consensus/quorum_util-test.cc@287
PS2, Line 287:
nit: the (here and below)
http://gerrit.cloudera.org:8080/#/c/8863/2/src/kudu/consensus/quorum_util-test.cc@796
PS2, Line 796:
nit: a
http://gerrit.cloudera.org:8080/#/c/8863/2/src/kudu/consensus/quorum_util-test.cc@797
PS2, Line 797: Voter
nit: Voters
--
To view, visit http://gerrit.cloudera.org:8080/8863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida198b96e76102f82d0b32116c45e41d26d15314
Gerrit-Change-Number: 8863
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 22 Dec 2017 21:01:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1097: try adding a new replica when majority is on-line
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8863 )
Change subject: KUDU-1097: try adding a new replica when majority is on-line
......................................................................
KUDU-1097: try adding a new replica when majority is on-line
With this patch, the consensus::ShouldAddReplica() utility function
checks whether a majority of voter replicas is on-line before attempting
to add a new non-voter replica into the tablet Raft configuration. This
makes it more consistent with the behavior of the 'symmetric'
consensus::ShouldEvictReplica() function.
Change-Id: Ida198b96e76102f82d0b32116c45e41d26d15314
Reviewed-on: http://gerrit.cloudera.org:8080/8863
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/consensus/quorum_util-test.cc
M src/kudu/consensus/quorum_util.cc
2 files changed, 67 insertions(+), 20 deletions(-)
Approvals:
Kudu Jenkins: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida198b96e76102f82d0b32116c45e41d26d15314
Gerrit-Change-Number: 8863
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-1097: try adding a new replica when majority is on-line
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8863 )
Change subject: KUDU-1097: try adding a new replica when majority is on-line
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/8863/2/src/kudu/consensus/quorum_util-test.cc
File src/kudu/consensus/quorum_util-test.cc:
http://gerrit.cloudera.org:8080/#/c/8863/2/src/kudu/consensus/quorum_util-test.cc@286
PS2, Line 286: are no
> nit: are not (here and below)
Done
http://gerrit.cloudera.org:8080/#/c/8863/2/src/kudu/consensus/quorum_util-test.cc@287
PS2, Line 287:
> nit: the (here and below)
Done
http://gerrit.cloudera.org:8080/#/c/8863/2/src/kudu/consensus/quorum_util-test.cc@796
PS2, Line 796:
> nit: a
Done
http://gerrit.cloudera.org:8080/#/c/8863/2/src/kudu/consensus/quorum_util-test.cc@797
PS2, Line 797: Voter
> nit: Voters
Done
--
To view, visit http://gerrit.cloudera.org:8080/8863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida198b96e76102f82d0b32116c45e41d26d15314
Gerrit-Change-Number: 8863
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 23 Dec 2017 01:16:45 +0000
Gerrit-HasComments: Yes