You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/06/09 20:34:24 UTC
[GitHub] flink pull request #4099: [FLINK-6882] [runtime] Activate checkstyle for run...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4099
[FLINK-6882] [runtime] Activate checkstyle for runtime/registration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 6882_activate_checkstyle_for_runtime_registration
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4099.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4099
----
commit 9845563eee246da20f0e7d06f8caadd18d7f4165
Author: Greg Hogan <co...@greghogan.com>
Date: 2017-06-09T20:32:46Z
[FLINK-6882] [runtime] Activate checkstyle for runtime/registration
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4099: [FLINK-6882] [runtime] Activate checkstyle for runtime/re...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4099
I wasn't quite sure about this one; I had a chat with @tillrohrmann and he suggested to bec areful in this package. But the changes aren't that substantial, so I would say +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4099: [FLINK-6882] [runtime] Activate checkstyle for run...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4099
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4099: [FLINK-6882] [runtime] Activate checkstyle for runtime/re...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4099
@zentol not sure if this was overlooked. I have rebased to master, is there anyone you think we should check with before including this package?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---