You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/28 20:27:59 UTC
[kudu-CR] Revert "KUDU-1448. Enable AVX2 bitshuffle at runtime"
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5245
Change subject: Revert "KUDU-1448. Enable AVX2 bitshuffle at runtime"
......................................................................
Revert "KUDU-1448. Enable AVX2 bitshuffle at runtime"
This is causing ASAN and TSAN tests to fail on el6 likely due to this ld.so bug:
https://patchwork.ozlabs.org/patch/506223/
This reverts commit f10ab4a1d7ac0735890dcab6685a9fba7edac74e.
Change-Id: I86f6cc93f1e44f8d7243b742532901fd95bd1264
---
M src/kudu/cfile/CMakeLists.txt
D src/kudu/cfile/bitshuffle_arch_wrapper.cc
D src/kudu/cfile/bitshuffle_arch_wrapper.h
M src/kudu/cfile/bshuf_block.cc
M src/kudu/cfile/bshuf_block.h
M src/kudu/gutil/cpu.cc
M thirdparty/build-definitions.sh
7 files changed, 12 insertions(+), 178 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/5245/1
--
To view, visit http://gerrit.cloudera.org:8080/5245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I86f6cc93f1e44f8d7243b742532901fd95bd1264
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
[kudu-CR] Revert "KUDU-1448. Enable AVX2 bitshuffle at runtime"
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Revert "KUDU-1448. Enable AVX2 bitshuffle at runtime"
......................................................................
Revert "KUDU-1448. Enable AVX2 bitshuffle at runtime"
This is causing ASAN and TSAN tests to fail on el6 likely due to this ld.so bug:
https://patchwork.ozlabs.org/patch/506223/
This reverts commit f10ab4a1d7ac0735890dcab6685a9fba7edac74e.
Change-Id: I86f6cc93f1e44f8d7243b742532901fd95bd1264
Reviewed-on: http://gerrit.cloudera.org:8080/5245
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/cfile/CMakeLists.txt
D src/kudu/cfile/bitshuffle_arch_wrapper.cc
D src/kudu/cfile/bitshuffle_arch_wrapper.h
M src/kudu/cfile/bshuf_block.cc
M src/kudu/cfile/bshuf_block.h
M src/kudu/gutil/cpu.cc
M thirdparty/build-definitions.sh
7 files changed, 12 insertions(+), 178 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I86f6cc93f1e44f8d7243b742532901fd95bd1264
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Revert "KUDU-1448. Enable AVX2 bitshuffle at runtime"
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has reverted this change.
Change subject: Revert "KUDU-1448. Enable AVX2 bitshuffle at runtime"
......................................................................
Uploaded patch set 1.
--
To view, visit http://gerrit.cloudera.org:8080/5245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: revert
Gerrit-Change-Id: I86f6cc93f1e44f8d7243b742532901fd95bd1264
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
[kudu-CR] Revert "KUDU-1448. Enable AVX2 bitshuffle at runtime"
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Revert "KUDU-1448. Enable AVX2 bitshuffle at runtime"
......................................................................
Patch Set 2: Code-Review+2
Carrying Alexey's +2
--
To view, visit http://gerrit.cloudera.org:8080/5245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I86f6cc93f1e44f8d7243b742532901fd95bd1264
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Revert "KUDU-1448. Enable AVX2 bitshuffle at runtime"
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5245
to look at the new patch set (#2).
Change subject: Revert "KUDU-1448. Enable AVX2 bitshuffle at runtime"
......................................................................
Revert "KUDU-1448. Enable AVX2 bitshuffle at runtime"
This is causing ASAN and TSAN tests to fail on el6 likely due to this ld.so bug:
https://patchwork.ozlabs.org/patch/506223/
This reverts commit f10ab4a1d7ac0735890dcab6685a9fba7edac74e.
Change-Id: I86f6cc93f1e44f8d7243b742532901fd95bd1264
---
M src/kudu/cfile/CMakeLists.txt
D src/kudu/cfile/bitshuffle_arch_wrapper.cc
D src/kudu/cfile/bitshuffle_arch_wrapper.h
M src/kudu/cfile/bshuf_block.cc
M src/kudu/cfile/bshuf_block.h
M src/kudu/gutil/cpu.cc
M thirdparty/build-definitions.sh
7 files changed, 12 insertions(+), 178 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/5245/2
--
To view, visit http://gerrit.cloudera.org:8080/5245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I86f6cc93f1e44f8d7243b742532901fd95bd1264
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] Revert "KUDU-1448. Enable AVX2 bitshuffle at runtime"
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Revert "KUDU-1448. Enable AVX2 bitshuffle at runtime"
......................................................................
Patch Set 1: Code-Review+2
btw, the problem also manifests itself with just debug builds at ve0518.halxg.cloudera.com
--
To view, visit http://gerrit.cloudera.org:8080/5245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I86f6cc93f1e44f8d7243b742532901fd95bd1264
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No