[GitHub] [airflow] ashwiniadiga opened a new pull request #4583: [AIRFLOW-3746] Fix to prevent missing container exit

[GitBox <gi...@apache.org>]

ashwiniadiga opened a new pull request #4583: [AIRFLOW-3746] Fix to prevent missing container exit
URL: https://github.com/apache/airflow/pull/4583
 
 
   My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-3746)
   
   switch from cli.logs to cli.attach to prevent missing container exit
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [(https://issues.apache.org/jira/browse/AIRFLOW-3746)] 
     - https://issues.apache.org/jira/browse/AIRFLOW-3746
   
   
   ### Description
   
   - My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) 
   switch from cli.logs to cli.attach to prevent missing container exit
   With DockerOperator and using the celery executor, the task runs but never completes. It hungs as 
   container.logs / certain container hangs.
   
   since The contianer.logs() function is a wrapper around container .attach() method, which you can use instead if you want to fetch/stream container output without first retrieving the entire backlog.
   So changing the container.logs() to container.attach() gives the same output and completes the task.
   with the following log.
   The docker_operator Task exited with return code 0
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:All the existing tests are fixed. No new tests are not required.
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services