You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/12 07:00:06 UTC
[GitHub] [spark] ulysses-you opened a new pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
ulysses-you opened a new pull request #28808:
URL: https://github.com/apache/spark/pull/28808
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add WindowFunction check at `CheckAnalysis`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Provide friendly error msg.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, user wiill be given a better error msg.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Add UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643290815
**[Test build #123932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123932/testReport)** for PR 28808 at commit [`cd8bbb2`](https://github.com/apache/spark/commit/cd8bbb258049dc3f0c8f03edd8889e90db5e8d99).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643546733
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654010108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654055714
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654031798
Thank you @dongjoon-hyun , thanks for help test @HyukjinKwon .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654650704
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643153484
**[Test build #123913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123913/testReport)** for PR 28808 at commit [`f283385`](https://github.com/apache/spark/commit/f283385d92581a694152a08280d93a55b8bb06ae).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654586842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654649989
**[Test build #125185 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125185/testReport)** for PR 28808 at commit [`3e116f5`](https://github.com/apache/spark/commit/3e116f5f3284b22eec712990d271751b799f4ece).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643153484
**[Test build #123913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123913/testReport)** for PR 28808 at commit [`f283385`](https://github.com/apache/spark/commit/f283385d92581a694152a08280d93a55b8bb06ae).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654010108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #28808:
URL: https://github.com/apache/spark/pull/28808#discussion_r449028610
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -158,6 +158,9 @@ trait CheckAnalysis extends PredicateHelper {
case g: GroupingID =>
failAnalysis("grouping_id() can only be used with GroupingSets/Cube/Rollup")
+ case Alias(w: WindowFunction, _) =>
+ failAnalysis(s"Window function $w call requires an OVER clause.")
Review comment:
removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654586566
**[Test build #125175 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125175/testReport)** for PR 28808 at commit [`3e116f5`](https://github.com/apache/spark/commit/3e116f5f3284b22eec712990d271751b799f4ece).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643370275
**[Test build #123921 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123921/testReport)** for PR 28808 at commit [`38df40a`](https://github.com/apache/spark/commit/38df40a94b2b4a5940ca38a6d2e929e74042147a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643546611
**[Test build #123951 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123951/testReport)** for PR 28808 at commit [`335935f`](https://github.com/apache/spark/commit/335935fc2a226b6b64610eb3f095be99b7ff49e0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643452089
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654586842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-653183074
**[Test build #124911 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124911/testReport)** for PR 28808 at commit [`972ae13`](https://github.com/apache/spark/commit/972ae13e2c8571c1d0f26c7e46c9fed9a87c2dcb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #28808:
URL: https://github.com/apache/spark/pull/28808#discussion_r439337319
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -158,6 +158,9 @@ trait CheckAnalysis extends PredicateHelper {
case g: GroupingID =>
failAnalysis("grouping_id() can only be used with GroupingSets/Cube/Rollup")
+ case Alias(w: WindowFunction, _) =>
+ failAnalysis(s"Expression '$w' not supported without a window function.")
Review comment:
How about `Window function '$w' call requires an OVER clause`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654867130
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654007425
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654208965
**[Test build #125082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125082/testReport)** for PR 28808 at commit [`3e116f5`](https://github.com/apache/spark/commit/3e116f5f3284b22eec712990d271751b799f4ece).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654204222
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125064/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643195884
**[Test build #123921 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123921/testReport)** for PR 28808 at commit [`38df40a`](https://github.com/apache/spark/commit/38df40a94b2b4a5940ca38a6d2e929e74042147a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-655200059
thanks for merging! thanks all!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #28808:
URL: https://github.com/apache/spark/pull/28808#discussion_r449323226
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -158,6 +158,9 @@ trait CheckAnalysis extends PredicateHelper {
case g: GroupingID =>
failAnalysis("grouping_id() can only be used with GroupingSets/Cube/Rollup")
+ case Alias(w: WindowFunction, _) =>
Review comment:
The right way is `Alias(WindowExpression(w: WindowFunction, _), _)` and without `over` it is `Alias(w: WindowFunction, _)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654009435
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654156954
**[Test build #125064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125064/testReport)** for PR 28808 at commit [`3e116f5`](https://github.com/apache/spark/commit/3e116f5f3284b22eec712990d271751b799f4ece).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654207956
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654204084
**[Test build #125064 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125064/testReport)** for PR 28808 at commit [`3e116f5`](https://github.com/apache/spark/commit/3e116f5f3284b22eec712990d271751b799f4ece).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654208965
**[Test build #125082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125082/testReport)** for PR 28808 at commit [`3e116f5`](https://github.com/apache/spark/commit/3e116f5f3284b22eec712990d271751b799f4ece).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643581694
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643121480
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-653932444
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654156954
**[Test build #125064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125064/testReport)** for PR 28808 at commit [`3e116f5`](https://github.com/apache/spark/commit/3e116f5f3284b22eec712990d271751b799f4ece).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643121390
**[Test build #123895 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123895/testReport)** for PR 28808 at commit [`f283385`](https://github.com/apache/spark/commit/f283385d92581a694152a08280d93a55b8bb06ae).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654644685
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125175/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654209613
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654221607
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643196646
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654204211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654009976
**[Test build #125024 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125024/testReport)** for PR 28808 at commit [`3e116f5`](https://github.com/apache/spark/commit/3e116f5f3284b22eec712990d271751b799f4ece).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654054385
**[Test build #125024 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125024/testReport)** for PR 28808 at commit [`3e116f5`](https://github.com/apache/spark/commit/3e116f5f3284b22eec712990d271751b799f4ece).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654221405
**[Test build #125082 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125082/testReport)** for PR 28808 at commit [`3e116f5`](https://github.com/apache/spark/commit/3e116f5f3284b22eec712990d271751b799f4ece).
* This patch **fails to generate documentation**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643196646
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643546611
**[Test build #123951 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123951/testReport)** for PR 28808 at commit [`335935f`](https://github.com/apache/spark/commit/335935fc2a226b6b64610eb3f095be99b7ff49e0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643371453
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643291333
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643153905
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654860364
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654585361
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654055726
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125024/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654055714
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643546733
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643195884
**[Test build #123921 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123921/testReport)** for PR 28808 at commit [`38df40a`](https://github.com/apache/spark/commit/38df40a94b2b4a5940ca38a6d2e929e74042147a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643169945
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123913/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654204211
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-646462302
cc @jiangxb1987
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643291333
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28808:
URL: https://github.com/apache/spark/pull/28808#discussion_r449551076
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
##########
@@ -884,4 +884,15 @@ class AnalysisSuite extends AnalysisTest with Matchers {
Seq("Intersect can only be performed on tables with the compatible column types. " +
"timestamp <> double at the second column of the second table"))
}
+
+ test("throw user facing error when use WindowFunction directly") {
Review comment:
Shall we add a JIRA prefix here? `SPARK-31975: ...`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-653506469
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28808:
URL: https://github.com/apache/spark/pull/28808#discussion_r449007638
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -158,6 +158,9 @@ trait CheckAnalysis extends PredicateHelper {
case g: GroupingID =>
failAnalysis("grouping_id() can only be used with GroupingSets/Cube/Rollup")
+ case Alias(w: WindowFunction, _) =>
+ failAnalysis(s"Window function $w call requires an OVER clause.")
Review comment:
nit: we can remove `call`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-653931957
**[Test build #124949 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124949/testReport)** for PR 28808 at commit [`3e116f5`](https://github.com/apache/spark/commit/3e116f5f3284b22eec712990d271751b799f4ece).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643152197
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643105384
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643581499
**[Test build #123951 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123951/testReport)** for PR 28808 at commit [`335935f`](https://github.com/apache/spark/commit/335935fc2a226b6b64610eb3f095be99b7ff49e0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28808:
URL: https://github.com/apache/spark/pull/28808#discussion_r449056520
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -158,6 +158,9 @@ trait CheckAnalysis extends PredicateHelper {
case g: GroupingID =>
failAnalysis("grouping_id() can only be used with GroupingSets/Cube/Rollup")
+ case Alias(w: WindowFunction, _) =>
Review comment:
BTW why do we have to match the `Alias`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654157398
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643169938
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643169938
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654860364
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-651129175
also cc @HyukjinKwon @cloud-fan a minor change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643581694
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654857834
**[Test build #125185 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125185/testReport)** for PR 28808 at commit [`3e116f5`](https://github.com/apache/spark/commit/3e116f5f3284b22eec712990d271751b799f4ece).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643290815
**[Test build #123932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123932/testReport)** for PR 28808 at commit [`cd8bbb2`](https://github.com/apache/spark/commit/cd8bbb258049dc3f0c8f03edd8889e90db5e8d99).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643105384
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #28808:
URL: https://github.com/apache/spark/pull/28808#discussion_r439481450
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -158,6 +158,9 @@ trait CheckAnalysis extends PredicateHelper {
case g: GroupingID =>
failAnalysis("grouping_id() can only be used with GroupingSets/Cube/Rollup")
+ case Alias(w: WindowFunction, _) =>
+ failAnalysis(s"Window function '$w' call requires an OVER clause.")
Review comment:
Sorry, seems we need to remove single quotation marks:
https://github.com/apache/spark/blob/b2011a295bd78b3693a516e049e90250366b8f52/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L2734
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654644675
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643371453
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654157398
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643153905
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654221607
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654007432
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124949/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654209613
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654007425
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654648794
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654221616
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125082/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643121480
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-653027954
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-653027954
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643104851
**[Test build #123895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123895/testReport)** for PR 28808 at commit [`f283385`](https://github.com/apache/spark/commit/f283385d92581a694152a08280d93a55b8bb06ae).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643451012
**[Test build #123932 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123932/testReport)** for PR 28808 at commit [`cd8bbb2`](https://github.com/apache/spark/commit/cd8bbb258049dc3f0c8f03edd8889e90db5e8d99).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28808:
URL: https://github.com/apache/spark/pull/28808#discussion_r449714381
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -158,6 +158,11 @@ trait CheckAnalysis extends PredicateHelper {
case g: GroupingID =>
failAnalysis("grouping_id() can only be used with GroupingSets/Cube/Rollup")
+ case e: Expression if e.children.exists(_.isInstanceOf[WindowFunction]) &&
+ !e.isInstanceOf[WindowExpression] =>
Review comment:
nit: indent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654650704
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654154549
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654644675
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-653031983
**[Test build #124911 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124911/testReport)** for PR 28808 at commit [`972ae13`](https://github.com/apache/spark/commit/972ae13e2c8571c1d0f26c7e46c9fed9a87c2dcb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643104851
**[Test build #123895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123895/testReport)** for PR 28808 at commit [`f283385`](https://github.com/apache/spark/commit/f283385d92581a694152a08280d93a55b8bb06ae).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643121491
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123895/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654586566
**[Test build #125175 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125175/testReport)** for PR 28808 at commit [`3e116f5`](https://github.com/apache/spark/commit/3e116f5f3284b22eec712990d271751b799f4ece).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-653932444
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-653184350
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654009976
**[Test build #125024 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125024/testReport)** for PR 28808 at commit [`3e116f5`](https://github.com/apache/spark/commit/3e116f5f3284b22eec712990d271751b799f4ece).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643169852
**[Test build #123913 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123913/testReport)** for PR 28808 at commit [`f283385`](https://github.com/apache/spark/commit/f283385d92581a694152a08280d93a55b8bb06ae).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #28808:
URL: https://github.com/apache/spark/pull/28808#discussion_r439337319
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -158,6 +158,9 @@ trait CheckAnalysis extends PredicateHelper {
case g: GroupingID =>
failAnalysis("grouping_id() can only be used with GroupingSets/Cube/Rollup")
+ case Alias(w: WindowFunction, _) =>
+ failAnalysis(s"Expression '$w' not supported without a window function.")
Review comment:
How about `window function call requires an OVER clause`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28808:
URL: https://github.com/apache/spark/pull/28808
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654649989
**[Test build #125185 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125185/testReport)** for PR 28808 at commit [`3e116f5`](https://github.com/apache/spark/commit/3e116f5f3284b22eec712990d271751b799f4ece).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-643452089
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-654644091
**[Test build #125175 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125175/testReport)** for PR 28808 at commit [`3e116f5`](https://github.com/apache/spark/commit/3e116f5f3284b22eec712990d271751b799f4ece).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28808:
URL: https://github.com/apache/spark/pull/28808#discussion_r449454344
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -158,6 +158,9 @@ trait CheckAnalysis extends PredicateHelper {
case g: GroupingID =>
failAnalysis("grouping_id() can only be used with GroupingSets/Cube/Rollup")
+ case Alias(w: WindowFunction, _) =>
Review comment:
then the check doesn't work for cases like `rank() + 1`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-653031983
**[Test build #124911 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124911/testReport)** for PR 28808 at commit [`972ae13`](https://github.com/apache/spark/commit/972ae13e2c8571c1d0f26c7e46c9fed9a87c2dcb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #28808:
URL: https://github.com/apache/spark/pull/28808#discussion_r449516560
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -158,6 +158,9 @@ trait CheckAnalysis extends PredicateHelper {
case g: GroupingID =>
failAnalysis("grouping_id() can only be used with GroupingSets/Cube/Rollup")
+ case Alias(w: WindowFunction, _) =>
Review comment:
good catch ! we need to check all expression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28808: [SPARK-31975][SQL] Throw user facing error when use WindowFunction directly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28808:
URL: https://github.com/apache/spark/pull/28808#issuecomment-653184350
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org