You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/04/06 05:43:19 UTC
Review Request 45799: Cleaned up the virtual overloads in long lived
framework.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45799/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-4982
https://issues.apache.org/jira/browse/MESOS-4982
Repository: mesos
Description
-------
This change removes the unused methods that won't be needed
after moving to the v1 API. This review mainly eases reviewing
later in the chain and should not be committed on its own.
Diffs
-----
src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0
Diff: https://reviews.apache.org/r/45799/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 45799: Cleaned up the virtual overloads in long
lived framework.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45799/#review127663
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 6, 2016, 3:43 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45799/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 3:43 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change removes the unused methods that won't be needed
> after moving to the v1 API. This review mainly eases reviewing
> later in the chain and should not be committed on its own.
>
>
> Diffs
> -----
>
> src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0
>
> Diff: https://reviews.apache.org/r/45799/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 45799: Cleaned up the virtual overloads in long
lived framework.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45799/
-----------------------------------------------------------
(Updated April 7, 2016, 9:24 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Rebased
Bugs: MESOS-4982
https://issues.apache.org/jira/browse/MESOS-4982
Repository: mesos
Description
-------
This change removes the unused methods that won't be needed
after moving to the v1 API. This review mainly eases reviewing
later in the chain and should not be committed on its own.
Diffs (updated)
-----
src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0
Diff: https://reviews.apache.org/r/45799/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar