You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by tedxia <gi...@git.apache.org> on 2015/06/26 09:27:27 UTC
[GitHub] storm pull request: STORM-914: AutoHDFS should also update hdfs.co...
GitHub user tedxia opened a pull request:
https://github.com/apache/storm/pull/606
STORM-914: AutoHDFS should also update hdfs.config into Configuration
PR for [STORM-914](https://issues.apache.org/jira/browse/STORM-914)
When storm user a specify hdfs cluster, he will put some config such as namenode.host into hdfs.config when submit storm topology, and when HdfsBolt create HdfsConfiguration, it will use hdfs.config update HDFSConfiguration, then HDFSBolt will visit the right hdfs cluster. But in AutoHDFS's renew and getHadoopCredentials, Configuration not for the HDFS that storm user specify, we should update all the Configuration with hdfs.config.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tedxia/storm ted-AutoHDFS-should-load-hdfs.config-to-Configure
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/606.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #606
----
commit 9461f66785fec958f66bc7db6ae9b5acf52e8eb9
Author: xiajun <xi...@xiaomi.com>
Date: 2015-06-26T07:25:39Z
STORM-914: AutoHDFS should also update hdfs.config into Configuration
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-914: AutoHDFS should also update hdfs.co...
Posted by tedxia <gi...@git.apache.org>.
Github user tedxia commented on a diff in the pull request:
https://github.com/apache/storm/pull/606#discussion_r35410221
--- Diff: external/storm-hdfs/src/test/java/org/apache/storm/hdfs/trident/TridentSequenceTopology.java ---
@@ -60,7 +61,7 @@ public static StormTopology buildTopology(String hdfsUrl){
.withSequenceFormat(new DefaultSequenceFormat("key", "sentence"))
.withRotationPolicy(rotationPolicy)
.withFsUrl(hdfsUrl)
- .withConfigKey("hdfs.config")
--- End diff --
yes，I think we should change to hdfs.config for this reason, I will add a patch later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-914: AutoHDFS should also update hdfs.co...
Posted by caofangkun <gi...@git.apache.org>.
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/606#discussion_r35409819
--- Diff: external/storm-hdfs/src/test/java/org/apache/storm/hdfs/trident/TridentSequenceTopology.java ---
@@ -60,7 +61,7 @@ public static StormTopology buildTopology(String hdfsUrl){
.withSequenceFormat(new DefaultSequenceFormat("key", "sentence"))
.withRotationPolicy(rotationPolicy)
.withFsUrl(hdfsUrl)
- .withConfigKey("hdfs.config")
--- End diff --
@tedxia
if you change ```hdfs.config``` to ```topology.hdfs.config```
should the following several files change too ?
[HdfsFileTopology.java](https://github.com/apache/storm/blob/master/external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/HdfsFileTopology.java#L82)
[simple_hdfs.yaml](https://github.com/apache/storm/blob/master/external/flux/flux-examples/src/main/resources/simple_hdfs.yaml#L74)
[hdfs_test.yaml](https://github.com/apache/storm/blob/master/external/flux/flux-core/src/test/resources/configs/hdfs_test.yaml#L82)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #606: STORM-914: AutoHDFS should also update hdfs.config into Co...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the issue:
https://github.com/apache/storm/pull/606
@tedxia This PR is rather stale. Is it still being worked or should we close it?
---
[GitHub] storm pull request: STORM-914: AutoHDFS should also update hdfs.co...
Posted by tedxia <gi...@git.apache.org>.
Github user tedxia commented on the pull request:
https://github.com/apache/storm/pull/606#issuecomment-119865764
@revans2 Will you take a look at this, thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---