You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/25 06:46:25 UTC
[GitHub] [incubator-nuttx] no1wudi opened a new pull request #3174: arch/arm: Use macro defined swi range in dispatch_syscall
no1wudi opened a new pull request #3174:
URL: https://github.com/apache/incubator-nuttx/pull/3174
## Summary
See title
## Impact
All arm based chips with libsyscall enabled
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3174: arch/arm: Use macro defined swi range in dispatch_syscall
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3174:
URL: https://github.com/apache/incubator-nuttx/pull/3174#issuecomment-806653421
> The Testing is empty, all PR need to be tested, at least for someone who created it.
SWI require the argument is immediate number. If the change pass the argument through register(the common case), the assembler will complain SWI doesn't support this instruction variant.
BTW, the change can be verified by disassemble the code and compare the result before and after change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3174: arch/arm: Use macro defined swi range in dispatch_syscall
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3174:
URL: https://github.com/apache/incubator-nuttx/pull/3174#issuecomment-806567516
The Testing is empty, all PR need to be tested, at least for someone who created it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3174: arch/arm: Use macro defined swi range in dispatch_syscall
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3174:
URL: https://github.com/apache/incubator-nuttx/pull/3174#issuecomment-808177134
Yes, I think so if @acassis don't have more concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 merged pull request #3174: arch/arm: Use macro defined swi range in dispatch_syscall
Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #3174:
URL: https://github.com/apache/incubator-nuttx/pull/3174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis edited a comment on pull request #3174: arch/arm: Use macro defined swi range in dispatch_syscall
Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #3174:
URL: https://github.com/apache/incubator-nuttx/pull/3174#issuecomment-806566328
@no1wudi did you test this modification running the Zero Latency / High Performance to confirm nothing is broken?
https://cwiki.apache.org/confluence/display/NUTTX/High+Performance%2C+Zero+Latency+Interrupts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3174: arch/arm: Use macro defined swi range in dispatch_syscall
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3174:
URL: https://github.com/apache/incubator-nuttx/pull/3174#issuecomment-807912793
@acassis do you think is it enough now with the new background info?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3174: arch/arm: Use macro defined swi range in dispatch_syscall
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3174:
URL: https://github.com/apache/incubator-nuttx/pull/3174#issuecomment-808173137
Ahh Right it says it is a follow on, I guess
>BTW, the change can be verified by disassemble the code and compare the result before and after change.
threw me
Ok well then - shall we merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3174: arch/arm: Use macro defined swi range in dispatch_syscall
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3174:
URL: https://github.com/apache/incubator-nuttx/pull/3174#issuecomment-806570803
%0 is replaced by the immediate value of SYS_syscall (You have got to love the input/output syntax)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3174: arch/arm: Use macro defined swi range in dispatch_syscall
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3174:
URL: https://github.com/apache/incubator-nuttx/pull/3174#issuecomment-806566328
@no1wudi did you test this modification running the Zero Latency / High Performance to confirm nothing is broken?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3174: arch/arm: Use macro defined swi range in dispatch_syscall
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3174:
URL: https://github.com/apache/incubator-nuttx/pull/3174#issuecomment-808162114
Yes, as the summary mentioned, this patch is a continued work of #3075. The root cause of mismatch is the original code directly hardcode SWI number in the inline assembly. This patch fix the bug and remove the hardcode value to avoid the potential mismatch in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3174: arch/arm: Use macro defined swi range in dispatch_syscall
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3174:
URL: https://github.com/apache/incubator-nuttx/pull/3174#issuecomment-806569156
@acassis - it is compile time syntactical sugar. Using the #define not the constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3174: arch/arm: Use macro defined swi range in dispatch_syscall
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3174:
URL: https://github.com/apache/incubator-nuttx/pull/3174#issuecomment-808099953
@xiaoxiang781216 - I think it prudent to do the disasm check or inspection. When I did the inspection I found they do not match.
They do not match because the values were changed here https://github.com/apache/incubator-nuttx/commit/335ba2165729bf3f737d79f15ad5877c15e95b64
platforms/nuttx/NuttX/nuttx/arch/arm/include/armv7-a/syscall.h:#define SYS_syscall 0x00
So how should we vet this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org