[GitHub] [arrow-site] nealrichardson commented on a diff in pull request #306: [Website] Committer expectations and process

["nealrichardson (via GitHub)" <gi...@apache.org>]

nealrichardson commented on code in PR #306:
URL: https://github.com/apache/arrow-site/pull/306#discussion_r1091074564


##########
committers.md:
##########
@@ -63,12 +63,12 @@ on important decisions, including releases and inviting committers to join the P
 
 ### Committers
 
-Contributors who have demonstrated a sustained commitment to the project, not
-only authoring code but also reviewing others' patches and exercising good
-judgment, may be invited by the PMC to become
+Contributors who have demonstrated a sustained commitment to the
+project, may be invited by the PMC to become

Review Comment:
   ```suggestion
   project may be invited by the PMC to become
   ```



##########
committers.md:
##########
@@ -86,3 +86,45 @@ non-voting project maintainers.
     {% endif %}
   {% endfor %}
 </tbody></table>
+
+### **Becoming a committer**
+
+As described elsewhere, there are many ways we welcome you to
+contribute the Apache Arrow project such as issue reports,

Review Comment:
   ```suggestion
   There are many ways to [contribute](https://arrow.apache.org/docs/developers/contributing.html)
   to the Apache Arrow project, including issue reports,
   ```



##########
committers.md:
##########
@@ -86,3 +86,45 @@ non-voting project maintainers.
     {% endif %}
   {% endfor %}
 </tbody></table>
+
+### **Becoming a committer**
+
+As described elsewhere, there are many ways we welcome you to
+contribute the Apache Arrow project such as issue reports,
+documentation, tests, and code. Some particularly active contributors
+may also receive an invitation to become a committer.
+
+The PMC regularly adds new committers from the set of active
+contributors. Becoming a committer is a recognition of sustained

Review Comment:
   ```suggestion
   Becoming a committer is a recognition of sustained
   ```



##########
committers.md:
##########
@@ -86,3 +86,45 @@ non-voting project maintainers.
     {% endif %}
   {% endfor %}
 </tbody></table>
+
+### **Becoming a committer**
+
+As described elsewhere, there are many ways we welcome you to
+contribute the Apache Arrow project such as issue reports,
+documentation, tests, and code. Some particularly active contributors
+may also receive an invitation to become a committer.
+
+The PMC regularly adds new committers from the set of active
+contributors. Becoming a committer is a recognition of sustained
+contribution to the project, and comes with the privilege of
+committing changes directly in all Arrow github repositories. Becoming
+a committer is also a significant responsibility, and committers are
+expected to use their status and access to improve the Arrow project
+for the entire community.
+
+Anyone wishing to become a committer can already do all of the things a

Review Comment:
   I feel like this is missing an intro sentence, maybe something like this?
   
   ```suggestion
   When considering to invite someone to be a committer, the PMC looks for 
   contributors who are doing the work and exercising the judgment expected
   of a committer. After all, any contributor can already do all of the things a
   ```



##########
committers.md:
##########
@@ -86,3 +86,45 @@ non-voting project maintainers.
     {% endif %}
   {% endfor %}
 </tbody></table>
+
+### **Becoming a committer**
+
+As described elsewhere, there are many ways we welcome you to
+contribute the Apache Arrow project such as issue reports,
+documentation, tests, and code. Some particularly active contributors
+may also receive an invitation to become a committer.
+
+The PMC regularly adds new committers from the set of active
+contributors. Becoming a committer is a recognition of sustained
+contribution to the project, and comes with the privilege of
+committing changes directly in all Arrow github repositories. Becoming
+a committer is also a significant responsibility, and committers are
+expected to use their status and access to improve the Arrow project
+for the entire community.
+
+Anyone wishing to become a committer can already do all of the things a
+committer does except for merge a PR. While there is no set list of
+requirements, nor a checklist that entitles one to commit privileges,
+typical behaviors include:
+
+* Consistent, significant, and sustained involvement in the Arrow

Review Comment:
   Should "involvement" be expanded on? I think we want to be clear that tossing up a bunch of PRs but not otherwise engaging with others' work isn't sufficient, that the significance of the code contributed is not irrelevant but not the top concern.



##########
committers.md:
##########
@@ -86,3 +86,45 @@ non-voting project maintainers.
     {% endif %}
   {% endfor %}
 </tbody></table>
+
+### **Becoming a committer**
+
+As described elsewhere, there are many ways we welcome you to
+contribute the Apache Arrow project such as issue reports,
+documentation, tests, and code. Some particularly active contributors
+may also receive an invitation to become a committer.

Review Comment:
   ```suggestion
   documentation, tests, and code. Contributors with sustained, high-quality activity
   may be invited to become a committer by the PMC.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org