You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/04/11 05:18:03 UTC

[GitHub] [dubbo-go-pixiu] AlexStocks commented on a diff in pull request #393: [WIP] LDS

AlexStocks commented on code in PR #393:
URL: https://github.com/apache/dubbo-go-pixiu/pull/393#discussion_r846953362


##########
pkg/config/xds/apiclient/grpc.go:
##########
@@ -19,6 +19,8 @@ package apiclient
 
 import (
 	"context"
+	errors2 "errors"

Review Comment:
   不建议这么改动 go 原生的 package name。不行了你使用 “perrors \"github.com/pkg/errors\"”



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org