[GitHub] [lucene] gsmiller commented on pull request #12089: Modify TermInSetQuery to "self optimize" if doc values are available

["gsmiller (via GitHub)" <gi...@apache.org>]

gsmiller commented on PR #12089:
URL: https://github.com/apache/lucene/pull/12089#issuecomment-1416767759

   @rmuir I modified the PR to update the existing `TermInSetQuery` in-place, instead of introducing a new sandbox concept. I've added some test coverage and re-ran all the benchmarks. The updated benchmark code is here: [TiSBench.java.txt](https://github.com/apache/lucene/files/10608857/TiSBench.java.txt). The results are here: 
   [TiSBenchResults.md.txt](https://github.com/apache/lucene/files/10608858/TiSBenchResults.md.txt).
   
   I think this is ready for a more thorough review now if you (or anyone else) has the time. My plan is to reference this query directly from something like `KeywordField#newSetQuery` after #12054 is merged (or could be part of that PR). Based on the benchmarks, I wouldn't expect this change to cause any significant regressions to existing `TermInSetQuery` users, and it looks more promising than trying to leverage `IndexOrDocValues`. I'm sure there's room to tweak/improve it further, but my hope is to get something initial merged and then iterate as it makes sense. Thanks for your feedback so far!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org