You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by Parth Chandra <pc...@maprtech.com> on 2015/02/06 07:25:58 UTC

Review Request 30714: DRILL-1872: Assertion failure and empty map on order by with complex data

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30714/
-----------------------------------------------------------

Review request for drill and Mehant Baid.


Repository: drill-git


Description
-------

Caused by MaterializedField hashCode and equals being evaluated before all the children at sublevels have been added. Changed the methods to use only MaterializedField$Key which is invariant even when children are added


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/record/MaterializedField.java a9f3292 

Diff: https://reviews.apache.org/r/30714/diff/


Testing
-------

All unit tests and regression tests.


Thanks,

Parth Chandra