You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/08/11 16:51:13 UTC

[GitHub] [buildstream-plugins] gtristan commented on pull request #25: Enable setting build-dir

gtristan commented on PR #25:
URL: https://github.com/apache/buildstream-plugins/pull/25#issuecomment-1212236094

   I think this would be more flexible and convenient if:
   * the default for `build-dir` was `.`
   * the `make` and `make-install` variables were extended to contain `-C %{build-dir}`
   
   it may also be partly a matter of taste, I think this would be much more elegant than having the script jumping around into different directories.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org