[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2026: DRILL-7330: Implement metadata usage for all format plugins

[GitBox <gi...@apache.org>]

arina-ielchiieva commented on a change in pull request #2026: DRILL-7330: Implement metadata usage for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392591157
 
 

 ##########
 File path: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeParquetScan.java
 ##########
 @@ -213,11 +231,25 @@ protected boolean supportsFileImplicitColumns() {
     return hivePartitionHolder.get(locationProvider.getPath());
   }
 
+  @Override
+  protected ParquetMetadataProviderBuilder<?> tableMetadataProviderBuilder(MetadataProviderManager source) {
+    if (source.usesMetastore()) {
 
 Review comment:
   When this case is possible?
   When wee try to run analyze over Hive table using native parquet scan? Or when metastore is enabled and we try to query Hive table with native parquet scan? I really hope this is not the second case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services