You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/15 04:45:26 UTC

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #375: [FLINK-28552] GenerateUtils#generateCompare supports MULTISET and MAP

JingsongLi commented on code in PR #375:
URL: https://github.com/apache/flink-table-store/pull/375#discussion_r1022311783


##########
flink-table-store-format/src/main/java/org/apache/flink/table/store/format/orc/OrcFileFormat.java:
##########
@@ -111,7 +113,7 @@ public BulkFormat<RowData, FileSourceSplit> createReaderFactory(
      */
     @Override
     public BulkWriter.Factory<RowData> createWriterFactory(RowType type) {
-        LogicalType[] orcTypes = type.getChildren().toArray(new LogicalType[0]);
+        LogicalType[] orcTypes = refineLogicalType(type).getChildren().toArray(new LogicalType[0]);

Review Comment:
   Minor: `LogicalType refinedType = refineLogicalType(type);`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org