You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Philip Martin <ph...@wandisco.com> on 2010/03/18 09:22:56 UTC
Re: svn commit: r922867 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/commit.c libsvn_wc/lock.c
Greg Stein <gs...@gmail.com> writes:
> Lately, we have not been using svn_error_compose(), favoring
> svn_error_compose_create() since it Does The Right Thing with the
> args, whether they're errors or not. Thus, the above code would
> typically be written:
>
> svn_error_t *err2 = svn_wc__release_write_lock(...);
>
> return svn_error_return(svn_err_compose_create(err, err2));
I can't use that since r922926 put the compose into a loop, but I
suppose I could change the compose into a compose_create. In a single
db the recursive lock will be a single row so the code can simply be
removed.
--
Philip