[GitHub] [ozone] prashantpogde commented on a diff in pull request #4214: HDDS-7845. Added wait for checkpoint directory creation in rocksDB

["prashantpogde (via GitHub)" <gi...@apache.org>]

prashantpogde commented on code in PR #4214:
URL: https://github.com/apache/ozone/pull/4214#discussion_r1089353370


##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBCheckpointManager.java:
##########
@@ -85,6 +87,8 @@ public RocksDBCheckpoint createCheckpoint(String parentDir, String name) {
       LOG.info("Created checkpoint at {} in {} milliseconds",
               checkpointPath, duration);

Review Comment:
   +1. Let us Log both the time durations, once the RocksDB checkpoint API returns and also after the checkpoint directory comes into namespace.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org