You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tez.apache.org by je...@apache.org on 2021/06/30 15:12:35 UTC

[tez] branch branch-0.9 updated: TEZ-4308: Add Whitespace in ShuffleScheduler Error Message (#122)

This is an automated email from the ASF dual-hosted git repository.

jeagles pushed a commit to branch branch-0.9
in repository https://gitbox.apache.org/repos/asf/tez.git


The following commit(s) were added to refs/heads/branch-0.9 by this push:
     new 2f701d8  TEZ-4308: Add Whitespace in ShuffleScheduler Error Message (#122)
2f701d8 is described below

commit 2f701d83200abfb92a9595fccea9ed13364f7243
Author: belugabehr <12...@users.noreply.github.com>
AuthorDate: Wed Jun 30 11:11:09 2021 -0400

    TEZ-4308: Add Whitespace in ShuffleScheduler Error Message (#122)
    
    (cherry picked from commit 5eeccf0e318e22cdcbbe202a9f554f93d138c207)
---
 .../common/shuffle/orderedgrouped/ShuffleScheduler.java       | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/orderedgrouped/ShuffleScheduler.java b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/orderedgrouped/ShuffleScheduler.java
index a2ea037..736f41b 100644
--- a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/orderedgrouped/ShuffleScheduler.java
+++ b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/orderedgrouped/ShuffleScheduler.java
@@ -1042,12 +1042,13 @@ class ShuffleScheduler {
         && !fetcherHealthy
         && (!reducerProgressedEnough || reducerStalled)) {
       String errorMsg = (srcNameTrimmed + ": "
-          + "Shuffle failed with too many fetch failures and insufficient progress!"
-          + "failureCounts=" + failureCounts.size()
+          + "Shuffle failed with too many fetch failures and insufficient progress: "
+          + "[failureCounts=" + failureCounts.size()
           + ", pendingInputs=" + (numInputs - doneMaps)
           + ", fetcherHealthy=" + fetcherHealthy
           + ", reducerProgressedEnough=" + reducerProgressedEnough
-          + ", reducerStalled=" + reducerStalled);
+          + ", reducerStalled=" + reducerStalled)
+          + "]";
       LOG.error(errorMsg);
       if (LOG.isDebugEnabled()) {
         LOG.debug("Host failures=" + hostFailures.keySet());
@@ -1107,7 +1108,7 @@ class ShuffleScheduler {
       }
       IOException exception = new IOException(srcAttempt + " is marked as obsoleteInput, but it "
           + "exists in shuffleInfoEventMap. Some data could have been already merged "
-          + "to memory/disk outputs.  Failing the fetch early. eventInfo:" + eventInfo.toString());
+          + "to memory/disk outputs. Failing the fetch early. eventInfo: " + eventInfo);
       String message = "Got obsolete event. Killing self as attempt's data could have been consumed";
       killSelf(exception, message);
       return;
@@ -1377,7 +1378,7 @@ class ShuffleScheduler {
             } catch (InterruptedException e) {
               if (isShutdown.get()) {
                 LOG.info(srcNameTrimmed + ": " +
-                    "Interrupted while waiting for fetchers to complete" +
+                    "Interrupted while waiting for fetchers to complete " +
                     "and hasBeenShutdown. Breaking out of ShuffleSchedulerCallable loop");
                 Thread.currentThread().interrupt();
                 break;