[GitHub] [superset] AAfghahi commented on a diff in pull request #21065: fix(databases): GSheets and Clickhouse DBs are not allowed to upload files

[GitBox <gi...@apache.org>]

AAfghahi commented on code in PR #21065:
URL: https://github.com/apache/superset/pull/21065#discussion_r951759755


##########
superset/db_engine_specs/base.py:
##########
@@ -1594,6 +1598,17 @@ def get_impersonation_key(cls, user: Optional[User]) -> Any:
         """
         return user.username if user else None
 
+    @classmethod
+    def get_public_information(cls) -> Dict[str, Any]:
+        """
+        Construct a Dict with properties we want to expose.
+
+        :returns: Dict with properties of our class like allows_file_upload
+        """
+        return {
+            "allows_file_upload": cls.allows_file_upload,

Review Comment:
   how is this different from the current colum `allow_file_upload`? If they are very different, then should we think about changing the name of this? 
   
   `allows_file_upload` and `allow_file_upload` being different columns that serve different purposes is going to be way too confusing. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org