You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/11 09:00:33 UTC

[GitHub] [airflow] uranusjr commented on pull request #24401: handle exception when resolving XComArg

uranusjr commented on PR #24401:
URL: https://github.com/apache/airflow/pull/24401#issuecomment-1211722235

   Hmm, actually after some more thought, this is actually the most viable solution. The scheduler already checks whether a downstream should be run with `TriggerRuleDep`, so if the current (downstream) task’s trigger rule does not allow a failed upstream, we would not be able to reach the part where the XCom gets resolved at all. In other words, if we are resolving an XCom reference, _the task is always running in an appropriate context_ and therefore should receive None.
   
   This still needs some tests, so I’m going to create a new PR instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org