You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/31 03:46:47 UTC
[GitHub] [dolphinscheduler] EricGao888 opened a new pull request, #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
EricGao888 opened a new pull request, #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708
## Purpose of the pull request
* Add support for Alibaba Cloud OSS as storage of resource center.
* Still WIP, will add UTs, docs and do some refactoring in the following commits.
* This PR closes: #11683
## Brief change log
* Add support for Alibaba Cloud OSS as storage of resource center.
* Others WIP.
## Verify this pull request
* Still WIP, not verified yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1233695536
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11708)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list) [31.6% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list) [8.3% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1250941919
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11708)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list) [37.4% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list) [4.8% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1233731094
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11708)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list) [31.6% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list) [8.3% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#discussion_r962432274
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/config/StoreConfiguration.java:
##########
@@ -41,6 +43,10 @@ public class StoreConfiguration {
@Bean
public StorageOperate storageOperate() {
switch (PropertyUtils.getString(RESOURCE_STORAGE_TYPE)) {
+ case STORAGE_OSS:
+ OssOperator ossOperator = OssOperator.getInstance();
+ ossOperator.init();
Review Comment:
This is also for code-decoupling and testing purpose. If we put this in the constructor, `oss client` will get instantiated in the constructor. As a result, we lose control of the instantiation of the external class and could not inject the corresponding mock during testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1252227097
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11708)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list) [35.6% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list) [4.8% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1233694555
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11708)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list) [30.1% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list) [8.3% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#discussion_r962429939
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -289,3 +289,14 @@ zeppelin-client-0.10.1.jar
zeppelin-common-0.10.1.jar
zjsonpatch-0.3.0.jar
zookeeper-3.4.14.jar
+aliyun-java-sdk-core-4.5.10.jar
Review Comment:
Sure, will update `dolphinscheduler-dist/release-docs/LICENSE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#discussion_r974139524
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/config/StoreConfiguration.java:
##########
@@ -41,6 +43,10 @@ public class StoreConfiguration {
@Bean
public StorageOperate storageOperate() {
switch (PropertyUtils.getString(RESOURCE_STORAGE_TYPE)) {
+ case STORAGE_OSS:
+ OssOperator ossOperator = OssOperator.getInstance();
+ ossOperator.init();
Review Comment:
I removed singleton implementation of OssOperator in the latest commit and provided a new init method which takes `ossConnection` for `OssClientFactory` to instantiate `OSS Client`. Once `configuration / connection` center supported, I will change to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#discussion_r962409758
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/config/StoreConfiguration.java:
##########
@@ -41,6 +43,10 @@ public class StoreConfiguration {
@Bean
public StorageOperate storageOperate() {
switch (PropertyUtils.getString(RESOURCE_STORAGE_TYPE)) {
+ case STORAGE_OSS:
+ OssOperator ossOperator = OssOperator.getInstance();
+ ossOperator.init();
Review Comment:
Since this is a singleton, why you don't put the `init` method into constructor? Can the init method be executed multiple times?
##########
dolphinscheduler-common/pom.xml:
##########
@@ -275,6 +287,12 @@
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>com.aliyun.oss</groupId>
+ <artifactId>aliyun-sdk-oss</artifactId>
+ <version>3.15.1</version>
Review Comment:
Please manage the version in bom.
```suggestion
```
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/PropertyUtilsWrapper.java:
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.common.utils;
+
+import lombok.Data;
+
+@Data
+public class PropertyUtilsWrapper {
Review Comment:
I don't see this class doing any enhancement, why we don't directly execute `PropertyUtils.getString`
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -289,3 +289,14 @@ zeppelin-client-0.10.1.jar
zeppelin-common-0.10.1.jar
zjsonpatch-0.3.0.jar
zookeeper-3.4.14.jar
+aliyun-java-sdk-core-4.5.10.jar
Review Comment:
Please update the LICENSE.
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OssOperator.java:
##########
@@ -0,0 +1,321 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.common.utils;
+
+import static org.apache.dolphinscheduler.common.Constants.ALIBABA_CLOUD_OSS_END_POINT;
+import static org.apache.dolphinscheduler.common.Constants.FOLDER_SEPARATOR;
+import static org.apache.dolphinscheduler.common.Constants.FORMAT_S_S;
+import static org.apache.dolphinscheduler.common.Constants.RESOURCE_TYPE_FILE;
+import static org.apache.dolphinscheduler.common.Constants.RESOURCE_TYPE_UDF;
+
+import org.apache.dolphinscheduler.common.Constants;
+import org.apache.dolphinscheduler.common.enums.ResUploadType;
+import org.apache.dolphinscheduler.common.storage.StorageOperate;
+import org.apache.dolphinscheduler.plugin.task.api.TaskConstants;
+import org.apache.dolphinscheduler.spi.enums.ResourceType;
+
+import org.apache.commons.lang3.StringUtils;
+
+import java.io.BufferedReader;
+import java.io.ByteArrayInputStream;
+import java.io.Closeable;
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.nio.file.Files;
+import java.util.Collections;
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.aliyun.oss.OSS;
+import com.aliyun.oss.OSSClientBuilder;
+import com.aliyun.oss.OSSException;
+import com.aliyun.oss.model.Bucket;
+import com.aliyun.oss.model.OSSObject;
+import com.aliyun.oss.model.ObjectMetadata;
+import com.aliyun.oss.model.PutObjectRequest;
+
+public class OssOperator implements Closeable, StorageOperate {
+
+ private static final Logger logger = LoggerFactory.getLogger(OssOperator.class);
+
+ public static String ACCESS_KEY_ID;
+
+ public static String ACCESS_KEY_SECRET;
+
+ public static String REGION;
+
+ public static String BUCKET_NAME;
+
+ public static String BASE_DIR = "";
+
+ private OSS ossClient;
+
+ private PropertyUtilsWrapper propertyUtilsWrapper;
+
+ private OssOperator() {
+ }
+
+ private enum OssOperatorSingleton {
+
+ INSTANCE;
+
+ private final OssOperator instance;
+
+ OssOperatorSingleton() {
+ instance = new OssOperator();
+ }
+
+ private OssOperator getInstance() {
+ return instance;
+ }
+ }
+
+ public static OssOperator getInstance() {
+ return OssOperatorSingleton.INSTANCE.getInstance();
+ }
+
+ public void init() {
+ propertyUtilsWrapper = createPropertyUtilsWrapper();
+ ACCESS_KEY_ID = propertyUtilsWrapper.getString(TaskConstants.ALIBABA_CLOUD_ACCESS_KEY_ID);
+ ACCESS_KEY_SECRET = propertyUtilsWrapper.getString(TaskConstants.ALIBABA_CLOUD_ACCESS_KEY_SECRET);
+ REGION = propertyUtilsWrapper.getString(TaskConstants.ALIBABA_CLOUD_REGION);
+ BUCKET_NAME = propertyUtilsWrapper.getString(Constants.ALIBABA_CLOUD_OSS_BUCKET_NAME);
+
+ ossClient = buildOssClient();
+ ensureBucketSuccessfullyCreated(BUCKET_NAME);
+ }
+
+ @Override
+ public void close() throws IOException {
+ ossClient.shutdown();
+ }
+
+ @Override
+ public void createTenantDirIfNotExists(String tenantCode) throws Exception {
+ mkdir(tenantCode, getOssResDir(tenantCode));
+ mkdir(tenantCode, getOssUdfDir(tenantCode));
+ }
+
+ @Override
+ public String getResDir(String tenantCode) {
+ return getOssResDir(tenantCode) + FOLDER_SEPARATOR;
+ }
+
+ @Override
+ public String getUdfDir(String tenantCode) {
+ return getOssUdfDir(tenantCode) + FOLDER_SEPARATOR;
+ }
+
+ @Override
+ public boolean mkdir(String tenantCode, String path) throws IOException {
+ final String key = path + FOLDER_SEPARATOR;
+ if (!ossClient.doesObjectExist(BUCKET_NAME, key)) {
+ createOssPrefix(BUCKET_NAME, key);
+ }
+ return true;
+ }
+
+ protected void createOssPrefix(final String bucketName, final String key) {
+ ObjectMetadata metadata = new ObjectMetadata();
+ metadata.setContentLength(0);
+ InputStream emptyContent = new ByteArrayInputStream(new byte[0]);
+ PutObjectRequest putObjectRequest = new PutObjectRequest(bucketName, key, emptyContent, metadata);
+ ossClient.putObject(putObjectRequest);
+ }
+
+ @Override
+ public String getResourceFileName(String tenantCode, String fileName) {
+ if (fileName.startsWith(FOLDER_SEPARATOR)) {
+ fileName = fileName.replaceFirst(FOLDER_SEPARATOR, "");
+ }
+ return String.format(FORMAT_S_S, getOssResDir(tenantCode), fileName);
+ }
+
+ @Override
+ public String getFileName(ResourceType resourceType, String tenantCode, String fileName) {
+ if (fileName.startsWith(FOLDER_SEPARATOR)) {
+ fileName = fileName.replaceFirst(FOLDER_SEPARATOR, "");
+ }
+ return getDir(resourceType, tenantCode) + fileName;
+ }
+
+ @Override
+ public void download(String tenantCode, String srcFilePath, String dstFilePath, boolean deleteSource,
+ boolean overwrite) throws IOException {
+ File dstFile = new File(dstFilePath);
+ if (dstFile.isDirectory()) {
+ Files.delete(dstFile.toPath());
+ } else {
+ Files.createDirectories(dstFile.getParentFile().toPath());
+ }
+ OSSObject ossObject = ossClient.getObject(BUCKET_NAME, srcFilePath);
+ try (
+ InputStream ossInputStream = ossObject.getObjectContent();
+ FileOutputStream fos = new FileOutputStream(dstFilePath)) {
+ byte[] readBuf = new byte[1024];
+ int readLen;
+ while ((readLen = ossInputStream.read(readBuf)) > 0) {
+ fos.write(readBuf, 0, readLen);
+ }
+ } catch (OSSException e) {
+ throw new IOException(e.getMessage());
+ } catch (FileNotFoundException e) {
+ logger.error("the destination file {} not found", dstFilePath);
+ throw e;
+ }
+ }
+
+ @Override
+ public boolean exists(String tenantCode, String fileName) throws IOException {
+ return ossClient.doesObjectExist(BUCKET_NAME, fileName);
+ }
+
+ @Override
+ public boolean delete(String tenantCode, String filePath, boolean recursive) throws IOException {
+ try {
+ ossClient.deleteObject(BUCKET_NAME, filePath);
+ return true;
+ } catch (OSSException e) {
+ logger.error("delete the object error,the resource path is {}", filePath);
+ return false;
+ }
+ }
+
+ @Override
+ public boolean copy(String srcPath, String dstPath, boolean deleteSource, boolean overwrite) throws IOException {
+ ossClient.copyObject(BUCKET_NAME, srcPath, BUCKET_NAME, dstPath);
+ ossClient.deleteObject(BUCKET_NAME, srcPath);
+ return true;
+ }
+
+ @Override
+ public String getDir(ResourceType resourceType, String tenantCode) {
+ switch (resourceType) {
+ case UDF:
+ return getUdfDir(tenantCode);
+ case FILE:
+ return getResDir(tenantCode);
+ default:
+ return BASE_DIR;
+ }
+ }
+
+ @Override
+ public boolean upload(String tenantCode, String srcFile, String dstPath, boolean deleteSource,
+ boolean overwrite) throws IOException {
+ try {
+ ossClient.putObject(BUCKET_NAME, dstPath, new File(srcFile));
+ return true;
+ } catch (OSSException e) {
+ logger.error("upload failed,the bucketName is {},the filePath is {}", BUCKET_NAME, dstPath);
Review Comment:
```suggestion
logger.error("upload failed,the bucketName is {},the filePath is {}", BUCKET_NAME, dstPath, e);
```
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OssOperator.java:
##########
@@ -0,0 +1,321 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.common.utils;
+
+import static org.apache.dolphinscheduler.common.Constants.ALIBABA_CLOUD_OSS_END_POINT;
+import static org.apache.dolphinscheduler.common.Constants.FOLDER_SEPARATOR;
+import static org.apache.dolphinscheduler.common.Constants.FORMAT_S_S;
+import static org.apache.dolphinscheduler.common.Constants.RESOURCE_TYPE_FILE;
+import static org.apache.dolphinscheduler.common.Constants.RESOURCE_TYPE_UDF;
+
+import org.apache.dolphinscheduler.common.Constants;
+import org.apache.dolphinscheduler.common.enums.ResUploadType;
+import org.apache.dolphinscheduler.common.storage.StorageOperate;
+import org.apache.dolphinscheduler.plugin.task.api.TaskConstants;
+import org.apache.dolphinscheduler.spi.enums.ResourceType;
+
+import org.apache.commons.lang3.StringUtils;
+
+import java.io.BufferedReader;
+import java.io.ByteArrayInputStream;
+import java.io.Closeable;
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.nio.file.Files;
+import java.util.Collections;
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.aliyun.oss.OSS;
+import com.aliyun.oss.OSSClientBuilder;
+import com.aliyun.oss.OSSException;
+import com.aliyun.oss.model.Bucket;
+import com.aliyun.oss.model.OSSObject;
+import com.aliyun.oss.model.ObjectMetadata;
+import com.aliyun.oss.model.PutObjectRequest;
+
+public class OssOperator implements Closeable, StorageOperate {
+
+ private static final Logger logger = LoggerFactory.getLogger(OssOperator.class);
+
+ public static String ACCESS_KEY_ID;
+
+ public static String ACCESS_KEY_SECRET;
+
+ public static String REGION;
+
+ public static String BUCKET_NAME;
+
+ public static String BASE_DIR = "";
+
+ private OSS ossClient;
+
+ private PropertyUtilsWrapper propertyUtilsWrapper;
+
+ private OssOperator() {
+ }
+
+ private enum OssOperatorSingleton {
+
+ INSTANCE;
+
+ private final OssOperator instance;
+
+ OssOperatorSingleton() {
+ instance = new OssOperator();
+ }
+
+ private OssOperator getInstance() {
+ return instance;
+ }
+ }
+
+ public static OssOperator getInstance() {
+ return OssOperatorSingleton.INSTANCE.getInstance();
+ }
+
+ public void init() {
+ propertyUtilsWrapper = createPropertyUtilsWrapper();
+ ACCESS_KEY_ID = propertyUtilsWrapper.getString(TaskConstants.ALIBABA_CLOUD_ACCESS_KEY_ID);
+ ACCESS_KEY_SECRET = propertyUtilsWrapper.getString(TaskConstants.ALIBABA_CLOUD_ACCESS_KEY_SECRET);
+ REGION = propertyUtilsWrapper.getString(TaskConstants.ALIBABA_CLOUD_REGION);
+ BUCKET_NAME = propertyUtilsWrapper.getString(Constants.ALIBABA_CLOUD_OSS_BUCKET_NAME);
+
+ ossClient = buildOssClient();
+ ensureBucketSuccessfullyCreated(BUCKET_NAME);
+ }
+
+ @Override
+ public void close() throws IOException {
+ ossClient.shutdown();
+ }
+
+ @Override
+ public void createTenantDirIfNotExists(String tenantCode) throws Exception {
+ mkdir(tenantCode, getOssResDir(tenantCode));
+ mkdir(tenantCode, getOssUdfDir(tenantCode));
+ }
+
+ @Override
+ public String getResDir(String tenantCode) {
+ return getOssResDir(tenantCode) + FOLDER_SEPARATOR;
+ }
+
+ @Override
+ public String getUdfDir(String tenantCode) {
+ return getOssUdfDir(tenantCode) + FOLDER_SEPARATOR;
+ }
+
+ @Override
+ public boolean mkdir(String tenantCode, String path) throws IOException {
+ final String key = path + FOLDER_SEPARATOR;
+ if (!ossClient.doesObjectExist(BUCKET_NAME, key)) {
+ createOssPrefix(BUCKET_NAME, key);
+ }
+ return true;
+ }
+
+ protected void createOssPrefix(final String bucketName, final String key) {
+ ObjectMetadata metadata = new ObjectMetadata();
+ metadata.setContentLength(0);
+ InputStream emptyContent = new ByteArrayInputStream(new byte[0]);
+ PutObjectRequest putObjectRequest = new PutObjectRequest(bucketName, key, emptyContent, metadata);
+ ossClient.putObject(putObjectRequest);
+ }
+
+ @Override
+ public String getResourceFileName(String tenantCode, String fileName) {
+ if (fileName.startsWith(FOLDER_SEPARATOR)) {
+ fileName = fileName.replaceFirst(FOLDER_SEPARATOR, "");
+ }
+ return String.format(FORMAT_S_S, getOssResDir(tenantCode), fileName);
+ }
+
+ @Override
+ public String getFileName(ResourceType resourceType, String tenantCode, String fileName) {
+ if (fileName.startsWith(FOLDER_SEPARATOR)) {
+ fileName = fileName.replaceFirst(FOLDER_SEPARATOR, "");
+ }
+ return getDir(resourceType, tenantCode) + fileName;
+ }
+
+ @Override
+ public void download(String tenantCode, String srcFilePath, String dstFilePath, boolean deleteSource,
+ boolean overwrite) throws IOException {
+ File dstFile = new File(dstFilePath);
+ if (dstFile.isDirectory()) {
+ Files.delete(dstFile.toPath());
+ } else {
+ Files.createDirectories(dstFile.getParentFile().toPath());
+ }
+ OSSObject ossObject = ossClient.getObject(BUCKET_NAME, srcFilePath);
+ try (
+ InputStream ossInputStream = ossObject.getObjectContent();
+ FileOutputStream fos = new FileOutputStream(dstFilePath)) {
+ byte[] readBuf = new byte[1024];
+ int readLen;
+ while ((readLen = ossInputStream.read(readBuf)) > 0) {
+ fos.write(readBuf, 0, readLen);
+ }
+ } catch (OSSException e) {
+ throw new IOException(e.getMessage());
Review Comment:
```suggestion
throw new IOException(e);
```
Don't hide the stack.
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OssOperator.java:
##########
@@ -0,0 +1,321 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.common.utils;
+
+import static org.apache.dolphinscheduler.common.Constants.ALIBABA_CLOUD_OSS_END_POINT;
+import static org.apache.dolphinscheduler.common.Constants.FOLDER_SEPARATOR;
+import static org.apache.dolphinscheduler.common.Constants.FORMAT_S_S;
+import static org.apache.dolphinscheduler.common.Constants.RESOURCE_TYPE_FILE;
+import static org.apache.dolphinscheduler.common.Constants.RESOURCE_TYPE_UDF;
+
+import org.apache.dolphinscheduler.common.Constants;
+import org.apache.dolphinscheduler.common.enums.ResUploadType;
+import org.apache.dolphinscheduler.common.storage.StorageOperate;
+import org.apache.dolphinscheduler.plugin.task.api.TaskConstants;
+import org.apache.dolphinscheduler.spi.enums.ResourceType;
+
+import org.apache.commons.lang3.StringUtils;
+
+import java.io.BufferedReader;
+import java.io.ByteArrayInputStream;
+import java.io.Closeable;
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.nio.file.Files;
+import java.util.Collections;
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.aliyun.oss.OSS;
+import com.aliyun.oss.OSSClientBuilder;
+import com.aliyun.oss.OSSException;
+import com.aliyun.oss.model.Bucket;
+import com.aliyun.oss.model.OSSObject;
+import com.aliyun.oss.model.ObjectMetadata;
+import com.aliyun.oss.model.PutObjectRequest;
+
+public class OssOperator implements Closeable, StorageOperate {
+
+ private static final Logger logger = LoggerFactory.getLogger(OssOperator.class);
+
+ public static String ACCESS_KEY_ID;
+
+ public static String ACCESS_KEY_SECRET;
+
+ public static String REGION;
+
+ public static String BUCKET_NAME;
+
+ public static String BASE_DIR = "";
+
+ private OSS ossClient;
+
+ private PropertyUtilsWrapper propertyUtilsWrapper;
+
+ private OssOperator() {
+ }
+
+ private enum OssOperatorSingleton {
+
+ INSTANCE;
+
+ private final OssOperator instance;
+
+ OssOperatorSingleton() {
+ instance = new OssOperator();
+ }
+
+ private OssOperator getInstance() {
+ return instance;
+ }
+ }
+
+ public static OssOperator getInstance() {
+ return OssOperatorSingleton.INSTANCE.getInstance();
+ }
+
+ public void init() {
+ propertyUtilsWrapper = createPropertyUtilsWrapper();
+ ACCESS_KEY_ID = propertyUtilsWrapper.getString(TaskConstants.ALIBABA_CLOUD_ACCESS_KEY_ID);
+ ACCESS_KEY_SECRET = propertyUtilsWrapper.getString(TaskConstants.ALIBABA_CLOUD_ACCESS_KEY_SECRET);
+ REGION = propertyUtilsWrapper.getString(TaskConstants.ALIBABA_CLOUD_REGION);
+ BUCKET_NAME = propertyUtilsWrapper.getString(Constants.ALIBABA_CLOUD_OSS_BUCKET_NAME);
+
+ ossClient = buildOssClient();
+ ensureBucketSuccessfullyCreated(BUCKET_NAME);
+ }
+
+ @Override
+ public void close() throws IOException {
+ ossClient.shutdown();
+ }
+
+ @Override
+ public void createTenantDirIfNotExists(String tenantCode) throws Exception {
+ mkdir(tenantCode, getOssResDir(tenantCode));
+ mkdir(tenantCode, getOssUdfDir(tenantCode));
+ }
+
+ @Override
+ public String getResDir(String tenantCode) {
+ return getOssResDir(tenantCode) + FOLDER_SEPARATOR;
+ }
+
+ @Override
+ public String getUdfDir(String tenantCode) {
+ return getOssUdfDir(tenantCode) + FOLDER_SEPARATOR;
+ }
+
+ @Override
+ public boolean mkdir(String tenantCode, String path) throws IOException {
+ final String key = path + FOLDER_SEPARATOR;
+ if (!ossClient.doesObjectExist(BUCKET_NAME, key)) {
+ createOssPrefix(BUCKET_NAME, key);
+ }
+ return true;
+ }
+
+ protected void createOssPrefix(final String bucketName, final String key) {
+ ObjectMetadata metadata = new ObjectMetadata();
+ metadata.setContentLength(0);
+ InputStream emptyContent = new ByteArrayInputStream(new byte[0]);
+ PutObjectRequest putObjectRequest = new PutObjectRequest(bucketName, key, emptyContent, metadata);
+ ossClient.putObject(putObjectRequest);
+ }
+
+ @Override
+ public String getResourceFileName(String tenantCode, String fileName) {
+ if (fileName.startsWith(FOLDER_SEPARATOR)) {
+ fileName = fileName.replaceFirst(FOLDER_SEPARATOR, "");
+ }
+ return String.format(FORMAT_S_S, getOssResDir(tenantCode), fileName);
+ }
+
+ @Override
+ public String getFileName(ResourceType resourceType, String tenantCode, String fileName) {
+ if (fileName.startsWith(FOLDER_SEPARATOR)) {
+ fileName = fileName.replaceFirst(FOLDER_SEPARATOR, "");
+ }
+ return getDir(resourceType, tenantCode) + fileName;
+ }
+
+ @Override
+ public void download(String tenantCode, String srcFilePath, String dstFilePath, boolean deleteSource,
+ boolean overwrite) throws IOException {
+ File dstFile = new File(dstFilePath);
+ if (dstFile.isDirectory()) {
+ Files.delete(dstFile.toPath());
+ } else {
+ Files.createDirectories(dstFile.getParentFile().toPath());
+ }
+ OSSObject ossObject = ossClient.getObject(BUCKET_NAME, srcFilePath);
+ try (
+ InputStream ossInputStream = ossObject.getObjectContent();
+ FileOutputStream fos = new FileOutputStream(dstFilePath)) {
+ byte[] readBuf = new byte[1024];
+ int readLen;
+ while ((readLen = ossInputStream.read(readBuf)) > 0) {
+ fos.write(readBuf, 0, readLen);
+ }
+ } catch (OSSException e) {
+ throw new IOException(e.getMessage());
+ } catch (FileNotFoundException e) {
+ logger.error("the destination file {} not found", dstFilePath);
+ throw e;
+ }
+ }
+
+ @Override
+ public boolean exists(String tenantCode, String fileName) throws IOException {
+ return ossClient.doesObjectExist(BUCKET_NAME, fileName);
+ }
+
+ @Override
+ public boolean delete(String tenantCode, String filePath, boolean recursive) throws IOException {
+ try {
+ ossClient.deleteObject(BUCKET_NAME, filePath);
+ return true;
+ } catch (OSSException e) {
+ logger.error("delete the object error,the resource path is {}", filePath);
Review Comment:
```suggestion
logger.error("delete the object error,the resource path is {}", filePath, e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1232447204
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11708)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list) [9.2% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1232680843
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11708)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list) [31.6% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list) [8.3% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 merged pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
EricGao888 merged PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1232448039
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11708)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list) [9.2% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#discussion_r962430049
##########
dolphinscheduler-common/pom.xml:
##########
@@ -275,6 +287,12 @@
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>com.aliyun.oss</groupId>
+ <artifactId>aliyun-sdk-oss</artifactId>
+ <version>3.15.1</version>
Review Comment:
Sure, thanks for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1232558062
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11708)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list) [9.2% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1233725132
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11708)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list) [30.1% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list) [8.3% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#discussion_r962430143
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OssOperator.java:
##########
@@ -0,0 +1,321 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.common.utils;
+
+import static org.apache.dolphinscheduler.common.Constants.ALIBABA_CLOUD_OSS_END_POINT;
+import static org.apache.dolphinscheduler.common.Constants.FOLDER_SEPARATOR;
+import static org.apache.dolphinscheduler.common.Constants.FORMAT_S_S;
+import static org.apache.dolphinscheduler.common.Constants.RESOURCE_TYPE_FILE;
+import static org.apache.dolphinscheduler.common.Constants.RESOURCE_TYPE_UDF;
+
+import org.apache.dolphinscheduler.common.Constants;
+import org.apache.dolphinscheduler.common.enums.ResUploadType;
+import org.apache.dolphinscheduler.common.storage.StorageOperate;
+import org.apache.dolphinscheduler.plugin.task.api.TaskConstants;
+import org.apache.dolphinscheduler.spi.enums.ResourceType;
+
+import org.apache.commons.lang3.StringUtils;
+
+import java.io.BufferedReader;
+import java.io.ByteArrayInputStream;
+import java.io.Closeable;
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.nio.file.Files;
+import java.util.Collections;
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.aliyun.oss.OSS;
+import com.aliyun.oss.OSSClientBuilder;
+import com.aliyun.oss.OSSException;
+import com.aliyun.oss.model.Bucket;
+import com.aliyun.oss.model.OSSObject;
+import com.aliyun.oss.model.ObjectMetadata;
+import com.aliyun.oss.model.PutObjectRequest;
+
+public class OssOperator implements Closeable, StorageOperate {
+
+ private static final Logger logger = LoggerFactory.getLogger(OssOperator.class);
+
+ public static String ACCESS_KEY_ID;
+
+ public static String ACCESS_KEY_SECRET;
+
+ public static String REGION;
+
+ public static String BUCKET_NAME;
+
+ public static String BASE_DIR = "";
+
+ private OSS ossClient;
+
+ private PropertyUtilsWrapper propertyUtilsWrapper;
+
+ private OssOperator() {
+ }
+
+ private enum OssOperatorSingleton {
+
+ INSTANCE;
+
+ private final OssOperator instance;
+
+ OssOperatorSingleton() {
+ instance = new OssOperator();
+ }
+
+ private OssOperator getInstance() {
+ return instance;
+ }
+ }
+
+ public static OssOperator getInstance() {
+ return OssOperatorSingleton.INSTANCE.getInstance();
+ }
+
+ public void init() {
+ propertyUtilsWrapper = createPropertyUtilsWrapper();
+ ACCESS_KEY_ID = propertyUtilsWrapper.getString(TaskConstants.ALIBABA_CLOUD_ACCESS_KEY_ID);
+ ACCESS_KEY_SECRET = propertyUtilsWrapper.getString(TaskConstants.ALIBABA_CLOUD_ACCESS_KEY_SECRET);
+ REGION = propertyUtilsWrapper.getString(TaskConstants.ALIBABA_CLOUD_REGION);
+ BUCKET_NAME = propertyUtilsWrapper.getString(Constants.ALIBABA_CLOUD_OSS_BUCKET_NAME);
+
+ ossClient = buildOssClient();
+ ensureBucketSuccessfullyCreated(BUCKET_NAME);
+ }
+
+ @Override
+ public void close() throws IOException {
+ ossClient.shutdown();
+ }
+
+ @Override
+ public void createTenantDirIfNotExists(String tenantCode) throws Exception {
+ mkdir(tenantCode, getOssResDir(tenantCode));
+ mkdir(tenantCode, getOssUdfDir(tenantCode));
+ }
+
+ @Override
+ public String getResDir(String tenantCode) {
+ return getOssResDir(tenantCode) + FOLDER_SEPARATOR;
+ }
+
+ @Override
+ public String getUdfDir(String tenantCode) {
+ return getOssUdfDir(tenantCode) + FOLDER_SEPARATOR;
+ }
+
+ @Override
+ public boolean mkdir(String tenantCode, String path) throws IOException {
+ final String key = path + FOLDER_SEPARATOR;
+ if (!ossClient.doesObjectExist(BUCKET_NAME, key)) {
+ createOssPrefix(BUCKET_NAME, key);
+ }
+ return true;
+ }
+
+ protected void createOssPrefix(final String bucketName, final String key) {
+ ObjectMetadata metadata = new ObjectMetadata();
+ metadata.setContentLength(0);
+ InputStream emptyContent = new ByteArrayInputStream(new byte[0]);
+ PutObjectRequest putObjectRequest = new PutObjectRequest(bucketName, key, emptyContent, metadata);
+ ossClient.putObject(putObjectRequest);
+ }
+
+ @Override
+ public String getResourceFileName(String tenantCode, String fileName) {
+ if (fileName.startsWith(FOLDER_SEPARATOR)) {
+ fileName = fileName.replaceFirst(FOLDER_SEPARATOR, "");
+ }
+ return String.format(FORMAT_S_S, getOssResDir(tenantCode), fileName);
+ }
+
+ @Override
+ public String getFileName(ResourceType resourceType, String tenantCode, String fileName) {
+ if (fileName.startsWith(FOLDER_SEPARATOR)) {
+ fileName = fileName.replaceFirst(FOLDER_SEPARATOR, "");
+ }
+ return getDir(resourceType, tenantCode) + fileName;
+ }
+
+ @Override
+ public void download(String tenantCode, String srcFilePath, String dstFilePath, boolean deleteSource,
+ boolean overwrite) throws IOException {
+ File dstFile = new File(dstFilePath);
+ if (dstFile.isDirectory()) {
+ Files.delete(dstFile.toPath());
+ } else {
+ Files.createDirectories(dstFile.getParentFile().toPath());
+ }
+ OSSObject ossObject = ossClient.getObject(BUCKET_NAME, srcFilePath);
+ try (
+ InputStream ossInputStream = ossObject.getObjectContent();
+ FileOutputStream fos = new FileOutputStream(dstFilePath)) {
+ byte[] readBuf = new byte[1024];
+ int readLen;
+ while ((readLen = ossInputStream.read(readBuf)) > 0) {
+ fos.write(readBuf, 0, readLen);
+ }
+ } catch (OSSException e) {
+ throw new IOException(e.getMessage());
Review Comment:
Sure, will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1250808774
Hi @EricGao888 please solve the conflicts.
If it can't be merged this week, will put into 3.2.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1232564487
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11708)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list) [9.2% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1253069360
Hi @EricGao888 can you cherry-pick this pr to 3.1.0-prepare and do some test for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#discussion_r962431036
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/PropertyUtilsWrapper.java:
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.common.utils;
+
+import lombok.Data;
+
+@Data
+public class PropertyUtilsWrapper {
Review Comment:
This is a class to facilitate unit tests. Currently, there is no way to mock `PropertyUtils` as we choose to remove `Powermock`. `Mockito.mockStatic` does not work for this class because `PropertyUtils` throws some kind of `initialization error` when mocking it. `Powermock` could use some mechanism to suppress the error. Therefore, we could choose either to use a `wrapper class` or refactor `PropertyUtils`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1235155249
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11708)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [30 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list) [52.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list) [2.7% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1232679427
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11708)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list) [30.1% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list) [8.3% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#discussion_r974136613
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/PropertyUtilsWrapper.java:
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.common.utils;
+
+import lombok.Data;
+
+@Data
+public class PropertyUtilsWrapper {
Review Comment:
Wrapper class removed in the latest commit.
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -289,3 +289,14 @@ zeppelin-client-0.10.1.jar
zeppelin-common-0.10.1.jar
zjsonpatch-0.3.0.jar
zookeeper-3.4.14.jar
+aliyun-java-sdk-core-4.5.10.jar
Review Comment:
Updated in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#discussion_r974193626
##########
dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/OssOperatorTest.java:
##########
@@ -0,0 +1,253 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.common.utils;
+
+import static org.apache.dolphinscheduler.common.Constants.FOLDER_SEPARATOR;
+import static org.apache.dolphinscheduler.common.Constants.FORMAT_S_S;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.Mockito.doNothing;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+
+import org.apache.dolphinscheduler.spi.enums.ResourceType;
+
+import java.io.IOException;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.junit.MockitoJUnitRunner;
+
+import com.aliyun.oss.OSS;
+
+@RunWith(MockitoJUnitRunner.class)
+public class OssOperatorTest {
Review Comment:
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1250960265
PTAL @ruanwenjun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1250937131
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11708)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list) [37.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list) [4.8% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1232443094
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/11708?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11708](https://codecov.io/gh/apache/dolphinscheduler/pull/11708?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (09d9403) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/4a373454362aeeddafac8649dac76cd199b3315d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4a37345) will **decrease** coverage by `0.13%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## dev #11708 +/- ##
============================================
- Coverage 39.81% 39.68% -0.14%
+ Complexity 4727 4722 -5
============================================
Files 1006 1007 +1
Lines 37936 38031 +95
Branches 4236 4236
============================================
- Hits 15106 15092 -14
- Misses 21224 21334 +110
+ Partials 1606 1605 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/11708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `78.26% <ø> (ø)` | |
| [...hinscheduler/common/config/StoreConfiguration.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2NvbmZpZy9TdG9yZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/dolphinscheduler/common/utils/OssOperator.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL09zc09wZXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...olphinscheduler/plugin/task/api/TaskConstants.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi90YXNrL2FwaS9UYXNrQ29uc3RhbnRzLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...erver/master/processor/queue/TaskEventService.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza0V2ZW50U2VydmljZS5qYXZh) | `75.00% <0.00%> (-5.36%)` | :arrow_down: |
| [...org/apache/dolphinscheduler/remote/utils/Host.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0hvc3QuamF2YQ==) | `42.55% <0.00%> (-2.13%)` | :arrow_down: |
| [...dolphinscheduler/remote/future/ResponseFuture.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2Z1dHVyZS9SZXNwb25zZUZ1dHVyZS5qYXZh) | `81.96% <0.00%> (-1.64%)` | :arrow_down: |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `51.38% <0.00%> (-1.39%)` | :arrow_down: |
| [...r/plugin/task/sqoop/parameter/SqoopParameters.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stc3Fvb3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL3Rhc2svc3Fvb3AvcGFyYW1ldGVyL1Nxb29wUGFyYW1ldGVycy5qYXZh) | `55.12% <0.00%> (-1.29%)` | :arrow_down: |
| [...che/dolphinscheduler/common/utils/HadoopUtils.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0hhZG9vcFV0aWxzLmphdmE=) | `15.86% <0.00%> (-0.73%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1235156868
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11708)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [30 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list) [53.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list) [2.7% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#discussion_r975014353
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/model/OssConnection.java:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.common.model;
+
+import lombok.Data;
+
+@Data
+public class OssConnection {
+
+ public String accessKeyId;
+ public String accessKeySecret;
+ public String endPoint;
+
+ public OssConnection(final String accessKeyId, final String accessKeySecret, final String endPoint) {
+ this.accessKeyId = accessKeyId;
+ this.accessKeySecret = accessKeySecret;
+ this.endPoint = endPoint;
+ }
Review Comment:
Fixed, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1250893070
> Hi @EricGao888 please solve the conflicts. If it can't be merged this week, I will put into 3.2.0.
I just did some refactoring based on the comments from @ruanwenjun and resolved the conflicts. Thanks for the reminder @caishunfeng : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1253099441
> Hi @EricGao888 can you cherry-pick this pr to 3.1.0-prepare and do some test for it?
Sure, I will do it later today, together with #12006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1250930371
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/11708?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11708](https://codecov.io/gh/apache/dolphinscheduler/pull/11708?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (179feb2) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/ad683c3c428876916d9550111fc9bbb77afd9e9f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ad683c3) will **decrease** coverage by `0.03%`.
> The diff coverage is `34.58%`.
```diff
@@ Coverage Diff @@
## dev #11708 +/- ##
============================================
- Coverage 38.68% 38.64% -0.04%
- Complexity 4006 4028 +22
============================================
Files 1002 1005 +3
Lines 37213 37313 +100
Branches 4249 4244 -5
============================================
+ Hits 14394 14420 +26
- Misses 21186 21254 +68
- Partials 1633 1639 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/11708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...heduler/api/service/impl/ResourcesServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9SZXNvdXJjZXNTZXJ2aWNlSW1wbC5qYXZh) | `51.94% <ø> (-0.21%)` | :arrow_down: |
| [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `78.26% <ø> (ø)` | |
| [...hinscheduler/common/config/StoreConfiguration.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2NvbmZpZy9TdG9yZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...e/dolphinscheduler/common/enums/ResUploadType.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Jlc1VwbG9hZFR5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...phinscheduler/common/factory/OssClientFactory.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2ZhY3RvcnkvT3NzQ2xpZW50RmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/dolphinscheduler/common/utils/PropertyUtils.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1Byb3BlcnR5VXRpbHMuamF2YQ==) | `34.83% <ø> (ø)` | |
| [...ache/dolphinscheduler/spi/enums/ResUploadType.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc3BpL2VudW1zL1Jlc1VwbG9hZFR5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...olphinscheduler/plugin/task/api/TaskConstants.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi90YXNrL2FwaS9UYXNrQ29uc3RhbnRzLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...che/dolphinscheduler/common/utils/OssOperator.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL09zc09wZXJhdG9yLmphdmE=) | `34.45% <34.45%> (ø)` | |
| [...e/dolphinscheduler/common/model/OssConnection.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL09zc0Nvbm5lY3Rpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | |
| ... and [20 more](https://codecov.io/gh/apache/dolphinscheduler/pull/11708/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#discussion_r975014647
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -345,3 +345,14 @@ protobuf-java-util-3.17.2.jar
zjsonpatch-0.3.0.jar
zookeeper-3.8.0.jar
zookeeper-jute-3.8.0.jar
+aliyun-java-sdk-core-4.5.10.jar
+aliyun-java-sdk-kms-2.11.0.jar
+aliyun-java-sdk-ram-3.1.0.jar
Review Comment:
Fixed in the latest commit. Thanks for pointing this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#discussion_r974992027
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -345,3 +345,14 @@ protobuf-java-util-3.17.2.jar
zjsonpatch-0.3.0.jar
zookeeper-3.8.0.jar
zookeeper-jute-3.8.0.jar
+aliyun-java-sdk-core-4.5.10.jar
+aliyun-java-sdk-kms-2.11.0.jar
+aliyun-java-sdk-ram-3.1.0.jar
Review Comment:
You forgot announce `aliyun-java-sdk-ram` in LICENSE?
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/model/OssConnection.java:
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.common.model;
+
+import lombok.Data;
+
+@Data
+public class OssConnection {
+
+ public String accessKeyId;
+ public String accessKeySecret;
+ public String endPoint;
+
+ public OssConnection(final String accessKeyId, final String accessKeySecret, final String endPoint) {
+ this.accessKeyId = accessKeyId;
+ this.accessKeySecret = accessKeySecret;
+ this.endPoint = endPoint;
+ }
Review Comment:
Use `@AllArgsConstructor`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#discussion_r974136129
##########
dolphinscheduler-common/pom.xml:
##########
@@ -275,6 +287,12 @@
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>com.aliyun.oss</groupId>
+ <artifactId>aliyun-sdk-oss</artifactId>
+ <version>3.15.1</version>
Review Comment:
Fixed in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11708: [Feature][Resource Center] Add support for Alibaba Cloud OSS as storage of resource center
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11708:
URL: https://github.com/apache/dolphinscheduler/pull/11708#issuecomment-1252230301
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11708)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11708&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list) [35.3% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list) [4.8% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11708&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org