You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "aiven-anton (via GitHub)" <gi...@apache.org> on 2024/10/26 16:13:33 UTC

[PR] KAFKA-17845: Do not omit tagged entity with implicit defaults [kafka]

aiven-anton opened a new pull request, #17608:
URL: https://github.com/apache/kafka/pull/17608

   Only omit tagged struct field values when all of their values have _explicit_ defaults.
   
   This only has an affect for the `UpdateRaftVoterResponseData.currentLeader` field, and the only effect for that field is that a value of `CurrentLeader(leaderId=-1, leaderEpoch=-1, host="", port=0)` will not be written from serialized bytes. As `host=""` and `port=0` are invalid values, this will practically have no impact on performance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17845: Do not omit tagged entity with implicit defaults [kafka]

Posted by "cmccabe (via GitHub)" <gi...@apache.org>.
cmccabe closed pull request #17608: KAFKA-17845: Do not omit tagged entity with implicit defaults
URL: https://github.com/apache/kafka/pull/17608


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-17845: Do not omit tagged entity with implicit defaults [kafka]

Posted by "cmccabe (via GitHub)" <gi...@apache.org>.
cmccabe commented on PR #17608:
URL: https://github.com/apache/kafka/pull/17608#issuecomment-2439797569

   -1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org