You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-commits@db.apache.org by mi...@apache.org on 2005/05/10 19:38:08 UTC

svn commit: r169501 - /incubator/derby/code/trunk/java/engine/org/apache/derby/impl/store/raw/log/LogToFile.java

Author: mikem
Date: Tue May 10 10:38:06 2005
New Revision: 169501

URL: http://svn.apache.org/viewcvs?rev=169501&view=rev
Log:
committing fix for DERBY-237 for ksunithaghm@gmail.com.  

This patch fixes derby-237: Boot errors from store must not lose error messages/stack traces in between.

Actually nested exceptions from the boot error were not lost but their stack traces were not being written out into error stream which is why the entire stack traces of exceptions was not printed out to derby.log


Modified:
    incubator/derby/code/trunk/java/engine/org/apache/derby/impl/store/raw/log/LogToFile.java

Modified: incubator/derby/code/trunk/java/engine/org/apache/derby/impl/store/raw/log/LogToFile.java
URL: http://svn.apache.org/viewcvs/incubator/derby/code/trunk/java/engine/org/apache/derby/impl/store/raw/log/LogToFile.java?rev=169501&r1=169500&r2=169501&view=diff
==============================================================================
--- incubator/derby/code/trunk/java/engine/org/apache/derby/impl/store/raw/log/LogToFile.java (original)
+++ incubator/derby/code/trunk/java/engine/org/apache/derby/impl/store/raw/log/LogToFile.java Tue May 10 10:38:06 2005
@@ -3951,14 +3951,19 @@
 		}
 	}
 
+    /**
+     * print stack trace from the Throwable including
+     * its nested exceptions 
+     * @param t trace starts from this error
+     */
 	private void printErrorStack(Throwable t)
 	{
-		Monitor.logMessage("-------------------------\n");
-		t.printStackTrace(Monitor.getStream().getPrintWriter());
-		Monitor.logMessage("-------------------------\n");
-		ErrorStringBuilder esb = new ErrorStringBuilder(Monitor.getStream().getHeader());
+		ErrorStringBuilder esb = 
+            new ErrorStringBuilder(Monitor.getStream().getHeader());
 		esb.stackTrace(t);
-	}
+        Monitor.logMessage(esb.get().toString());
+        esb.reset();
+    }
 
 
 	/**