You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhaomin1423 (via GitHub)" <gi...@apache.org> on 2023/10/18 18:19:25 UTC
[PR] [SPARK 45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
zhaomin1423 opened a new pull request, #43439:
URL: https://github.com/apache/spark/pull/43439
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
org.apache.spark.sql.connect.client.util.Cleaner is a temporary class, waiting for the upgrade of jdk to 9 or above.
https://issues.apache.org/jira/browse/SPARK-45596
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
pass ci
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
Posted by "zhaomin1423 (via GitHub)" <gi...@apache.org>.
zhaomin1423 commented on PR #43439:
URL: https://github.com/apache/spark/pull/43439#issuecomment-1777490785
> > What I am confused about is, how should we check the effect after gc is triggered
>
> Construct a case where `SparkResult` won't be manually closed, and check if after registering `cleanable`, `Cleaner.impl.phantomCleanableList` is not empty, but eventually `phantomCleanableList` is empty? This may require adding some code to get `phantomCleanableList` through reflection, just a suggestion, not sure if it's really feasible.
can't get Cleaner.impl by reflect, there is an exception.
```
Exception in thread "main" java.lang.reflect.InaccessibleObjectException: Unable to make field final jdk.internal.ref.CleanerImpl java.lang.ref.Cleaner.impl accessible: module java.base does not "opens java.lang.ref" to unnamed module @2f92e0f4
at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
Posted by "zhaomin1423 (via GitHub)" <gi...@apache.org>.
zhaomin1423 commented on PR #43439:
URL: https://github.com/apache/spark/pull/43439#issuecomment-1771459952
> The change looks good, can I also ask if you could add a test for it, e.g. following [this test example](https://github.com/netty/netty/blob/main/buffer/src/test/java/io/netty5/buffer/tests/BufferCleanerTest.java#L55)?
Sorry, This example compares memory usage because of the allocated off-heap memory, it seems difficult for us to compare memory usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #43439: [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner
URL: https://github.com/apache/spark/pull/43439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43439:
URL: https://github.com/apache/spark/pull/43439#issuecomment-1781211236
Merged into master for Spark 4.0.
Thanks for your contribution. @zhaomin1423
Thanks for your review. @hvanhovell @beliefer @zhenlineo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43439:
URL: https://github.com/apache/spark/pull/43439#issuecomment-1772000954
A bit busy today, I'll check this PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
Posted by "zhaomin1423 (via GitHub)" <gi...@apache.org>.
zhaomin1423 commented on PR #43439:
URL: https://github.com/apache/spark/pull/43439#issuecomment-1779538121
> > > What I am confused about is, how should we check the effect after gc is triggered
> >
> >
> > Construct a case where `SparkResult` won't be manually closed, and check if after registering `cleanable`, `Cleaner.impl.phantomCleanableList` is not empty, but eventually `phantomCleanableList` is empty? This may require adding some code to get `phantomCleanableList` through reflection, just a suggestion, not sure if it's really feasible.
>
> Thanks, I will try it and if it doesn't work. I will verify manually by adding logs.
I did a manual test, there are two steps.
1. org.apache.spark.sql.connect.client.SparkResultCloseable#close add ```println("The resource of spark result closed.")```
```
override def close(): Unit = {
resultMap.values.foreach(_._2.foreach(_.close()))
responses.close()
// scalastyle:off println
println("The resource of spark result closed.")
}
```
2. start connect server and use example below to test. if ```The resource of spark result closed.``` can print to console, it can work well.
```
object ConnectClientTest {
def main(args: Array[String]): Unit = {
val spark = SparkSession.builder
.remote("sc://localhost:15002")
.getOrCreate()
var sparkResult = spark.range(0, 10, 1, 10)
.collectResult()
// scalastyle:off println
sparkResult = null
for (_ <- 0 until 10) {
System.gc()
Thread.sleep(100L)
}
spark.stop()
}
}
```
Test result:
```The resource of spark result closed.``` can print to console, so the org.apache.spark.sql.connect.client.SparkResultCloseable work well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #43439:
URL: https://github.com/apache/spark/pull/43439#issuecomment-1780291054
If you want to test this, then you have to force GC. Guava had some tricks for this: https://www.javadoc.io/doc/com.google.guava/guava-testlib/12.0/com/google/common/testing/GcFinalization.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43439:
URL: https://github.com/apache/spark/pull/43439#issuecomment-1769824909
also cc @zhenlineo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
Posted by "zhaomin1423 (via GitHub)" <gi...@apache.org>.
zhaomin1423 commented on PR #43439:
URL: https://github.com/apache/spark/pull/43439#issuecomment-1781419468
Thank you all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43439:
URL: https://github.com/apache/spark/pull/43439#issuecomment-1774019077
@zhaomin1423 If adding new tests is indeed difficult, do you have a manual way to confirm it is effective?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #43439:
URL: https://github.com/apache/spark/pull/43439#issuecomment-1780291442
BTW I am fine to merge this without a new test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
Posted by "zhenlineo (via GitHub)" <gi...@apache.org>.
zhenlineo commented on PR #43439:
URL: https://github.com/apache/spark/pull/43439#issuecomment-1771470011
@zhaomin1423 Yeah, the trick is to trigger a GC consistently. I was wondering if we can create some garbage memory to produce a GC. If it is too hard, we can go without a test for now. cc @hvanhovell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
Posted by "zhaomin1423 (via GitHub)" <gi...@apache.org>.
zhaomin1423 commented on PR #43439:
URL: https://github.com/apache/spark/pull/43439#issuecomment-1774103666
> > What I am confused about is, how should we check the effect after gc is triggered
>
> Construct a case where `SparkResult` won't be manually closed, and check if after registering `cleanable`, `Cleaner.impl.phantomCleanableList` is not empty, but eventually `phantomCleanableList` is empty? This may require adding some code to get `phantomCleanableList` through reflection, just a suggestion, not sure if it's really feasible.
Thanks, I will try it and if it doesn't work. I will verify manually by adding logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43439:
URL: https://github.com/apache/spark/pull/43439#issuecomment-1779604597
> > > > What I am confused about is, how should we check the effect after gc is triggered
> > >
> > >
> > > Construct a case where `SparkResult` won't be manually closed, and check if after registering `cleanable`, `Cleaner.impl.phantomCleanableList` is not empty, but eventually `phantomCleanableList` is empty? This may require adding some code to get `phantomCleanableList` through reflection, just a suggestion, not sure if it's really feasible.
> >
> >
> > Thanks, I will try it and if it doesn't work. I will verify manually by adding logs.
>
> I did a manual test, there are two steps.
>
> 1. org.apache.spark.sql.connect.client.SparkResultCloseable#close add `println("The resource of spark result closed.")`
>
> ```
> override def close(): Unit = {
> resultMap.values.foreach(_._2.foreach(_.close()))
> responses.close()
> // scalastyle:off println
> println("The resource of spark result closed.")
> }
> ```
>
> 2. start connect server and use example below to test. if `The resource of spark result closed.` can print to console, it can work well.
>
> ```
> object ConnectClientTest {
>
> def main(args: Array[String]): Unit = {
> val spark = SparkSession.builder
> .remote("sc://localhost:15002")
> .getOrCreate()
> var sparkResult = spark.range(0, 10, 1, 10)
> .collectResult()
> // scalastyle:off println
> sparkResult = null
> for (_ <- 0 until 10) {
> System.gc()
> Thread.sleep(100L)
> }
> spark.stop()
> }
> }
> ```
>
> Test result: `The resource of spark result closed.` can print to console, so the org.apache.spark.sql.connect.client.SparkResultCloseable work well.
Seems just a test issue, we can try to add `--add-opens=java.base/java.lang.ref=ALL-UNNAMED` to `extraJavaTestArgs` and `JavaModuleOptions`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
Posted by "zhaomin1423 (via GitHub)" <gi...@apache.org>.
zhaomin1423 commented on PR #43439:
URL: https://github.com/apache/spark/pull/43439#issuecomment-1772441750
> @zhaomin1423 Yeah, the trick is to trigger a GC consistently. I was wondering if we can create some garbage memory to produce a GC. If it is too hard, we can go without a test for now. cc @hvanhovell
What I am confused about is, how should we check the effect after gc is triggered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43439:
URL: https://github.com/apache/spark/pull/43439#issuecomment-1773007147
> What I am confused about is, how should we check the effect after gc is triggered
Construct a case where `SparkResult` won't be manually closed, and check if after registering `cleanable`, `Cleaner.impl.phantomCleanableList` is not empty, but eventually `phantomCleanableList` is empty? This may require adding some code to get `phantomCleanableList` through reflection, just a suggestion, not sure if it's really feasible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45596][CONNECT] Use java.lang.ref.Cleaner instead of org.apache.spark.sql.connect.client.util.Cleaner [spark]
Posted by "zhaomin1423 (via GitHub)" <gi...@apache.org>.
zhaomin1423 commented on PR #43439:
URL: https://github.com/apache/spark/pull/43439#issuecomment-1769822890
Could you help me review it? @zhli1142015 @hvanhovell , also cc @LuciferYang @mridulm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org