You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/06 10:27:03 UTC
[GitHub] [incubator-doris] acelyc111 opened a new pull request #4028: [shell] Fix BE unit test directory not match bug
acelyc111 opened a new pull request #4028:
URL: https://github.com/apache/incubator-doris/pull/4028
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 commented on pull request #4028: [shell] Fix BE unit test directory not match bug
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on pull request #4028:
URL: https://github.com/apache/incubator-doris/pull/4028#issuecomment-654150920
I introduced this bug by #3990 :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4028: [shell] Fix BE unit test directory not match bug
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4028:
URL: https://github.com/apache/incubator-doris/pull/4028
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4028: [shell] Fix BE unit test directory not match bug
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4028:
URL: https://github.com/apache/incubator-doris/pull/4028#discussion_r450694715
##########
File path: run-ut.sh
##########
@@ -105,7 +105,7 @@ echo " Running PaloBe Unittest "
echo "******************************"
cd ${DORIS_HOME}
-export DORIS_TEST_BINARY_DIR=${DORIS_HOME}/be/ut_build
+export DORIS_TEST_BINARY_DIR=${DORIS_HOME}/be/ut_build_${CMAKE_BUILD_TYPE}
Review comment:
```suggestion
export DORIS_TEST_BINARY_DIR=${CMAKE_BUILD_DIR}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #4028: [shell] Fix BE unit test directory not match bug
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #4028:
URL: https://github.com/apache/incubator-doris/pull/4028#issuecomment-655235433
I merged this PR so that following UT can run normally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org