You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2022/04/15 22:45:31 UTC
[GitHub] [samza] lakshmi-manasa-g opened a new pull request, #1597: SAMZA-2731: Add readAllCheckpoints to CheckpointManager and implement for KafkaCheckpointManager
lakshmi-manasa-g opened a new pull request, #1597:
URL: https://github.com/apache/samza/pull/1597
Improvement: add functionality in CheckpointManager to return the last recorded checkpoint for all tasks present in the checkpoint stream.
Changes:
1. Update CheckpointManager interface with new method “readAllCheckpoints” which returns an empty map
2. Implement “readAllCheckpoints” to return map of taskName to last recorded checkpoint for all task names present in the checkpoint kafka topic.
Tests: Added one test for readAllCheckpoints for KafkaCheckpointManager
API changes: Introduces new method in CheckpointManager public interface.
Upgrade instructions: None
Usage instructions: if implementing CheckpointManager then can either leave the readAllCheckpoints method untouched or override to read from the implementation-specific location to fetch all checkpoints and return last recorded for all tasks (incl those not in the current job model)
Backwards compatible: yes. Does not change any existing interface methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] rayman7718 merged pull request #1597: SAMZA-2731: Add readAllCheckpoints to CheckpointManager and implement for KafkaCheckpointManager
Posted by GitBox <gi...@apache.org>.
rayman7718 merged PR #1597:
URL: https://github.com/apache/samza/pull/1597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] rmatharu commented on pull request #1597: SAMZA-2731: Add readAllCheckpoints to CheckpointManager and implement for KafkaCheckpointManager
Posted by GitBox <gi...@apache.org>.
rmatharu commented on PR #1597:
URL: https://github.com/apache/samza/pull/1597#issuecomment-1108914134
Could we add a line in the description to say why we need this additional method (for other folks trying to understand this work),
ie., what problem this is trying to solve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] xiefan46 commented on pull request #1597: SAMZA-2731: Add readAllCheckpoints to CheckpointManager and implement for KafkaCheckpointManager
Posted by GitBox <gi...@apache.org>.
xiefan46 commented on PR #1597:
URL: https://github.com/apache/samza/pull/1597#issuecomment-1107949288
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org