You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/29 07:31:18 UTC

[GitHub] [flink-ml] lindong28 opened a new pull request #1: [Flink-21976] Move Flink ML pipeline API and library code from apache/flink to apache/flink-ml

lindong28 opened a new pull request #1:
URL: https://github.com/apache/flink-ml/pull/1


   ## What is the purpose of the change
   
   Move Flink ML pipeline API and library code from apache/flink to apache/flink-ml
   
   ## Brief change log
   
   - Move files under flink/flink-ml-parent to flink-ml repo
   - Add CODE_OF_CONDUCT.md, LICENSE and .gitignore
   - Add files needed for checkstyle under tools/maven
   - Update pom.xml to include plugins from apache/flink/pom.xml that are needed to build and release this flink-ml repo.
   
   ## Verifying this change
   
   1) This PR could run and pass all unit tests.
   2) Run `mvn install` in both `apache/flink-ml` and `apache/flink/flink-ml-parent` and verify that they generate the same set of files (e.g. *.pom files and *.jar files) at the same path under `~/.m2/repository/org/apache/flink/`
   3) `mvn install` generates `flink-ml-api-1.13-SNAPSHOT.jar`, `flink-ml-lib_2.11-1.13-SNAPSHOT.jar` and `flink-ml-uber_2.11-1.13-SNAPSHOT.jar`. I used IntellIj to compare the jar files with those jar files generated by `apache/flink/flink-ml-parent` and verified that they contains the same class files.
   
   The only difference in the jar files is that the jar file from this repo has NOTICE that says "Copyright 2019-2020 The Apache Software Foundation", whereas the jar file from apache/flink has NOTICE that says "Copyright 2014-2021 The Apache Software Foundation". That is not clear to me where that difference comes from. I believe this is not a blocking issue.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] becketqin merged pull request #1: [Flink-21976] Move Flink ML pipeline API and library code from apache/flink to apache/flink-ml

Posted by GitBox <gi...@apache.org>.
becketqin merged pull request #1:
URL: https://github.com/apache/flink-ml/pull/1


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] becketqin commented on pull request #1: [Flink-21976] Move Flink ML pipeline API and library code from apache/flink to apache/flink-ml

Posted by GitBox <gi...@apache.org>.
becketqin commented on pull request #1:
URL: https://github.com/apache/flink-ml/pull/1#issuecomment-809247359


   @lindong28 Thanks for the patch. Merged to master.
   08d058046f34b711128e0646ffbdc7e384c22064
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 commented on pull request #1: [Flink-21976] Move Flink ML pipeline API and library code from apache/flink to apache/flink-ml

Posted by GitBox <gi...@apache.org>.
lindong28 commented on pull request #1:
URL: https://github.com/apache/flink-ml/pull/1#issuecomment-809144123


   @becketqin Could you review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org