You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2020/04/17 16:08:53 UTC

[GitHub] [unomi] sergehuber opened a new pull request #147: UNOMI-300 Fix npm dependencies for web tracker

sergehuber opened a new pull request #147: UNOMI-300 Fix npm dependencies for web tracker
URL: https://github.com/apache/unomi/pull/147
 
 
   - Upgrade to analytics.js 3.10.1
   - Integrate Javascript compilation with Maven using frontend-maven-plugin
   - Fix integration to work with version 3.10.1
   - Cleanup of generated files

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [unomi] Taybou commented on a change in pull request #147: UNOMI-300 Fix npm dependencies for web tracker

Posted by GitBox <gi...@apache.org>.
Taybou commented on a change in pull request #147: UNOMI-300 Fix npm dependencies for web tracker
URL: https://github.com/apache/unomi/pull/147#discussion_r410672627
 
 

 ##########
 File path: extensions/web-tracker/javascript/src/analytics.js-integration-apache-unomi.js
 ##########
 @@ -19,23 +19,26 @@
 var integration = require('@segment/analytics.js-integration');
 var extend  = require('extend');
 
-var Unomi = module.exports = integration('Apache Unomi')
+var Unomi = (module.exports = integration('Apache Unomi')
 
 Review comment:
   ```suggestion
   var Unomi = module.exports = integration('Apache Unomi')
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [unomi] Taybou commented on a change in pull request #147: UNOMI-300 Fix npm dependencies for web tracker

Posted by GitBox <gi...@apache.org>.
Taybou commented on a change in pull request #147: UNOMI-300 Fix npm dependencies for web tracker
URL: https://github.com/apache/unomi/pull/147#discussion_r410672644
 
 

 ##########
 File path: extensions/web-tracker/javascript/src/analytics.js-integration-apache-unomi.js
 ##########
 @@ -19,23 +19,26 @@
 var integration = require('@segment/analytics.js-integration');
 var extend  = require('extend');
 
-var Unomi = module.exports = integration('Apache Unomi')
+var Unomi = (module.exports = integration('Apache Unomi')
+    .global('cxs')
     .assumesPageview()
     .readyOnLoad()
-    .global('cxs')
     .option('scope', 'systemscope')
     .option('url', 'http://localhost:8181')
     .option('timeoutInMilliseconds', 1500)
     .option('sessionCookieName', 'unomiSessionId')
-    .option('sessionId');
+    .option('sessionId'));
 
 Review comment:
   ```suggestion
       .option('sessionId');
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [unomi] sergehuber commented on a change in pull request #147: UNOMI-300 Fix npm dependencies for web tracker

Posted by GitBox <gi...@apache.org>.
sergehuber commented on a change in pull request #147: UNOMI-300 Fix npm dependencies for web tracker
URL: https://github.com/apache/unomi/pull/147#discussion_r410733763
 
 

 ##########
 File path: extensions/web-tracker/javascript/src/analytics.js-integration-apache-unomi.js
 ##########
 @@ -19,23 +19,26 @@
 var integration = require('@segment/analytics.js-integration');
 var extend  = require('extend');
 
-var Unomi = module.exports = integration('Apache Unomi')
+var Unomi = (module.exports = integration('Apache Unomi')
+    .global('cxs')
     .assumesPageview()
     .readyOnLoad()
-    .global('cxs')
     .option('scope', 'systemscope')
     .option('url', 'http://localhost:8181')
     .option('timeoutInMilliseconds', 1500)
     .option('sessionCookieName', 'unomiSessionId')
-    .option('sessionId');
+    .option('sessionId'));
 
 /**
  * Initialize.
  *
  * @api public
  */
-Unomi.prototype.initialize = function(page) {
+Unomi.prototype.initialize = function() {
     var self = this;
+
+    console.info('[UNOMI] Initializing...', arguments);
 
 Review comment:
   This is a standard built-in variables exposed by functions, see : https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/arguments

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [unomi] sergehuber commented on a change in pull request #147: UNOMI-300 Fix npm dependencies for web tracker

Posted by GitBox <gi...@apache.org>.
sergehuber commented on a change in pull request #147: UNOMI-300 Fix npm dependencies for web tracker
URL: https://github.com/apache/unomi/pull/147#discussion_r410733830
 
 

 ##########
 File path: extensions/web-tracker/javascript/src/analytics.js-integration-apache-unomi.js
 ##########
 @@ -19,23 +19,26 @@
 var integration = require('@segment/analytics.js-integration');
 var extend  = require('extend');
 
-var Unomi = module.exports = integration('Apache Unomi')
+var Unomi = (module.exports = integration('Apache Unomi')
 
 Review comment:
   This was done this way because all the other analytics.js integrations use this format.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [unomi] Taybou commented on a change in pull request #147: UNOMI-300 Fix npm dependencies for web tracker

Posted by GitBox <gi...@apache.org>.
Taybou commented on a change in pull request #147: UNOMI-300 Fix npm dependencies for web tracker
URL: https://github.com/apache/unomi/pull/147#discussion_r410672866
 
 

 ##########
 File path: extensions/web-tracker/javascript/src/analytics.js-integration-apache-unomi.js
 ##########
 @@ -19,23 +19,26 @@
 var integration = require('@segment/analytics.js-integration');
 var extend  = require('extend');
 
-var Unomi = module.exports = integration('Apache Unomi')
+var Unomi = (module.exports = integration('Apache Unomi')
+    .global('cxs')
     .assumesPageview()
     .readyOnLoad()
-    .global('cxs')
     .option('scope', 'systemscope')
     .option('url', 'http://localhost:8181')
     .option('timeoutInMilliseconds', 1500)
     .option('sessionCookieName', 'unomiSessionId')
-    .option('sessionId');
+    .option('sessionId'));
 
 /**
  * Initialize.
  *
  * @api public
  */
-Unomi.prototype.initialize = function(page) {
+Unomi.prototype.initialize = function() {
     var self = this;
+
+    console.info('[UNOMI] Initializing...', arguments);
 
 Review comment:
   where is the **`arguments`** variable declared? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services