You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "alejandrofm (via GitHub)" <gi...@apache.org> on 2023/02/02 15:22:39 UTC
[GitHub] [airflow] alejandrofm opened a new issue, #29323: DAG dependencies graph not updating when deleting a DAG
alejandrofm opened a new issue, #29323:
URL: https://github.com/apache/airflow/issues/29323
### Apache Airflow version
Other Airflow 2 version (please specify below)
### What happened
ON Airflow 2.4.2 Dag dependencies graph show deleted DAGs that use to have dependencies to currently existing DAGs
### What you think should happen instead
Deleted DAGs should not appear on DAG Dependencies
### How to reproduce
Create a DAG with dependencies on other DAG, like a wait sensor.
Remove new DAG
### Operating System
apache/airflow:2.4.2-python3.10
### Versions of Apache Airflow Providers
_No response_
### Deployment
Official Apache Airflow Helm Chart
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michaelmicheal commented on issue #29323: DAG dependencies graph not updating when deleting a DAG
Posted by "michaelmicheal (via GitHub)" <gi...@apache.org>.
michaelmicheal commented on issue #29323:
URL: https://github.com/apache/airflow/issues/29323#issuecomment-1421304640
Actually I was able to reproduce. I think that there is a bug in the deletion of serialized DAGs. Should be able to figure it out and come up with a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #29323: DAG dependencies graph not updating when deleting a DAG
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on issue #29323:
URL: https://github.com/apache/airflow/issues/29323#issuecomment-1414344653
We generate that graph based on `SerializedDagModel.get_dag_dependencies()`. I'm not too sure as to when that is updated after deleting a dag. Maybe someone with more knowledge on that side of things could chime in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alejandrofm commented on issue #29323: DAG dependencies graph not updating when deleting a DAG
Posted by "alejandrofm (via GitHub)" <gi...@apache.org>.
alejandrofm commented on issue #29323:
URL: https://github.com/apache/airflow/issues/29323#issuecomment-1421306780
Great, just to add the info:
We make the DAG changes on Gitlab and then retrieve the DAG folder via git-sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy closed issue #29323: DAG dependencies graph not updating when deleting a DAG
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy closed issue #29323: DAG dependencies graph not updating when deleting a DAG
URL: https://github.com/apache/airflow/issues/29323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michaelmicheal commented on issue #29323: DAG dependencies graph not updating when deleting a DAG
Posted by "michaelmicheal (via GitHub)" <gi...@apache.org>.
michaelmicheal commented on issue #29323:
URL: https://github.com/apache/airflow/issues/29323#issuecomment-1418443348
I think this related to not excluding disabled DAGs. Can you assign this to me? I'd like to tackle it this week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michaelmicheal commented on issue #29323: DAG dependencies graph not updating when deleting a DAG
Posted by "michaelmicheal (via GitHub)" <gi...@apache.org>.
michaelmicheal commented on issue #29323:
URL: https://github.com/apache/airflow/issues/29323#issuecomment-1420912246
I actually wasn't able to reproduce this behaviour. I didn't realize, but we started deleting serialized dags when removing stale DAGs here: https://github.com/apache/airflow/commit/f878854fff0f5bc577eab70c61e69e353aed43c3#diff-bde85feb359b12bdd358aed4106ef4fccbd8fa9915e16b9abb7502912a1c1ab3.
@alejandrofm How are you deleting the DAG? Removing it from the DAG bucket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org