You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by la...@apache.org on 2013/04/04 19:53:09 UTC
svn commit: r1464658 - in /hbase/tags/0.94.6.1: CHANGES.txt pom.xml
src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
Author: larsh
Date: Thu Apr 4 17:53:09 2013
New Revision: 1464658
URL: http://svn.apache.org/r1464658
Log:
HBASE-8259 Snapshot backport in 0.94.6 breaks rolling restarts (J-D) + CHANGES.txt and pom.xml
Modified:
hbase/tags/0.94.6.1/CHANGES.txt
hbase/tags/0.94.6.1/pom.xml
hbase/tags/0.94.6.1/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
Modified: hbase/tags/0.94.6.1/CHANGES.txt
URL: http://svn.apache.org/viewvc/hbase/tags/0.94.6.1/CHANGES.txt?rev=1464658&r1=1464657&r2=1464658&view=diff
==============================================================================
--- hbase/tags/0.94.6.1/CHANGES.txt (original)
+++ hbase/tags/0.94.6.1/CHANGES.txt Thu Apr 4 17:53:09 2013
@@ -1,5 +1,10 @@
HBase Change Log
+Release 0.94.6.1 - 4/4/2013
+Bug
+
+ [HBASE-8259] - Snapshot backport in 0.94.6 breaks rolling restarts
+
Release 0.94.6 - 3/14/2013
Sub-task
Modified: hbase/tags/0.94.6.1/pom.xml
URL: http://svn.apache.org/viewvc/hbase/tags/0.94.6.1/pom.xml?rev=1464658&r1=1464657&r2=1464658&view=diff
==============================================================================
--- hbase/tags/0.94.6.1/pom.xml (original)
+++ hbase/tags/0.94.6.1/pom.xml Thu Apr 4 17:53:09 2013
@@ -36,7 +36,7 @@
<groupId>org.apache.hbase</groupId>
<artifactId>hbase</artifactId>
<packaging>jar</packaging>
- <version>0.94.6</version>
+ <version>0.94.6.1</version>
<name>HBase</name>
<description>
HBase is the &lt;a href="http://hadoop.apache.org"&rt;Hadoop</a&rt; database. Use it when you need
Modified: hbase/tags/0.94.6.1/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
URL: http://svn.apache.org/viewvc/hbase/tags/0.94.6.1/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java?rev=1464658&r1=1464657&r2=1464658&view=diff
==============================================================================
--- hbase/tags/0.94.6.1/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java (original)
+++ hbase/tags/0.94.6.1/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java Thu Apr 4 17:53:09 2013
@@ -95,10 +95,10 @@ public abstract class EventHandler imple
* originated and then where its destined -- e.g. RS2ZK_ prefix means the
* event came from a regionserver destined for zookeeper -- and then what
* the even is; e.g. REGION_OPENING.
- *
- * <p>We give the enums indices so we can add types later and keep them
- * grouped together rather than have to add them always to the end as we
- * would have to if we used raw enum ordinals.
+ *
+ * <p>WARNING: Please do not insert, remove or swap any line in this enum
+ * Doing so would change or shift all the codes used to serialize
+ * events, which makes backwards compatibility very hard for clients.
*/
public enum EventType {
// Messages originating from RS (NOTE: there is NO direct communication from
@@ -128,8 +128,6 @@ public abstract class EventHandler imple
C_M_DELETE_FAMILY (45), // Client asking Master to delete family of table
C_M_MODIFY_FAMILY (46), // Client asking Master to modify family of table
C_M_CREATE_TABLE (47), // Client asking Master to create a table
- C_M_SNAPSHOT_TABLE (48), // Client asking Master to snapshot an offline table
- C_M_RESTORE_SNAPSHOT (49), // Client asking Master to snapshot an offline table
// Updates from master to ZK. This is done by the master and there is
// nothing to process by either Master or RS
@@ -138,7 +136,13 @@ public abstract class EventHandler imple
// Master controlled events to be executed on the master
M_SERVER_SHUTDOWN (70), // Master is processing shutdown of a RS
- M_META_SERVER_SHUTDOWN (72); // Master is processing shutdown of RS hosting a meta region (-ROOT- or .META.).
+ M_META_SERVER_SHUTDOWN (72), // Master is processing shutdown of RS hosting a meta region (-ROOT- or .META.).
+
+ // WARNING: Please do not insert, remove or swap any line in this enum.
+ // RegionTransitionData.write() uses eventType.ordinal() that is the enum index
+ // and not the value specified in the enum definition. so we can't add stuff in the middle.
+ C_M_SNAPSHOT_TABLE (48), // Client asking Master to snapshot an offline table
+ C_M_RESTORE_SNAPSHOT (49); // Client asking Master to snapshot an offline table
/**
* Constructor