[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #12113: feat: display suggestions when query has missing parameters

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #12113:
URL: https://github.com/apache/incubator-superset/pull/12113#discussion_r545960688



##########
File path: superset-frontend/src/components/ErrorMessage/ParameterErrorMessage.tsx
##########
@@ -32,17 +33,76 @@ interface ParameterErrorExtra {
   }[];
 }
 
-const triggerMessage = t('This may be triggered by:');
+const maxDistanceForSuggestion = 2;
+const findMatches = (
+  undefined_parameters: string[],

Review comment:
       Oh, yeah!
   
   I added these to the backend first as snake case, when I added to the frontend I forgot to switch to camel case. :-P




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org