You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Jochen Gazda <ga...@gmail.com> on 2012/02/22 08:21:04 UTC
ACL support plans
Gentlemen,
In the next weeks, I would like to proceed with
https://issues.apache.org/jira/browse/IMAP-358 Enforce rights required
to perform different IMAP4rev1 Commands in IMAP processors.
Just two questions:
(1) Is it still OK if I further work under apache-james-imap and not
under protocols-imap? Is there a rough estimate when will
apache-james-imap become obsolete?
(2) Tests: Is there a recommended way how to test the enforcement of
the individual rights in James?
I have written some tests for GETACL, SETACL, LISTRIGHTS, MYRIGHTS and
DELETERIGHTS in the apache-james-imap-processor project. All of them
are directed towards the respective processors. Could please somebody
review esp. the test*Right*() methods in them and tell me if it is
sufficient to test the security of other IMAP commands in this way?
Best,
gazda
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: ACL support plans
Posted by Eric Charles <er...@apache.org>.
Hi gazda,
I updated and tested trunk. It works fine so far with the minimal
scenarii I have run.
FetchGroupImpl and PartContentDescriptorImpl have now a nice home in
mailbox project. It's about queries and content after all, so not pure imap.
So (1), (2) and (3) are done
(4) let's leave for a few week the old source in svn, after we should
simply 'svn del' it (it can always been retrieved after if needed).
(5) is would be good if you could integrate the few imap pages in the
protocols web site - ping me if you want information on how to update
the web site - I will also write something today about this. The
reporting-site is more something used for the report generation
-> Felix can tell more about the report generation
(6) I will update the skin to remove the imap top menu
(7) For current site, there is still the imap top menu: for now you
could simply have a home page in the imap subsite that explains the code
have moved to protocols and that link to it.
(8) the mailbox-integration-tester
(https://svn.apache.org/repos/asf/james/mailbox-integration-tester/trunk) project
still uses the old imap, Would you arrange it uses the protocols-imap
(and that tests are successful) ?
Thx, Eric
On 04/17/2012 11:20 PM, Jochen Gazda wrote:
> Commited.
>
> Further points to consider before closing PROTOCOLS-73 :
>
> (4) How will we make the apache-james-imap code obsolete? Do we want
> to delete it altogether? Or just annotate somehow?
>
> (5) There is some site code under the following directories which does
> not seem to have any counterpart under protocols-imap:
>
> apache-james-imap/src/site
> apache-james-imap/src/reporting-site
> apache-james-imap-api/src/reporting-site
> apache-james-imap-message/src/reporting-site
> apache-james-imap-processor/src/reporting-site
>
> Best,
>
> gazda
>
> On Tue, Apr 17, 2012 at 5:18 PM, Eric Charles<er...@apache.org> wrote:
>> PS: Also take care to keep the SVN history when moving classes between
>> projects
>>
>> (I use eclipse which does a decent job for that, but I always pay double
>> attention doing those kind of operations).
>>
>>
>>
>> On 04/17/2012 05:09 PM, Eric Charles wrote:
>>>
>>> Hi Gazda,
>>>
>>> Thx for sharing the information.
>>>
>>> (1) and (2) are OK to me, I guess you had fun to find (3) :) (I guess to
>>> allow to avoid a dependency between james-server-mailets protocols-api?).
>>>
>>> Yes, just commit (we do CTR commit then review) assuming you have tested
>>> a complete build (app) with a real imap client (such as thunderbird)
>>> with a few mails (list mailbox, move mails, search,...).
>>>
>>> Maybe we could further talk and let evolve (3).
>>>
>>> Thx,
>>>
>>> Eric
>>>
>>>
>>> On 04/17/2012 04:48 PM, Jochen Gazda wrote:
>>>>
>>>> Eric,
>>>>
>>>> In my wokspace, I have:
>>>>
>>>> (1) changed the pom's in that way that that the protocols-imap code is
>>>> used instead of apache-james-imap.
>>>>
>>>> (2) merged apache-james-imap classes and tests into protocols-imap
>>>> classes and tests.
>>>>
>>>> (3) moved FetchGroupImpl and PartContentDescriptorImpl from
>>>> protocols-imap to mailbox-api to be able to remove the imap dependency
>>>> from james-server-mailets.
>>>>
>>>> To sum up, I have changes in the following projects:
>>>>
>>>> - apache-james
>>>> - apache-james-mailbox-api
>>>> - james-server
>>>> - james-server-mailets
>>>> - james-server-protocols-imap4
>>>> - protocols
>>>> - protocols-imap
>>>>
>>>> As the changes go over several projects, I needed to set the current
>>>> snapshots as dependendencies in some pom's.
>>>>
>>>> May I commit all my changes?
>>>>
>>>> Best,
>>>>
>>>> gazda
>>>>
>>>> On Fri, Mar 16, 2012 at 10:35 AM, Eric Charles<er...@apache.org> wrote:
>>>>>
>>>>> Hi Gazda,
>>>>>
>>>>> You have to remove in the server's project pom all references to
>>>>> apache-james-imap-* and replace them by the unique protocols-imap
>>>>> (same in
>>>>> app).
>>>>>
>>>>> Doing this, you will have a few compilation failures that should be
>>>>> easily
>>>>> solved by changing the package imports.
>>>>>
>>>>> You can commit for server project, but wait before committing the app
>>>>> project that the 3.0b4 release is done.
>>>>>
>>>>> Thx,
>>>>> Eric
>>>>>
>>>>>
>>>>> On 16/03/12 08:42, Jochen Gazda wrote:
>>>>>>
>>>>>>
>>>>>> Eric,
>>>>>>
>>>>>> I just wanted to merge the ACL code from apache-james-imap to
>>>>>> protocols-imap, but I am still seeing the default build& run to use
>>>>>>
>>>>>> the apache-james-imap code. Is there some simple way how I could tell
>>>>>> James to switch to the protocols-imap code?
>>>>>>
>>>>>> Thank you,
>>>>>>
>>>>>> gazda
>>>>>>
>>>>>> On Fri, Mar 9, 2012 at 2:14 PM, Eric Charles<er...@apache.org> wrote:
>>>>>>>
>>>>>>>
>>>>>>> (snip)
>>>>>>>
>>>>>>>> I have not started yet. I will have a look at the diffs between
>>>>>>>> protocols-imap and apache-james-imap in the next days and backport
>>>>>>>> all
>>>>>>>> the necessary stuff.
>>>>>>>>
>>>>>>>
>>>>>>> Cool!
>>>>>>>
>>>>>>>
>>>>>>>>> (2) Your tests use mocks and no concrete processor, I think this
>>>>>>>>> is the
>>>>>>>>> good
>>>>>>>>> way to do the unit tests in this case.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Hm... You say "no concrete processor"? Did you not want to say
>>>>>>>> something else? For every test in question, the particular processor
>>>>>>>> of the respective IMAP command IS actually being tested.
>>>>>>>> Perhaps you wanted to say "no concrete storage impementation"?
>>>>>>>>
>>>>>>>
>>>>>>> Oops, yes, I meant 'no concrete mailbox'.
>>>>>>>
>>>>>>>
>>>>>>>> Best,
>>>>>>>>
>>>>>>>> gazda
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>>>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> eric | http://about.echarles.net | @echarles
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>>>
>>>>>
>>>>> --
>>>>> eric | http://about.echarles.net | @echarles
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>
>>>
>>
>> --
>> eric | http://about.echarles.net | @echarles
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
--
eric | http://about.echarles.net | @echarles
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: ACL support plans
Posted by Eric Charles <er...@apache.org>.
Hi gazda,
I updated and tested trunk. It works fine so far with the minimal
scenarii I have run.
FetchGroupImpl and PartContentDescriptorImpl have now a nice home in
mailbox project. It's about queries and content after all, so not pure imap.
Great work!
So (1), (2) and (3) are done
(4) let's leave for a few week the old source in svn, after we should
simply 'svn del' it (it can always been retrieved after if needed).
(5) is would be good if you could integrate the few imap pages in the
protocols web site - ping me if you want information on how to update
the web site - I will also write something today about this. The
reporting-site is more something used for the report generation
-> Felix can tell more about the report generation
(6) I will update the skin to remove the imap top menu
(7) For current site, there is still the imap top menu: for now you
could simply have a home page in the imap subsite that explains the code
have moved to protocols and that link to it.
(8) the mailbox-integration-tester
(https://svn.apache.org/repos/asf/james/mailbox-integration-tester/trunk) project
still uses the old imap, Would you arrange it uses the protocols-imap
(and that tests are successful) ?
Thx, Eric
On 04/17/2012 11:20 PM, Jochen Gazda wrote:
> Commited.
>
> Further points to consider before closing PROTOCOLS-73 :
>
> (4) How will we make the apache-james-imap code obsolete? Do we want
> to delete it altogether? Or just annotate somehow?
>
> (5) There is some site code under the following directories which does
> not seem to have any counterpart under protocols-imap:
>
> apache-james-imap/src/site
> apache-james-imap/src/reporting-site
> apache-james-imap-api/src/reporting-site
> apache-james-imap-message/src/reporting-site
> apache-james-imap-processor/src/reporting-site
>
> Best,
>
> gazda
>
> On Tue, Apr 17, 2012 at 5:18 PM, Eric Charles<er...@apache.org> wrote:
>> PS: Also take care to keep the SVN history when moving classes between
>> projects
>>
>> (I use eclipse which does a decent job for that, but I always pay double
>> attention doing those kind of operations).
>>
>>
>>
>> On 04/17/2012 05:09 PM, Eric Charles wrote:
>>>
>>> Hi Gazda,
>>>
>>> Thx for sharing the information.
>>>
>>> (1) and (2) are OK to me, I guess you had fun to find (3) :) (I guess to
>>> allow to avoid a dependency between james-server-mailets protocols-api?).
>>>
>>> Yes, just commit (we do CTR commit then review) assuming you have tested
>>> a complete build (app) with a real imap client (such as thunderbird)
>>> with a few mails (list mailbox, move mails, search,...).
>>>
>>> Maybe we could further talk and let evolve (3).
>>>
>>> Thx,
>>>
>>> Eric
>>>
>>>
>>> On 04/17/2012 04:48 PM, Jochen Gazda wrote:
>>>>
>>>> Eric,
>>>>
>>>> In my wokspace, I have:
>>>>
>>>> (1) changed the pom's in that way that that the protocols-imap code is
>>>> used instead of apache-james-imap.
>>>>
>>>> (2) merged apache-james-imap classes and tests into protocols-imap
>>>> classes and tests.
>>>>
>>>> (3) moved FetchGroupImpl and PartContentDescriptorImpl from
>>>> protocols-imap to mailbox-api to be able to remove the imap dependency
>>>> from james-server-mailets.
>>>>
>>>> To sum up, I have changes in the following projects:
>>>>
>>>> - apache-james
>>>> - apache-james-mailbox-api
>>>> - james-server
>>>> - james-server-mailets
>>>> - james-server-protocols-imap4
>>>> - protocols
>>>> - protocols-imap
>>>>
>>>> As the changes go over several projects, I needed to set the current
>>>> snapshots as dependendencies in some pom's.
>>>>
>>>> May I commit all my changes?
>>>>
>>>> Best,
>>>>
>>>> gazda
>>>>
>>>> On Fri, Mar 16, 2012 at 10:35 AM, Eric Charles<er...@apache.org> wrote:
>>>>>
>>>>> Hi Gazda,
>>>>>
>>>>> You have to remove in the server's project pom all references to
>>>>> apache-james-imap-* and replace them by the unique protocols-imap
>>>>> (same in
>>>>> app).
>>>>>
>>>>> Doing this, you will have a few compilation failures that should be
>>>>> easily
>>>>> solved by changing the package imports.
>>>>>
>>>>> You can commit for server project, but wait before committing the app
>>>>> project that the 3.0b4 release is done.
>>>>>
>>>>> Thx,
>>>>> Eric
>>>>>
>>>>>
>>>>> On 16/03/12 08:42, Jochen Gazda wrote:
>>>>>>
>>>>>>
>>>>>> Eric,
>>>>>>
>>>>>> I just wanted to merge the ACL code from apache-james-imap to
>>>>>> protocols-imap, but I am still seeing the default build& run to use
>>>>>>
>>>>>> the apache-james-imap code. Is there some simple way how I could tell
>>>>>> James to switch to the protocols-imap code?
>>>>>>
>>>>>> Thank you,
>>>>>>
>>>>>> gazda
>>>>>>
>>>>>> On Fri, Mar 9, 2012 at 2:14 PM, Eric Charles<er...@apache.org> wrote:
>>>>>>>
>>>>>>>
>>>>>>> (snip)
>>>>>>>
>>>>>>>> I have not started yet. I will have a look at the diffs between
>>>>>>>> protocols-imap and apache-james-imap in the next days and backport
>>>>>>>> all
>>>>>>>> the necessary stuff.
>>>>>>>>
>>>>>>>
>>>>>>> Cool!
>>>>>>>
>>>>>>>
>>>>>>>>> (2) Your tests use mocks and no concrete processor, I think this
>>>>>>>>> is the
>>>>>>>>> good
>>>>>>>>> way to do the unit tests in this case.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Hm... You say "no concrete processor"? Did you not want to say
>>>>>>>> something else? For every test in question, the particular processor
>>>>>>>> of the respective IMAP command IS actually being tested.
>>>>>>>> Perhaps you wanted to say "no concrete storage impementation"?
>>>>>>>>
>>>>>>>
>>>>>>> Oops, yes, I meant 'no concrete mailbox'.
>>>>>>>
>>>>>>>
>>>>>>>> Best,
>>>>>>>>
>>>>>>>> gazda
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>>>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> eric | http://about.echarles.net | @echarles
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>>>
>>>>>
>>>>> --
>>>>> eric | http://about.echarles.net | @echarles
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>
>>>
>>
>> --
>> eric | http://about.echarles.net | @echarles
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
--
eric | http://about.echarles.net | @echarles
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: ACL support plans
Posted by Jochen Gazda <ga...@gmail.com>.
Commited.
Further points to consider before closing PROTOCOLS-73 :
(4) How will we make the apache-james-imap code obsolete? Do we want
to delete it altogether? Or just annotate somehow?
(5) There is some site code under the following directories which does
not seem to have any counterpart under protocols-imap:
apache-james-imap/src/site
apache-james-imap/src/reporting-site
apache-james-imap-api/src/reporting-site
apache-james-imap-message/src/reporting-site
apache-james-imap-processor/src/reporting-site
Best,
gazda
On Tue, Apr 17, 2012 at 5:18 PM, Eric Charles <er...@apache.org> wrote:
> PS: Also take care to keep the SVN history when moving classes between
> projects
>
> (I use eclipse which does a decent job for that, but I always pay double
> attention doing those kind of operations).
>
>
>
> On 04/17/2012 05:09 PM, Eric Charles wrote:
>>
>> Hi Gazda,
>>
>> Thx for sharing the information.
>>
>> (1) and (2) are OK to me, I guess you had fun to find (3) :) (I guess to
>> allow to avoid a dependency between james-server-mailets protocols-api?).
>>
>> Yes, just commit (we do CTR commit then review) assuming you have tested
>> a complete build (app) with a real imap client (such as thunderbird)
>> with a few mails (list mailbox, move mails, search,...).
>>
>> Maybe we could further talk and let evolve (3).
>>
>> Thx,
>>
>> Eric
>>
>>
>> On 04/17/2012 04:48 PM, Jochen Gazda wrote:
>>>
>>> Eric,
>>>
>>> In my wokspace, I have:
>>>
>>> (1) changed the pom's in that way that that the protocols-imap code is
>>> used instead of apache-james-imap.
>>>
>>> (2) merged apache-james-imap classes and tests into protocols-imap
>>> classes and tests.
>>>
>>> (3) moved FetchGroupImpl and PartContentDescriptorImpl from
>>> protocols-imap to mailbox-api to be able to remove the imap dependency
>>> from james-server-mailets.
>>>
>>> To sum up, I have changes in the following projects:
>>>
>>> - apache-james
>>> - apache-james-mailbox-api
>>> - james-server
>>> - james-server-mailets
>>> - james-server-protocols-imap4
>>> - protocols
>>> - protocols-imap
>>>
>>> As the changes go over several projects, I needed to set the current
>>> snapshots as dependendencies in some pom's.
>>>
>>> May I commit all my changes?
>>>
>>> Best,
>>>
>>> gazda
>>>
>>> On Fri, Mar 16, 2012 at 10:35 AM, Eric Charles<er...@apache.org> wrote:
>>>>
>>>> Hi Gazda,
>>>>
>>>> You have to remove in the server's project pom all references to
>>>> apache-james-imap-* and replace them by the unique protocols-imap
>>>> (same in
>>>> app).
>>>>
>>>> Doing this, you will have a few compilation failures that should be
>>>> easily
>>>> solved by changing the package imports.
>>>>
>>>> You can commit for server project, but wait before committing the app
>>>> project that the 3.0b4 release is done.
>>>>
>>>> Thx,
>>>> Eric
>>>>
>>>>
>>>> On 16/03/12 08:42, Jochen Gazda wrote:
>>>>>
>>>>>
>>>>> Eric,
>>>>>
>>>>> I just wanted to merge the ACL code from apache-james-imap to
>>>>> protocols-imap, but I am still seeing the default build& run to use
>>>>>
>>>>> the apache-james-imap code. Is there some simple way how I could tell
>>>>> James to switch to the protocols-imap code?
>>>>>
>>>>> Thank you,
>>>>>
>>>>> gazda
>>>>>
>>>>> On Fri, Mar 9, 2012 at 2:14 PM, Eric Charles<er...@apache.org> wrote:
>>>>>>
>>>>>>
>>>>>> (snip)
>>>>>>
>>>>>>> I have not started yet. I will have a look at the diffs between
>>>>>>> protocols-imap and apache-james-imap in the next days and backport
>>>>>>> all
>>>>>>> the necessary stuff.
>>>>>>>
>>>>>>
>>>>>> Cool!
>>>>>>
>>>>>>
>>>>>>>> (2) Your tests use mocks and no concrete processor, I think this
>>>>>>>> is the
>>>>>>>> good
>>>>>>>> way to do the unit tests in this case.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Hm... You say "no concrete processor"? Did you not want to say
>>>>>>> something else? For every test in question, the particular processor
>>>>>>> of the respective IMAP command IS actually being tested.
>>>>>>> Perhaps you wanted to say "no concrete storage impementation"?
>>>>>>>
>>>>>>
>>>>>> Oops, yes, I meant 'no concrete mailbox'.
>>>>>>
>>>>>>
>>>>>>> Best,
>>>>>>>
>>>>>>> gazda
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>>>>
>>>>>>
>>>>>> --
>>>>>> eric | http://about.echarles.net | @echarles
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>>
>>>>
>>>> --
>>>> eric | http://about.echarles.net | @echarles
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>
>>
>
> --
> eric | http://about.echarles.net | @echarles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: ACL support plans
Posted by Eric Charles <er...@apache.org>.
PS: Also take care to keep the SVN history when moving classes between
projects
(I use eclipse which does a decent job for that, but I always pay double
attention doing those kind of operations).
On 04/17/2012 05:09 PM, Eric Charles wrote:
> Hi Gazda,
>
> Thx for sharing the information.
>
> (1) and (2) are OK to me, I guess you had fun to find (3) :) (I guess to
> allow to avoid a dependency between james-server-mailets protocols-api?).
>
> Yes, just commit (we do CTR commit then review) assuming you have tested
> a complete build (app) with a real imap client (such as thunderbird)
> with a few mails (list mailbox, move mails, search,...).
>
> Maybe we could further talk and let evolve (3).
>
> Thx,
>
> Eric
>
>
> On 04/17/2012 04:48 PM, Jochen Gazda wrote:
>> Eric,
>>
>> In my wokspace, I have:
>>
>> (1) changed the pom's in that way that that the protocols-imap code is
>> used instead of apache-james-imap.
>>
>> (2) merged apache-james-imap classes and tests into protocols-imap
>> classes and tests.
>>
>> (3) moved FetchGroupImpl and PartContentDescriptorImpl from
>> protocols-imap to mailbox-api to be able to remove the imap dependency
>> from james-server-mailets.
>>
>> To sum up, I have changes in the following projects:
>>
>> - apache-james
>> - apache-james-mailbox-api
>> - james-server
>> - james-server-mailets
>> - james-server-protocols-imap4
>> - protocols
>> - protocols-imap
>>
>> As the changes go over several projects, I needed to set the current
>> snapshots as dependendencies in some pom's.
>>
>> May I commit all my changes?
>>
>> Best,
>>
>> gazda
>>
>> On Fri, Mar 16, 2012 at 10:35 AM, Eric Charles<er...@apache.org> wrote:
>>> Hi Gazda,
>>>
>>> You have to remove in the server's project pom all references to
>>> apache-james-imap-* and replace them by the unique protocols-imap
>>> (same in
>>> app).
>>>
>>> Doing this, you will have a few compilation failures that should be
>>> easily
>>> solved by changing the package imports.
>>>
>>> You can commit for server project, but wait before committing the app
>>> project that the 3.0b4 release is done.
>>>
>>> Thx,
>>> Eric
>>>
>>>
>>> On 16/03/12 08:42, Jochen Gazda wrote:
>>>>
>>>> Eric,
>>>>
>>>> I just wanted to merge the ACL code from apache-james-imap to
>>>> protocols-imap, but I am still seeing the default build& run to use
>>>>
>>>> the apache-james-imap code. Is there some simple way how I could tell
>>>> James to switch to the protocols-imap code?
>>>>
>>>> Thank you,
>>>>
>>>> gazda
>>>>
>>>> On Fri, Mar 9, 2012 at 2:14 PM, Eric Charles<er...@apache.org> wrote:
>>>>>
>>>>> (snip)
>>>>>
>>>>>> I have not started yet. I will have a look at the diffs between
>>>>>> protocols-imap and apache-james-imap in the next days and backport
>>>>>> all
>>>>>> the necessary stuff.
>>>>>>
>>>>>
>>>>> Cool!
>>>>>
>>>>>
>>>>>>> (2) Your tests use mocks and no concrete processor, I think this
>>>>>>> is the
>>>>>>> good
>>>>>>> way to do the unit tests in this case.
>>>>>>
>>>>>>
>>>>>>
>>>>>> Hm... You say "no concrete processor"? Did you not want to say
>>>>>> something else? For every test in question, the particular processor
>>>>>> of the respective IMAP command IS actually being tested.
>>>>>> Perhaps you wanted to say "no concrete storage impementation"?
>>>>>>
>>>>>
>>>>> Oops, yes, I meant 'no concrete mailbox'.
>>>>>
>>>>>
>>>>>> Best,
>>>>>>
>>>>>> gazda
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>>>
>>>>>
>>>>> --
>>>>> eric | http://about.echarles.net | @echarles
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>
>>>
>>> --
>>> eric | http://about.echarles.net | @echarles
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>
--
eric | http://about.echarles.net | @echarles
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: ACL support plans
Posted by Eric Charles <er...@apache.org>.
Hi Gazda,
Thx for sharing the information.
(1) and (2) are OK to me, I guess you had fun to find (3) :) (I guess
to allow to avoid a dependency between james-server-mailets protocols-api?).
Yes, just commit (we do CTR commit then review) assuming you have tested
a complete build (app) with a real imap client (such as thunderbird)
with a few mails (list mailbox, move mails, search,...).
Maybe we could further talk and let evolve (3).
Thx,
Eric
On 04/17/2012 04:48 PM, Jochen Gazda wrote:
> Eric,
>
> In my wokspace, I have:
>
> (1) changed the pom's in that way that that the protocols-imap code is
> used instead of apache-james-imap.
>
> (2) merged apache-james-imap classes and tests into protocols-imap
> classes and tests.
>
> (3) moved FetchGroupImpl and PartContentDescriptorImpl from
> protocols-imap to mailbox-api to be able to remove the imap dependency
> from james-server-mailets.
>
> To sum up, I have changes in the following projects:
>
> - apache-james
> - apache-james-mailbox-api
> - james-server
> - james-server-mailets
> - james-server-protocols-imap4
> - protocols
> - protocols-imap
>
> As the changes go over several projects, I needed to set the current
> snapshots as dependendencies in some pom's.
>
> May I commit all my changes?
>
> Best,
>
> gazda
>
> On Fri, Mar 16, 2012 at 10:35 AM, Eric Charles<er...@apache.org> wrote:
>> Hi Gazda,
>>
>> You have to remove in the server's project pom all references to
>> apache-james-imap-* and replace them by the unique protocols-imap (same in
>> app).
>>
>> Doing this, you will have a few compilation failures that should be easily
>> solved by changing the package imports.
>>
>> You can commit for server project, but wait before committing the app
>> project that the 3.0b4 release is done.
>>
>> Thx,
>> Eric
>>
>>
>> On 16/03/12 08:42, Jochen Gazda wrote:
>>>
>>> Eric,
>>>
>>> I just wanted to merge the ACL code from apache-james-imap to
>>> protocols-imap, but I am still seeing the default build& run to use
>>>
>>> the apache-james-imap code. Is there some simple way how I could tell
>>> James to switch to the protocols-imap code?
>>>
>>> Thank you,
>>>
>>> gazda
>>>
>>> On Fri, Mar 9, 2012 at 2:14 PM, Eric Charles<er...@apache.org> wrote:
>>>>
>>>> (snip)
>>>>
>>>>> I have not started yet. I will have a look at the diffs between
>>>>> protocols-imap and apache-james-imap in the next days and backport all
>>>>> the necessary stuff.
>>>>>
>>>>
>>>> Cool!
>>>>
>>>>
>>>>>> (2) Your tests use mocks and no concrete processor, I think this is the
>>>>>> good
>>>>>> way to do the unit tests in this case.
>>>>>
>>>>>
>>>>>
>>>>> Hm... You say "no concrete processor"? Did you not want to say
>>>>> something else? For every test in question, the particular processor
>>>>> of the respective IMAP command IS actually being tested.
>>>>> Perhaps you wanted to say "no concrete storage impementation"?
>>>>>
>>>>
>>>> Oops, yes, I meant 'no concrete mailbox'.
>>>>
>>>>
>>>>> Best,
>>>>>
>>>>> gazda
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>>
>>>>
>>>> --
>>>> eric | http://about.echarles.net | @echarles
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>
>>
>> --
>> eric | http://about.echarles.net | @echarles
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
--
eric | http://about.echarles.net | @echarles
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: ACL support plans
Posted by Jochen Gazda <ga...@gmail.com>.
Eric,
In my wokspace, I have:
(1) changed the pom's in that way that that the protocols-imap code is
used instead of apache-james-imap.
(2) merged apache-james-imap classes and tests into protocols-imap
classes and tests.
(3) moved FetchGroupImpl and PartContentDescriptorImpl from
protocols-imap to mailbox-api to be able to remove the imap dependency
from james-server-mailets.
To sum up, I have changes in the following projects:
- apache-james
- apache-james-mailbox-api
- james-server
- james-server-mailets
- james-server-protocols-imap4
- protocols
- protocols-imap
As the changes go over several projects, I needed to set the current
snapshots as dependendencies in some pom's.
May I commit all my changes?
Best,
gazda
On Fri, Mar 16, 2012 at 10:35 AM, Eric Charles <er...@apache.org> wrote:
> Hi Gazda,
>
> You have to remove in the server's project pom all references to
> apache-james-imap-* and replace them by the unique protocols-imap (same in
> app).
>
> Doing this, you will have a few compilation failures that should be easily
> solved by changing the package imports.
>
> You can commit for server project, but wait before committing the app
> project that the 3.0b4 release is done.
>
> Thx,
> Eric
>
>
> On 16/03/12 08:42, Jochen Gazda wrote:
>>
>> Eric,
>>
>> I just wanted to merge the ACL code from apache-james-imap to
>> protocols-imap, but I am still seeing the default build& run to use
>>
>> the apache-james-imap code. Is there some simple way how I could tell
>> James to switch to the protocols-imap code?
>>
>> Thank you,
>>
>> gazda
>>
>> On Fri, Mar 9, 2012 at 2:14 PM, Eric Charles<er...@apache.org> wrote:
>>>
>>> (snip)
>>>
>>>> I have not started yet. I will have a look at the diffs between
>>>> protocols-imap and apache-james-imap in the next days and backport all
>>>> the necessary stuff.
>>>>
>>>
>>> Cool!
>>>
>>>
>>>>> (2) Your tests use mocks and no concrete processor, I think this is the
>>>>> good
>>>>> way to do the unit tests in this case.
>>>>
>>>>
>>>>
>>>> Hm... You say "no concrete processor"? Did you not want to say
>>>> something else? For every test in question, the particular processor
>>>> of the respective IMAP command IS actually being tested.
>>>> Perhaps you wanted to say "no concrete storage impementation"?
>>>>
>>>
>>> Oops, yes, I meant 'no concrete mailbox'.
>>>
>>>
>>>> Best,
>>>>
>>>> gazda
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>>
>>>
>>> --
>>> eric | http://about.echarles.net | @echarles
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>
> --
> eric | http://about.echarles.net | @echarles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: ACL support plans
Posted by Eric Charles <er...@apache.org>.
Hi Gazda,
You have to remove in the server's project pom all references to
apache-james-imap-* and replace them by the unique protocols-imap (same
in app).
Doing this, you will have a few compilation failures that should be
easily solved by changing the package imports.
You can commit for server project, but wait before committing the app
project that the 3.0b4 release is done.
Thx,
Eric
On 16/03/12 08:42, Jochen Gazda wrote:
> Eric,
>
> I just wanted to merge the ACL code from apache-james-imap to
> protocols-imap, but I am still seeing the default build& run to use
> the apache-james-imap code. Is there some simple way how I could tell
> James to switch to the protocols-imap code?
>
> Thank you,
>
> gazda
>
> On Fri, Mar 9, 2012 at 2:14 PM, Eric Charles<er...@apache.org> wrote:
>> (snip)
>>
>>> I have not started yet. I will have a look at the diffs between
>>> protocols-imap and apache-james-imap in the next days and backport all
>>> the necessary stuff.
>>>
>>
>> Cool!
>>
>>
>>>> (2) Your tests use mocks and no concrete processor, I think this is the
>>>> good
>>>> way to do the unit tests in this case.
>>>
>>>
>>> Hm... You say "no concrete processor"? Did you not want to say
>>> something else? For every test in question, the particular processor
>>> of the respective IMAP command IS actually being tested.
>>> Perhaps you wanted to say "no concrete storage impementation"?
>>>
>>
>> Oops, yes, I meant 'no concrete mailbox'.
>>
>>
>>> Best,
>>>
>>> gazda
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>>> For additional commands, e-mail: server-dev-help@james.apache.org
>>>
>>
>> --
>> eric | http://about.echarles.net | @echarles
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
--
eric | http://about.echarles.net | @echarles
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: ACL support plans
Posted by Jochen Gazda <ga...@gmail.com>.
Eric,
I just wanted to merge the ACL code from apache-james-imap to
protocols-imap, but I am still seeing the default build & run to use
the apache-james-imap code. Is there some simple way how I could tell
James to switch to the protocols-imap code?
Thank you,
gazda
On Fri, Mar 9, 2012 at 2:14 PM, Eric Charles <er...@apache.org> wrote:
> (snip)
>
>> I have not started yet. I will have a look at the diffs between
>> protocols-imap and apache-james-imap in the next days and backport all
>> the necessary stuff.
>>
>
> Cool!
>
>
>>> (2) Your tests use mocks and no concrete processor, I think this is the
>>> good
>>> way to do the unit tests in this case.
>>
>>
>> Hm... You say "no concrete processor"? Did you not want to say
>> something else? For every test in question, the particular processor
>> of the respective IMAP command IS actually being tested.
>> Perhaps you wanted to say "no concrete storage impementation"?
>>
>
> Oops, yes, I meant 'no concrete mailbox'.
>
>
>> Best,
>>
>> gazda
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
>> For additional commands, e-mail: server-dev-help@james.apache.org
>>
>
> --
> eric | http://about.echarles.net | @echarles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: ACL support plans
Posted by Eric Charles <er...@apache.org>.
(snip)
> I have not started yet. I will have a look at the diffs between
> protocols-imap and apache-james-imap in the next days and backport all
> the necessary stuff.
>
Cool!
>> (2) Your tests use mocks and no concrete processor, I think this is the good
>> way to do the unit tests in this case.
>
> Hm... You say "no concrete processor"? Did you not want to say
> something else? For every test in question, the particular processor
> of the respective IMAP command IS actually being tested.
> Perhaps you wanted to say "no concrete storage impementation"?
>
Oops, yes, I meant 'no concrete mailbox'.
> Best,
>
> gazda
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
--
eric | http://about.echarles.net | @echarles
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: ACL support plans
Posted by Jochen Gazda <ga...@gmail.com>.
Eric,
please see inline.
> (1) I would love to see the current activity in protocols-imap. I had to
> postpone my contribution on the integration (b4 release and many other
> stuff), but next week should be a good week for me to work on this. I
> propose you continue your implementations in protocols-imap (hoping you
> don't have to backport too much from apache-james-imap such as the tests,
> and hoping also we can work together on the same codebase, on my side more
> regarding the integration of the processors in the protocol handler chain).
I have not started yet. I will have a look at the diffs between
protocols-imap and apache-james-imap in the next days and backport all
the necessary stuff.
> (2) Your tests use mocks and no concrete processor, I think this is the good
> way to do the unit tests in this case.
Hm... You say "no concrete processor"? Did you not want to say
something else? For every test in question, the particular processor
of the respective IMAP command IS actually being tested.
Perhaps you wanted to say "no concrete storage impementation"?
Best,
gazda
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: ACL support plans
Posted by Eric Charles <er...@apache.org>.
Hi Gazda,
First of all, thx for pushing this!
(1) I would love to see the current activity in protocols-imap. I had to
postpone my contribution on the integration (b4 release and many other
stuff), but next week should be a good week for me to work on this. I
propose you continue your implementations in protocols-imap (hoping you
don't have to backport too much from apache-james-imap such as the
tests, and hoping also we can work together on the same codebase, on my
side more regarding the integration of the processors in the protocol
handler chain).
(2) Your tests use mocks and no concrete processor, I think this is the
good way to do the unit tests in this case.
Thx,
Eric
On 09/03/12 12:27, Jochen Gazda wrote:
> Gentlemen,
>
> just reposting my old questions.
> I would like to proceed with
> https://issues.apache.org/jira/browse/IMAP-358 Enforce rights required
> to perform different IMAP4rev1 Commands in IMAP processors.
>
> (1) Is there something new with protocols-imap vs. apache-james-imap?
>
> (2) Tests: Is there a recommended way how to test the enforcement of
> the individual rights in James?
> I have written some tests for GETACL, SETACL, LISTRIGHTS, MYRIGHTS and
> DELETERIGHTS in the apache-james-imap-processor project. All of them
> are directed towards the respective processors. Could please somebody
> review esp. the test*Right*() methods in them and tell me if it is
> sufficient to test the security of other IMAP commands in this way?
>
> Best,
>
> gazda
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
--
eric | http://about.echarles.net | @echarles
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: ACL support plans
Posted by Jochen Gazda <ga...@gmail.com>.
Gentlemen,
just reposting my old questions.
I would like to proceed with
https://issues.apache.org/jira/browse/IMAP-358 Enforce rights required
to perform different IMAP4rev1 Commands in IMAP processors.
(1) Is there something new with protocols-imap vs. apache-james-imap?
(2) Tests: Is there a recommended way how to test the enforcement of
the individual rights in James?
I have written some tests for GETACL, SETACL, LISTRIGHTS, MYRIGHTS and
DELETERIGHTS in the apache-james-imap-processor project. All of them
are directed towards the respective processors. Could please somebody
review esp. the test*Right*() methods in them and tell me if it is
sufficient to test the security of other IMAP commands in this way?
Best,
gazda
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: ACL support plans
Posted by Eric Charles <er...@apache.org>.
Hi,
Quick note (no time atm for an answer on your questions, and your
planning one is quite dangerous :) : Norman has started the imap port
into protocols, and I may next week help with that - the server b4
release (end of next week) will be with apache-james-imap, but the next
one with protocols-imap.
Thx,
Eric
On 22/02/12 08:21, Jochen Gazda wrote:
> Gentlemen,
>
> In the next weeks, I would like to proceed with
> https://issues.apache.org/jira/browse/IMAP-358 Enforce rights required
> to perform different IMAP4rev1 Commands in IMAP processors.
> Just two questions:
>
> (1) Is it still OK if I further work under apache-james-imap and not
> under protocols-imap? Is there a rough estimate when will
> apache-james-imap become obsolete?
>
> (2) Tests: Is there a recommended way how to test the enforcement of
> the individual rights in James?
> I have written some tests for GETACL, SETACL, LISTRIGHTS, MYRIGHTS and
> DELETERIGHTS in the apache-james-imap-processor project. All of them
> are directed towards the respective processors. Could please somebody
> review esp. the test*Right*() methods in them and tell me if it is
> sufficient to test the security of other IMAP commands in this way?
>
> Best,
>
> gazda
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
--
eric | http://about.echarles.net | @echarles
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org