[GitHub] [httpcomponents-client] garydgregory commented on issue #190: [HTTPCLIENT-2042] AuthScope uses uppercase for scheme name whereas th…

[GitBox <gi...@apache.org>]

garydgregory commented on issue #190: [HTTPCLIENT-2042] AuthScope uses uppercase for scheme name whereas th…
URL: https://github.com/apache/httpcomponents-client/pull/190#issuecomment-569449884
 
 
   Should we not keep the auth scheme strings to the two styles we already have? IOW:
   - The upper case names as the enum names in org.apache.hc.client5.http.auth.AuthSchemes: BASIC, DIGEST, and so on.
   - The mixed case names as the 'ident' field of org.apache.hc.client5.http.auth.AuthSchemes: "Basic", "Digest", and so on.
   
   Question... I see we have these 2 ctors:
   - org.apache.hc.client5.http.auth.AuthScope.AuthScope(HttpHost, String, String)
   - org.apache.hc.client5.http.auth.AuthScope.AuthScope(String, String, int, String, String)
   These both take a schemeName. 
   Why not avoid confusion and type this as an AuthScheme? Or both?
   This goes back to the email thread about how extenstible AuthScheme(s) are suppose to be. 
   This needs clarification before we continue IMO.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org