You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by Wesley-Lawrence <gi...@git.apache.org> on 2016/12/09 00:02:46 UTC
[GitHub] nifi pull request #1311: NIFI-3175 Fix a bug in the ValidateCSV processor to...
GitHub user Wesley-Lawrence opened a pull request:
https://github.com/apache/nifi/pull/1311
NIFI-3175 Fix a bug in the ValidateCSV processor to handle empty CSV columns
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ Y ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ Y ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ Y ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ Y ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ Y ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ Y ] Have you written or updated unit tests to verify your changes?
- [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [N/A] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [N/A] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [N/A] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [N/A] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Wesley-Lawrence/nifi NIFI-3175
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1311.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1311
----
commit 4a9128d3ccc0844402b09bda2295d959b7cbab62
Author: Wesley-Lawrence <wl...@filetrek.com>
Date: 2016-12-08T23:32:34Z
NIFI-3175 Fix a bug in the ValidateCSV processor to handle empty CSV columns
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1311: NIFI-3175 Fix a bug in the ValidateCSV processor to handle...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1311
@Wesley-Lawrence You're right, the appveyor failure is not related. Just reviewed your PR, and it LGTM: reproduced the error, confirmed the fix, contrib-check. All good! Thanks for the contribution, will merge!
Note for tracking purpose in JIRA: the bug appeared in line by line validation mode.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1311: NIFI-3175 Fix a bug in the ValidateCSV processor to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1311
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1311: NIFI-3175 Fix a bug in the ValidateCSV processor to handle...
Posted by Wesley-Lawrence <gi...@git.apache.org>.
Github user Wesley-Lawrence commented on the issue:
https://github.com/apache/nifi/pull/1311
I think the appveyor fail is unrelated?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---