[GitHub] [incubator-pinot] npawar commented on a change in pull request #6664: Add an option to fail segment creation job when getting empty files

[GitBox <gi...@apache.org>]

npawar commented on a change in pull request #6664:
URL: https://github.com/apache/incubator-pinot/pull/6664#discussion_r591785586



##########
File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/CreateSegmentCommand.java
##########
@@ -76,6 +76,9 @@
   @Option(name = "-retry", metaVar = "<int>", usage = "Number of retries if encountered any segment creation failure, default is 0.")
   private int _retry = 0;
 
+  @Option(name = "-failOnEmptySegment", usage = "Option to fail the segment creation if output is an empty segment.")

Review comment:
       we dont use this Command anymore right? We use the IngestionJobLauncher. You'll have to add it to one of the specs in the batchJobSpec, and also all the implementations of IngestionJobRunner




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org