You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ruslan Ostafiychuk <ro...@hortonworks.com> on 2014/11/27 13:15:31 UTC
Review Request 28515: Use APIResult and other support classes from
falcon-client in falcon-regression
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28515/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-699
https://issues.apache.org/jira/browse/FALCON-699
Repository: falcon-git
Description
-------
We should use InstancesResult, InstancesSummaryResult, APIResult, EntityList and other classes from falcon-client directly.
org.apache.falcon.regression.core.response.EntitiesResult -> org.apache.falcon.resource.EntityList
org.apache.falcon.regression.core.response.EntityResult -> org.apache.falcon.resource.EntityList.EntityElement
org.apache.falcon.regression.core.response.InstancesResult -> org.apache.falcon.resource.InstancesResult
org.apache.falcon.regression.core.response.InstancesSummaryResult -> org.apache.falcon.resource.InstancesSummaryResult
org.apache.falcon.regression.core.response.APIResult -> org.apache.falcon.resource.APIResult
Diffs
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java PRE-CREATION
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/ClusterEntityHelperImpl.java 38ca37d
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 89c4883
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/APIResult.java 7464e18
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/EntitiesResult.java 7344d21
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/EntityResult.java a91493f
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/InstancesResult.java 45ca85e
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/InstancesSummaryResult.java eca972c
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ResponseKeys.java 45896f9
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java badab3d
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 6983212
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java 8fe10f4
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 22c34f7
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 18b54f8
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java f8ce97e
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java f6c068d
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java 031b32d
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 4ba5840
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSubmitAndScheduleTest.java d066910
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceParamTest.java 88cfc2f
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceSummaryTest.java bf952f7
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NewRetryTest.java d4f31e9
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessFrequencyTest.java 229cdcb
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceColoMixedTest.java a219d5a
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 6c92711
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java e704309
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java 8ffeb09
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java d3af1c0
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 7b3fb62
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java 049f278
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java 5abc932
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java 514bc52
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiProcessInstanceTest.java 5868882
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java 632d09d
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java 145b9de
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ProcessPipelineTest.java ee5316d
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/NewPrismProcessUpdateTest.java 3e85cb3
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSnSTest.java 4784dec
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessSnSTest.java 4768e68
Diff: https://reviews.apache.org/r/28515/diff/
Testing
-------
EmbeddedPigScriptTest, FeedSubmitAndScheduleTest, ProcessInstanceResumeTest, ProcessInstanceSuspendTest, ListEntitiesTest, ProcessPipelineTest
Thanks,
Ruslan Ostafiychuk
Re: Review Request 28515: Use APIResult and other support classes from
falcon-client in falcon-regression
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28515/#review63218
-----------------------------------------------------------
Ship it!
looks good
- Paul Isaychuk
On Nov. 27, 2014, 12:15 p.m., Ruslan Ostafiychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28515/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 12:15 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-699
> https://issues.apache.org/jira/browse/FALCON-699
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> We should use InstancesResult, InstancesSummaryResult, APIResult, EntityList and other classes from falcon-client directly.
> org.apache.falcon.regression.core.response.EntitiesResult -> org.apache.falcon.resource.EntityList
> org.apache.falcon.regression.core.response.EntityResult -> org.apache.falcon.resource.EntityList.EntityElement
> org.apache.falcon.regression.core.response.InstancesResult -> org.apache.falcon.resource.InstancesResult
> org.apache.falcon.regression.core.response.InstancesSummaryResult -> org.apache.falcon.resource.InstancesSummaryResult
> org.apache.falcon.regression.core.response.APIResult -> org.apache.falcon.resource.APIResult
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java PRE-CREATION
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/ClusterEntityHelperImpl.java 38ca37d
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 89c4883
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/APIResult.java 7464e18
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/EntitiesResult.java 7344d21
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/EntityResult.java a91493f
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/InstancesResult.java 45ca85e
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/InstancesSummaryResult.java eca972c
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ResponseKeys.java 45896f9
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java badab3d
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java 6983212
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java 8fe10f4
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 22c34f7
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 18b54f8
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java f8ce97e
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java f6c068d
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java 031b32d
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java 4ba5840
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSubmitAndScheduleTest.java d066910
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceParamTest.java 88cfc2f
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceSummaryTest.java bf952f7
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NewRetryTest.java d4f31e9
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessFrequencyTest.java 229cdcb
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceColoMixedTest.java a219d5a
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 6c92711
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java e704309
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java 8ffeb09
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java d3af1c0
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 7b3fb62
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java 049f278
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java 5abc932
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java 514bc52
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiProcessInstanceTest.java 5868882
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java 632d09d
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java 145b9de
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ProcessPipelineTest.java ee5316d
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/NewPrismProcessUpdateTest.java 3e85cb3
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSnSTest.java 4784dec
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessSnSTest.java 4768e68
>
> Diff: https://reviews.apache.org/r/28515/diff/
>
>
> Testing
> -------
>
> EmbeddedPigScriptTest, FeedSubmitAndScheduleTest, ProcessInstanceResumeTest, ProcessInstanceSuspendTest, ListEntitiesTest, ProcessPipelineTest
>
>
> Thanks,
>
> Ruslan Ostafiychuk
>
>