You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/16 11:17:43 UTC

[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #12388: [Fix-12368] [Task Plugin] Fix DataX plugin NPE issue.

EricGao888 commented on code in PR #12388:
URL: https://github.com/apache/dolphinscheduler/pull/12388#discussion_r996428558


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxTask.java:
##########
@@ -393,18 +392,17 @@ private String buildShellCommandFile(String jobConfigFilePath, Map<String, Prope
         }
 
         // datax python command
-        StringBuilder sbr = new StringBuilder();

Review Comment:
   May I ask why you change to use `String` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org