[GitHub] [superset] lyndsiWilliams commented on a diff in pull request #22011: fix: Change downloadAsImage to use Superset theme

[GitBox <gi...@apache.org>]

lyndsiWilliams commented on code in PR #22011:
URL: https://github.com/apache/superset/pull/22011#discussion_r1012369684


##########
superset-frontend/src/utils/downloadAsImage.ts:
##########
@@ -77,7 +71,7 @@ export default function downloadAsImage(
     return domToImage
       .toJpeg(elementToPrint, {
         quality: 0.95,
-        bgcolor: GRAY_BACKGROUND_COLOR,
+        bgcolor: supersetTheme.colors.primary.light3,

Review Comment:
   Yeah, that makes sense to me! Since #f5f5f5 wasn't in the theme I wasn't sure which was the correct color to choose here. Thanks for the point in the right direction! Corrected the color in [`this commit`](https://github.com/apache/superset/pull/22011/commits/34ab7e753991aa3f61d5f13819bb7db70ced9a42).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org