You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2018/12/07 09:38:23 UTC

[Bug 62989] New: HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

            Bug ID: 62989
           Summary: HTML generated by Apache httpd itself is often invalid
                    or uses ancient doctypes (and patches to fix that)
           Product: Apache httpd-2
           Version: 2.4.37
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: All
          Assignee: bugs@httpd.apache.org
          Reporter: deepbluemistake@gmail.com
  Target Milestone: ---

Created attachment 36299
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36299&action=edit
Patch that adds important doctypes to the doctype defines

Hello!
I noticed that most of the time, when Apache httpd itself generates HTML output
(like for 404 pages and autoindex pages) it uses ancient HTML 2.0 and HTML 3.2
doctypes.
These 11 attached diffs update those. The most important of these diffs is
httpdh.diff
I compiled and tested these diffs, and everything I tested works fine! Browsers
now render those pages in standards mode rather than quirks mode.
While I made these patches for httpd 2.4.37 these patches would likely also be
useful for trunk.
This could be the first step in making sure all the HTML output is more valid.
I also originally sent this here:
https://lists.apache.org/thread.html/e906a9ac878dc7de35d875006b6714c9fc8b0812e6780c8286fe6c66@%3Cdev.httpd.apache.org%3E
Thanks for reading!

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

--- Comment #14 from Andra Farkas <de...@gmail.com> ---
(In reply to Stefan Eissing from comment #12)
> I agree that updating doc types here is good. And we can add the patches to
> trunk easily. 
> 
> However, I think we cannot backport them for a 2.4.x release. There are
> screenscrapers out there and expierience tells me that we would break at
> least one that is really important to someone.
> 
> Would you agree?

Sure!  If this patch gets into trunk, I'd be happy. :D

If I need to re-do the diffs for trunk, let me know, and let me know the best
way to get the trunk code onto my computer so I can do it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

Giovanni Bechis <gi...@paclan.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36299|0                           |1
        is obsolete|                            |
  Attachment #36300|0                           |1
        is obsolete|                            |
  Attachment #36301|0                           |1
        is obsolete|                            |
  Attachment #36302|0                           |1
        is obsolete|                            |
  Attachment #36303|0                           |1
        is obsolete|                            |
  Attachment #36304|0                           |1
        is obsolete|                            |
  Attachment #36305|0                           |1
        is obsolete|                            |
  Attachment #36306|0                           |1
        is obsolete|                            |
  Attachment #36307|0                           |1
        is obsolete|                            |
  Attachment #36308|0                           |1
        is obsolete|                            |
  Attachment #36309|0                           |1
        is obsolete|                            |

--- Comment #16 from Giovanni Bechis <gi...@paclan.it> ---
Created attachment 36975
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36975&action=edit
update doctypes in generated html documents

Patch rebased to trunk version.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

Andra Farkas <de...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36300|Change doctype              |Change doctype in
        description|                            |http_protocol.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

--- Comment #5 from Andra Farkas <de...@gmail.com> ---
Created attachment 36304
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36304&action=edit
Change doctype

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

--- Comment #3 from Andra Farkas <de...@gmail.com> ---
Created attachment 36302
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36302&action=edit
Change doctype

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

--- Comment #12 from Stefan Eissing <st...@eissing.org> ---
I agree that updating doc types here is good. And we can add the patches to
trunk easily. 

However, I think we cannot backport them for a 2.4.x release. There are
screenscrapers out there and expierience tells me that we would break at least
one that is really important to someone.

Would you agree?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

--- Comment #15 from Andra Farkas <de...@gmail.com> ---
I still want help in getting this diff in.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

Eric Covener <co...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
           Keywords|                            |FixedInTrunk,
                   |                            |PatchAvailable
         Resolution|---                         |FIXED

--- Comment #17 from Eric Covener <co...@gmail.com> ---
Thanks Andra and Giovanni for your persistence, committed to trunk in r1873397.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

--- Comment #7 from Andra Farkas <de...@gmail.com> ---
Created attachment 36306
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36306&action=edit
Change doctype in mod_proxy_balancer.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

--- Comment #2 from Andra Farkas <de...@gmail.com> ---
Created attachment 36301
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36301&action=edit
Make the "It works!" page valid HTML

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

--- Comment #13 from Mario <JB...@gmail.com> ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

Andra Farkas <de...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36304|Change doctype              |Change doctype in
        description|                            |mod_example_hooks.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

Andra Farkas <de...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |deepbluemistake@gmail.com

--- Comment #1 from Andra Farkas <de...@gmail.com> ---
Created attachment 36300
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36300&action=edit
Change doctype

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

--- Comment #10 from Andra Farkas <de...@gmail.com> ---
Created attachment 36309
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36309&action=edit
Change doctype in util_ldap.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

--- Comment #9 from Andra Farkas <de...@gmail.com> ---
Created attachment 36308
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36308&action=edit
Change doctype in mod_status.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

Andra Farkas <de...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36303|Change doctype              |Change doctype in mod_dav.h
        description|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

--- Comment #4 from Andra Farkas <de...@gmail.com> ---
Created attachment 36303
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36303&action=edit
Change doctype

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

--- Comment #8 from Andra Farkas <de...@gmail.com> ---
Created attachment 36307
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36307&action=edit
Change doctype in mod_proxy_ftp.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

--- Comment #11 from Andra Farkas <de...@gmail.com> ---
Ping.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

--- Comment #6 from Andra Farkas <de...@gmail.com> ---
Created attachment 36305
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36305&action=edit
Change doctype in mod_imagemap.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 62989] HTML generated by Apache httpd itself is often invalid or uses ancient doctypes (and patches to fix that)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62989

Andra Farkas <de...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36302|Change doctype              |Change doctype in
        description|                            |mod_autoindex.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org