[GitHub] [accumulo] DomGarguilo commented on a change in pull request #2396: Add metric for number of open files for scans

[GitBox <gi...@apache.org>]

DomGarguilo commented on a change in pull request #2396:
URL: https://github.com/apache/accumulo/pull/2396#discussion_r772622450



##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/metrics/TabletServerScanMetrics.java
##########
@@ -44,8 +47,18 @@ public void addYield(long value) {
     yields.record(value);
   }
 
+  public void incrementOpenFiles(int numOpenFiles) {
+    openFiles.addAndGet(numOpenFiles);
+  }
+
+  public void decrementOpenFiles(int numOpenFiles) {

Review comment:
       In the cases where this is used, will the value of `openFiles` ever actually be decremented? It looks like `incrementOpenFiles()` and `decrementOpenFiles()` will both do the same thing at the moment. Is the idea that we always pass a negative number to `decrementOpenFiles()`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org