You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/01/24 05:40:02 UTC
[kudu-CR] Fix dependencies for util compression target
Hello Dan Burkert, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5778
to review the following change.
Change subject: Fix dependencies for util_compression target
......................................................................
Fix dependencies for util_compression target
A few dependencies were missing which caused build failures on OSX.
Verified by running ldd -r build/debug/lib/libkudu_util_compression.so
and checking there were no undefined symbols after the fix.
Change-Id: Ia42a73a6e1850dfb151e6624374acb472c9621a3
---
M src/kudu/util/CMakeLists.txt
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/5778/1
--
To view, visit http://gerrit.cloudera.org:8080/5778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia42a73a6e1850dfb151e6624374acb472c9621a3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] Fix dependencies for util compression target
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Fix dependencies for util_compression target
......................................................................
Patch Set 1: Code-Review+2
LGTM: verified by building the project on my macbook;
ProductName: Mac OS X
ProductVersion: 10.11.5
BuildVersion: 15F34
--
To view, visit http://gerrit.cloudera.org:8080/5778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia42a73a6e1850dfb151e6624374acb472c9621a3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Fix dependencies for util compression target
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Fix dependencies for util_compression target
......................................................................
Fix dependencies for util_compression target
A few dependencies were missing which caused build failures on OSX.
Verified by running ldd -r build/debug/lib/libkudu_util_compression.so
and checking there were no undefined symbols after the fix.
Change-Id: Ia42a73a6e1850dfb151e6624374acb472c9621a3
Reviewed-on: http://gerrit.cloudera.org:8080/5778
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/util/CMakeLists.txt
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia42a73a6e1850dfb151e6624374acb472c9621a3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>