You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/15 20:10:36 UTC
[GitHub] [incubator-superset] junlincc commented on pull request #12008: feat(explore-datasource): add new datasource tab to explore view
junlincc commented on pull request #12008:
URL: https://github.com/apache/incubator-superset/pull/12008#issuecomment-745538250
Thank you so much for making changes on this PR!
I'm seeing some regression after latest changes since last night.
1. I keep getting error msg when load chart data (i did not encounter last few time when i test, CRITICAL)
2. columns and metric sections are not scrollable (critical)
3. panel alignments (not critical, but should fix in this PR, )
<img width="781" alt="Screen Shot 2020-12-15 at 12 01 07 PM" src="https://user-images.githubusercontent.com/67837651/102266485-5e862700-3ecd-11eb-9d1b-1500f6d88e48.png">
4.line padding inconsistent (not critical, we can adjust later)
<img width="150" alt="Screen Shot 2020-12-15 at 12 02 50 PM" src="https://user-images.githubusercontent.com/67837651/102266557-79589b80-3ecd-11eb-91f3-4cb1ca0de8de.png">
5. uneven padding around datasource and "..." icon (@mihir174, your call)
6. Columns and Metrics should be bold, according to the design
7. Spacing between is too large
<img width="218" alt="Screen Shot 2020-12-15 at 12 06 44 PM" src="https://user-images.githubusercontent.com/67837651/102267103-419e2380-3ece-11eb-9c25-005f633bfafe.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org