You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Lance Norskog (JIRA)" <ji...@apache.org> on 2010/02/21 03:04:27 UTC
[jira] Created: (SOLR-1784) Improve error-handling in facet
requests
Improve error-handling in facet requests
----------------------------------------
Key: SOLR-1784
URL: https://issues.apache.org/jira/browse/SOLR-1784
Project: Solr
Issue Type: Improvement
Components: search
Affects Versions: 1.4, 1.3, 1.2
Reporter: Lance Norskog
Priority: Minor
Fix For: 1.5
A reference to non-declared tag in a facet expression does not give any error. Instead, no facets are returned. Other errors in facet expressions are reported as a successful request with an element called 'exception' giving a stack trace.
All requests to Solr should succeed completely or fail, and failures should return as an appropriate HTTP protocol error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1784) Improve error-handling in facet
requests
Posted by "Lance Norskog (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836314#action_12836314 ]
Lance Norskog commented on SOLR-1784:
-------------------------------------
This issue was inspired by this:
http://www.lucidimagination.com/search/document/5378219fa4aec459/labeling_facets_and_highlighting_question
bq. Excluding an undefined tag has been defined to be the same as excluding nothing, hence the facet counts will be unchanged.
This definition is not documented on the wiki (or anywhere I can find). Is there a use case where this is the right thing to do? Is there a use case in which the user knowingly refers to a tag without defining it?
Otherwise, this is always a user error that receives no error feedback.
> Improve error-handling in facet requests
> ----------------------------------------
>
> Key: SOLR-1784
> URL: https://issues.apache.org/jira/browse/SOLR-1784
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.2, 1.3, 1.4
> Reporter: Lance Norskog
> Priority: Minor
> Fix For: 1.5
>
> Attachments: SOLR-1784.patch
>
>
> A reference to non-declared tag in a facet expression does not give any error. Instead, no facets are returned. Other errors in facet expressions are reported as a successful request with an element called 'exception' giving a stack trace.
> All requests to Solr should succeed completely or fail, and failures should return as an appropriate HTTP protocol error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1784) Improve error-handling in facet
requests
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836309#action_12836309 ]
Yonik Seeley commented on SOLR-1784:
------------------------------------
Looks like this is working as designed, as demonstrated by the tests that this patch removes.
bq. Instead, no facets are returned.
I can't reproduce this. Excluding an undefined tag has been defined to be the same as excluding nothing, hence the facet counts will be unchanged. Can you provide an example where no facet results are returned?
> Improve error-handling in facet requests
> ----------------------------------------
>
> Key: SOLR-1784
> URL: https://issues.apache.org/jira/browse/SOLR-1784
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.2, 1.3, 1.4
> Reporter: Lance Norskog
> Priority: Minor
> Fix For: 1.5
>
> Attachments: SOLR-1784.patch
>
>
> A reference to non-declared tag in a facet expression does not give any error. Instead, no facets are returned. Other errors in facet expressions are reported as a successful request with an element called 'exception' giving a stack trace.
> All requests to Solr should succeed completely or fail, and failures should return as an appropriate HTTP protocol error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1784) Improve error-handling in facet
requests
Posted by "Lance Norskog (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lance Norskog updated SOLR-1784:
--------------------------------
Attachment: SOLR-1784.patch
> Improve error-handling in facet requests
> ----------------------------------------
>
> Key: SOLR-1784
> URL: https://issues.apache.org/jira/browse/SOLR-1784
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.2, 1.3, 1.4
> Reporter: Lance Norskog
> Priority: Minor
> Fix For: 1.5
>
> Attachments: SOLR-1784.patch
>
>
> A reference to non-declared tag in a facet expression does not give any error. Instead, no facets are returned. Other errors in facet expressions are reported as a successful request with an element called 'exception' giving a stack trace.
> All requests to Solr should succeed completely or fail, and failures should return as an appropriate HTTP protocol error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1784) Improve error-handling in facet
requests
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836317#action_12836317 ]
Yonik Seeley commented on SOLR-1784:
------------------------------------
It was an explicit design decision, as shown by the tests.
When doing multi-select faceting, it's useful to be able to exclude a class of filters without worrying about if any of those filters are currently being used.
> Improve error-handling in facet requests
> ----------------------------------------
>
> Key: SOLR-1784
> URL: https://issues.apache.org/jira/browse/SOLR-1784
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.2, 1.3, 1.4
> Reporter: Lance Norskog
> Priority: Minor
> Fix For: 1.5
>
> Attachments: SOLR-1784.patch
>
>
> A reference to non-declared tag in a facet expression does not give any error. Instead, no facets are returned. Other errors in facet expressions are reported as a successful request with an element called 'exception' giving a stack trace.
> All requests to Solr should succeed completely or fail, and failures should return as an appropriate HTTP protocol error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.