You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2019/04/09 19:20:46 UTC
[Bug 63330] New: XSSFBParser should use skipfully
https://bz.apache.org/bugzilla/show_bug.cgi?id=63330
Bug ID: 63330
Summary: XSSFBParser should use skipfully
Product: POI
Version: 4.0.x-dev
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: XSSF
Assignee: dev@poi.apache.org
Reporter: tallison@apache.org
Target Milestone: ---
There were a handful of new exceptions on xlsb files on a recent run of
regression tests.
I'm not able to replicate this problem and the files I've reviewed are not
truncated. I _think_ the problem is that we're relying on "skip" rather than
"skipFully".
I propose modifying the one line in XSSFBParser and fixing
LittleEndianInputStream's "skipFully" to throw an EOF if the skip isn't
complete...to make it parallel with its "readFully"
The stacktraces were all triggered by running getAbsPathMetadata():
org.apache.poi.xssf.binary.XSSFBParseException: End of file reached before
expected.
Tried to skip 105, but only skipped 61
at
org.apache.poi.xssf.binary.XSSFBParser.readNext(XSSFBParser.java:101)
at org.apache.poi.xssf.binary.XSSFBParser.parse(XSSFBParser.java:66)
at
org.apache.poi.xssf.eventusermodel.XSSFBReader.getAbsPathMetadata(XSSFBReader.java:92)
at
org.apache.tika.parser.microsoft.ooxml.XSSFBExcelExtractorDecorator.buildXHTML(XSSFBExcelExtractorDecorator.java:87)
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 63330] XSSFBParser should use skipfully
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63330
Tim Allison <ta...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #1 from Tim Allison <ta...@apache.org> ---
It turns out that there are a few handfuls of places in our codebase where we
should be using skipfully. Unless there are objections, I'll make those
changes shortly.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 63330] Use skipfully instead of skip
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63330
Tim Allison <ta...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|XSSFBParser should use |Use skipfully instead of
|skipfully |skip
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 63330] Use skipfully instead of skip
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63330
Tim Allison <ta...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Tim Allison <ta...@apache.org> ---
r1857277
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org