You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/30 03:32:46 UTC

[GitHub] [skywalking-data-collect-protocol] heyanlong commented on a change in pull request #21: Add golang package

heyanlong commented on a change in pull request #21: Add golang package
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/21#discussion_r399909784
 
 

 ##########
 File path: browser/BrowserPerf.proto
 ##########
 @@ -22,6 +22,7 @@ package skywalking.network.protocol.browser;
 
 option java_multiple_files = true;
 option java_package = "org.apache.skywalking.apm.network.language.agent";
+option go_package = "agent/pb/language/agent";
 
 Review comment:
   > @heyanlong您的命名规则是什么？它们不一致，而且我看不到模式。
   
   From java
   network -> pb
   language -> language
   agent -> agent
   
   and so
   projectName/pb/language/agent

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services