You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2017/01/09 10:14:18 UTC
[GitHub] zeppelin pull request #1877: [ZEPPELIN-1930](HotFix) PythonInterpreter synta...
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/1877
[ZEPPELIN-1930](HotFix) PythonInterpreter syntax error.
### What is this PR for?
This PR fixes syntax error of PythonInterpreter.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1930
### How should this be tested?
Please run following code on the paragraph of PythonInterpreter.
```
for x in range(0,3): print ("hi")
```
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1930
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1877.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1877
----
commit 5a7e1b3cbaf2d98f1b38fa6c3449b2aa73ff9e65
Author: astroshim <hs...@zepl.com>
Date: 2017-01-09T10:08:48Z
fix syntax error.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1877: [ZEPPELIN-1930](HotFix) PythonInterpreter syntax error...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1877
LGTM and merge to master if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1877: [ZEPPELIN-1930](HotFix) PythonInterpreter syntax error...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1877
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1877: [ZEPPELIN-1930](HotFix) PythonInterpreter synta...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1877
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1877: [ZEPPELIN-1930](HotFix) PythonInterpreter syntax error...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1877
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1877: [ZEPPELIN-1930](HotFix) PythonInterpreter syntax error...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1877
I faced the same problem too. Thanks for fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1877: [ZEPPELIN-1930](HotFix) PythonInterpreter syntax error...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1877
@agoodm pyspark interpreter is working well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1877: [ZEPPELIN-1930](HotFix) PythonInterpreter synta...
Posted by astroshim <gi...@git.apache.org>.
GitHub user astroshim reopened a pull request:
https://github.com/apache/zeppelin/pull/1877
[ZEPPELIN-1930](HotFix) PythonInterpreter syntax error.
### What is this PR for?
This PR fixes syntax error of PythonInterpreter.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1930
### How should this be tested?
Please run following code on the paragraph of PythonInterpreter.
```
for x in range(0,3): print ("hi")
```
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1930
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1877.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1877
----
commit 5a7e1b3cbaf2d98f1b38fa6c3449b2aa73ff9e65
Author: astroshim <hs...@zepl.com>
Date: 2017-01-09T10:08:48Z
fix syntax error.
commit 573140fe3ccecd7331e71ece53202d51ca2c2ab3
Author: astroshim <hs...@zepl.com>
Date: 2017-01-09T14:49:27Z
add test-case
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1877: [ZEPPELIN-1930](HotFix) PythonInterpreter synta...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1877
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1877: [ZEPPELIN-1930](HotFix) PythonInterpreter syntax error...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1877
@Leemoonsoo I added testcase, could you help to review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1877: [ZEPPELIN-1930](HotFix) PythonInterpreter syntax error...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1877
Thanks for the fix. \cc @agoodm
How about add an unittest for this case in https://github.com/apache/zeppelin/blob/master/python/src/test/java/org/apache/zeppelin/python/PythonInterpreterTest.java, if it is not too difficult?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1877: [ZEPPELIN-1930](HotFix) PythonInterpreter syntax error...
Posted by agoodm <gi...@git.apache.org>.
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1877
I am on vacation right now so I can't thoroughly examine this, but have you confirmed that this isn't a problem for the pyspark interpreter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---