You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2016/04/15 03:01:30 UTC
Review Request 46241: Upgrade to Mesos 0.27.2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46241/
-----------------------------------------------------------
Review request for Aurora, John Sirois and Zameer Manji.
Repository: aurora
Description
-------
N.B.: I won't commit this until 0.13.0 has been released.
I've built a new box for Vagrant using these settings and I'll upload it in concert with this commit.
Release notes here: http://mesos.apache.org/blog/mesos-0-27-0-released/
Upgrade notes here: http://mesos.apache.org/documentation/latest/upgrades/#0-27-x-implicit-roles
Diffs
-----
3rdparty/python/BUILD e7a1fe4a94190ad6090d7c800cfebd8b8c3dfed1
RELEASE-NOTES.md a0536ec352119952d4d58aa5f36e5e9a7b7d2e6e
build-support/packer/build.sh 146e62e5ff7e2f4163083029cbf1688234100d3d
build.gradle e4e42fdf8f4c7dee41ec4ca009bceb6858cad93f
Diff: https://reviews.apache.org/r/46241/diff/
Testing
-------
build-support/jenkins/build.sh
ran e2e tests.
Thanks,
Joshua Cohen
Re: Review Request 46241: Upgrade to Mesos 0.27.2
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46241/#review129055
-----------------------------------------------------------
Ship it!
Master (de046f7) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 15, 2016, 1:01 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46241/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 1:01 a.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> N.B.: I won't commit this until 0.13.0 has been released.
>
> I've built a new box for Vagrant using these settings and I'll upload it in concert with this commit.
>
> Release notes here: http://mesos.apache.org/blog/mesos-0-27-0-released/
> Upgrade notes here: http://mesos.apache.org/documentation/latest/upgrades/#0-27-x-implicit-roles
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD e7a1fe4a94190ad6090d7c800cfebd8b8c3dfed1
> RELEASE-NOTES.md a0536ec352119952d4d58aa5f36e5e9a7b7d2e6e
> build-support/packer/build.sh 146e62e5ff7e2f4163083029cbf1688234100d3d
> build.gradle e4e42fdf8f4c7dee41ec4ca009bceb6858cad93f
>
> Diff: https://reviews.apache.org/r/46241/diff/
>
>
> Testing
> -------
>
> build-support/jenkins/build.sh
> ran e2e tests.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46241: Upgrade to Mesos 0.27.2
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46241/#review129144
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On April 14, 2016, 6:01 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46241/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 6:01 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> N.B.: I won't commit this until 0.13.0 has been released.
>
> I've built a new box for Vagrant using these settings and I'll upload it in concert with this commit.
>
> Release notes here: http://mesos.apache.org/blog/mesos-0-27-0-released/
> Upgrade notes here: http://mesos.apache.org/documentation/latest/upgrades/#0-27-x-implicit-roles
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD e7a1fe4a94190ad6090d7c800cfebd8b8c3dfed1
> RELEASE-NOTES.md a0536ec352119952d4d58aa5f36e5e9a7b7d2e6e
> build-support/packer/build.sh 146e62e5ff7e2f4163083029cbf1688234100d3d
> build.gradle e4e42fdf8f4c7dee41ec4ca009bceb6858cad93f
>
> Diff: https://reviews.apache.org/r/46241/diff/
>
>
> Testing
> -------
>
> build-support/jenkins/build.sh
> ran e2e tests.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46241: Upgrade to Mesos 0.27.2
Posted by John Sirois <js...@apache.org>.
> On April 14, 2016, 7:08 p.m., John Sirois wrote:
> > Looks like we do ~nothing with executorLost so LGTM.
> > I can only imagine folks pagers going off more if they happened to alert on `scheduler_lost_executors`, which should now be higher if the upgrade notes are to be believed.
>
> Joshua Cohen wrote:
> Do you think that's worth calling out in the release notes? I'd assume given that `executorLost` was not invoked before that no one is alerting on `scheduler_lost_executors` since, in theory, it would've always been 0.
I don't think it's worth calling out.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46241/#review129054
-----------------------------------------------------------
On April 14, 2016, 7:01 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46241/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 7:01 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> N.B.: I won't commit this until 0.13.0 has been released.
>
> I've built a new box for Vagrant using these settings and I'll upload it in concert with this commit.
>
> Release notes here: http://mesos.apache.org/blog/mesos-0-27-0-released/
> Upgrade notes here: http://mesos.apache.org/documentation/latest/upgrades/#0-27-x-implicit-roles
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD e7a1fe4a94190ad6090d7c800cfebd8b8c3dfed1
> RELEASE-NOTES.md a0536ec352119952d4d58aa5f36e5e9a7b7d2e6e
> build-support/packer/build.sh 146e62e5ff7e2f4163083029cbf1688234100d3d
> build.gradle e4e42fdf8f4c7dee41ec4ca009bceb6858cad93f
>
> Diff: https://reviews.apache.org/r/46241/diff/
>
>
> Testing
> -------
>
> build-support/jenkins/build.sh
> ran e2e tests.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46241: Upgrade to Mesos 0.27.2
Posted by Joshua Cohen <jc...@apache.org>.
> On April 15, 2016, 1:08 a.m., John Sirois wrote:
> > Looks like we do ~nothing with executorLost so LGTM.
> > I can only imagine folks pagers going off more if they happened to alert on `scheduler_lost_executors`, which should now be higher if the upgrade notes are to be believed.
Do you think that's worth calling out in the release notes? I'd assume given that `executorLost` was not invoked before that no one is alerting on `scheduler_lost_executors` since, in theory, it would've always been 0.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46241/#review129054
-----------------------------------------------------------
On April 15, 2016, 1:01 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46241/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 1:01 a.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> N.B.: I won't commit this until 0.13.0 has been released.
>
> I've built a new box for Vagrant using these settings and I'll upload it in concert with this commit.
>
> Release notes here: http://mesos.apache.org/blog/mesos-0-27-0-released/
> Upgrade notes here: http://mesos.apache.org/documentation/latest/upgrades/#0-27-x-implicit-roles
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD e7a1fe4a94190ad6090d7c800cfebd8b8c3dfed1
> RELEASE-NOTES.md a0536ec352119952d4d58aa5f36e5e9a7b7d2e6e
> build-support/packer/build.sh 146e62e5ff7e2f4163083029cbf1688234100d3d
> build.gradle e4e42fdf8f4c7dee41ec4ca009bceb6858cad93f
>
> Diff: https://reviews.apache.org/r/46241/diff/
>
>
> Testing
> -------
>
> build-support/jenkins/build.sh
> ran e2e tests.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46241: Upgrade to Mesos 0.27.2
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46241/#review129054
-----------------------------------------------------------
Ship it!
Looks like we do ~nothing with executorLost so LGTM.
I can only imagine folks pagers going off more if they happened to alert on `scheduler_lost_executors`, which should now be higher if the upgrade notes are to be believed.
- John Sirois
On April 14, 2016, 7:01 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46241/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 7:01 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> N.B.: I won't commit this until 0.13.0 has been released.
>
> I've built a new box for Vagrant using these settings and I'll upload it in concert with this commit.
>
> Release notes here: http://mesos.apache.org/blog/mesos-0-27-0-released/
> Upgrade notes here: http://mesos.apache.org/documentation/latest/upgrades/#0-27-x-implicit-roles
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD e7a1fe4a94190ad6090d7c800cfebd8b8c3dfed1
> RELEASE-NOTES.md a0536ec352119952d4d58aa5f36e5e9a7b7d2e6e
> build-support/packer/build.sh 146e62e5ff7e2f4163083029cbf1688234100d3d
> build.gradle e4e42fdf8f4c7dee41ec4ca009bceb6858cad93f
>
> Diff: https://reviews.apache.org/r/46241/diff/
>
>
> Testing
> -------
>
> build-support/jenkins/build.sh
> ran e2e tests.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46241: Upgrade to Mesos 0.27.2
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46241/#review129142
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On April 15, 2016, 1:01 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46241/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 1:01 a.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> N.B.: I won't commit this until 0.13.0 has been released.
>
> I've built a new box for Vagrant using these settings and I'll upload it in concert with this commit.
>
> Release notes here: http://mesos.apache.org/blog/mesos-0-27-0-released/
> Upgrade notes here: http://mesos.apache.org/documentation/latest/upgrades/#0-27-x-implicit-roles
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD e7a1fe4a94190ad6090d7c800cfebd8b8c3dfed1
> RELEASE-NOTES.md a0536ec352119952d4d58aa5f36e5e9a7b7d2e6e
> build-support/packer/build.sh 146e62e5ff7e2f4163083029cbf1688234100d3d
> build.gradle e4e42fdf8f4c7dee41ec4ca009bceb6858cad93f
>
> Diff: https://reviews.apache.org/r/46241/diff/
>
>
> Testing
> -------
>
> build-support/jenkins/build.sh
> ran e2e tests.
>
>
> Thanks,
>
> Joshua Cohen
>
>