You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Andrei Sekretenko (Jira)" <ji...@apache.org> on 2020/09/03 16:12:00 UTC
[jira] [Commented] (MESOS-10166) Avoid sending framework updates to
agents and subscribers when frameworkInfo/pid didn't change.
[ https://issues.apache.org/jira/browse/MESOS-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190258#comment-17190258 ]
Andrei Sekretenko commented on MESOS-10166:
-------------------------------------------
{noformat}
commit 9bb35fe23fed7756af9ceebccea74bf175fa6e47
Author: Andrei Sekretenko <as...@mesosphere.com>
Date: Mon Aug 31 18:34:00 2020 +0200
Extracted FrameworkInfo comparison logic from tests.
This patch extracts the code that performs `FrameworkInfo` comparison
via protobuf `MessageDifferencer` from the framework update tests
into a set of general-purpose methods.
Review: https://reviews.apache.org/r/72822
commit 8839af89e2ace33c7b7223790a9a75e67cf43110
Author: Andrei Sekretenko <as...@mesosphere.com>
Date: Mon Aug 31 18:34:00 2020 +0200
Removed `bool operator==(const FrameworkInfo&, const FrameworkInfo&)`.
This patch removes the outdated `operator==` for `FrameworkInfo`
(which has been comparing only `name` and `user` fields)
and replaces it with `equivalent()` in the tests that need to compare
`FrameworkInfo`s.
Review: https://reviews.apache.org/r/72833
commit 720cc709339efb51a7c464bb3fc547cf0935c911
Author: Andrei Sekretenko <as...@mesosphere.com>
Date: Mon Aug 31 18:35:16 2020 +0200
Eliminated redundant update broadcasts in UPDATE_FRAMEWORK.
This patch makes the UPDATE_FRAMEWORK call avoid sending the
`UpdatedFrameworkMessage` to agents and the `FRAMEWORK_UPDATED`
event to V1 API subscribers when the FrameworkInfo is not changed
by the call.
Review: https://reviews.apache.org/r/72824
commit 2bf7f5d8dcb359845a663a011a941809ffc2366d (HEAD -> master, origin/master, origin/HEAD)
Author: Andrei Sekretenko <as...@mesosphere.com>
Date: Mon Aug 31 20:46:55 2020 +0200
Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo.
This test verifies that calling UPDATE_FRAMEWORK with no changes in
`FrameworkInfo` (i.e. to change suppressed roles or offer constraints)
results in no API event FRAMEWORK_UPDATED sent to the subscribers and
no `UpdatedFrameworkMessage` broadcast to the agents.
Review: https://reviews.apache.org/r/72825
{noformat}
> Avoid sending framework updates to agents and subscribers when frameworkInfo/pid didn't change.
> -----------------------------------------------------------------------------------------------
>
> Key: MESOS-10166
> URL: https://issues.apache.org/jira/browse/MESOS-10166
> Project: Mesos
> Issue Type: Task
> Components: master
> Reporter: Andrei Sekretenko
> Assignee: Andrei Sekretenko
> Priority: Major
>
> Currently, FrameworkInfo is broadcast to agents and V1API events subscribers on every framework resubscription/update, regardless of whether it has actually changed or not.
> When schedulers frequently call UPDATE_FRAMEWORK to only update subscription settings (the list of suppressed roles, and, after implementing https://issues.apache.org/jira/browse/MESOS-10161, offer constraints), the FrameworkInfo broadcast on every UPDATE_FRAMEWORK call becomes undesirable.
> Sending 'pid' update to agents is affected by the same issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)