You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "Fokko Driesprong (JIRA)" <ji...@apache.org> on 2019/04/11 22:01:00 UTC

[jira] [Resolved] (AIRFLOW-4269) For-lop in jobs._process_task_instances can be faster by breaking from unnecessary steps

     [ https://issues.apache.org/jira/browse/AIRFLOW-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fokko Driesprong resolved AIRFLOW-4269.
---------------------------------------
       Resolution: Fixed
    Fix Version/s: 2.0.0

> For-lop in jobs._process_task_instances can be faster by breaking from unnecessary steps
> ----------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-4269
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4269
>             Project: Apache Airflow
>          Issue Type: Improvement
>    Affects Versions: 1.10.2
>            Reporter: Xiaodong DENG
>            Assignee: Xiaodong DENG
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> [https://github.com/apache/airflow/blob/64331aa5b90c44a3a22631d0ed168c44842a1fc8/airflow/jobs.py#L923] is a "continue" while it should be a break.
> When *len(active_dag_runs) >= dag.max_active_runs* , the following part of the for-loop will give the same result and result in a "continue" again and again, doing nothing. 
> We should use a "break" here.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)